[Engine-patches] Change in ovirt-engine[master]: core: Get import VM command to support snapshots

2012-03-05 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Get import VM command to support snapshots .. core: Get import VM command to support snapshots For starters, import command should always re-creat

[Engine-patches] Change in ovirt-engine[master]: core: Get import VM command to support snapshots

2012-03-05 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Get import VM command to support snapshots .. Patch Set 9: Verified; Looks good to me, approved Rebased, ack (+2) by ofrenkel -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: webadmin: Allow snapshots creation when VM is up

2012-03-05 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: webadmin: Allow snapshots creation when VM is up .. webadmin: Allow snapshots creation when VM is up Block a new snapshot creation when the VM is locked

[Engine-patches] Change in ovirt-engine[master]: webadmin: Allow snapshots creation when VM is up

2012-03-05 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: webadmin: Allow snapshots creation when VM is up .. Patch Set 8: Verified; Looks good to me, approved Rebased, ack (+2) by gchaplik -- To view, visit http://ger

[Engine-patches] Change in ovirt-engine[master]: core: Call live snapshot in the end of snap create

2012-03-05 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Call live snapshot in the end of snap create .. core: Call live snapshot in the end of snap create Call the live snapshot in the end of CreateAllS

[Engine-patches] Change in ovirt-engine[master]: core: Call live snapshot in the end of snap create

2012-03-05 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Call live snapshot in the end of snap create .. Patch Set 9: Verified; Looks good to me, approved Rebased, ack (+2) by ofrenkel -- To view, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: Add SnapshotVDSCommand

2012-03-05 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Add SnapshotVDSCommand .. core: Add SnapshotVDSCommand This command will be used to call the live snapshot verb on VDSM. Change-Id: I6cbd8ee13c6a

[Engine-patches] Change in ovirt-engine[master]: core: Add SnapshotVDSCommand

2012-03-05 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Add SnapshotVDSCommand .. Patch Set 9: Verified; Looks good to me, approved Rebased, ack (+2) by ofrenkel -- To view, visit http://gerrit.ovirt.org/2423 T

[Engine-patches] Change in ovirt-engine[master]: core: Delete stateless_vm_image_map

2012-03-05 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Delete stateless_vm_image_map .. core: Delete stateless_vm_image_map Now that stateless snapshot is an actual entity in DB and all work is done wi

[Engine-patches] Change in ovirt-engine[master]: core: Delete stateless_vm_image_map

2012-03-05 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Delete stateless_vm_image_map .. Patch Set 10: Verified; Looks good to me, approved Rebased, ack (+2) by ofrenkel -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: Migrate snapshots data & start using table

2012-03-05 Thread mkolesni
Mike Kolesnik has submitted this change and it was merged. Change subject: core: Migrate snapshots data & start using table .. core: Migrate snapshots data & start using table Added an upgrade script which extracts all snapshot

[Engine-patches] Change in ovirt-engine[master]: core: Migrate snapshots data & start using table

2012-03-05 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Migrate snapshots data & start using table .. Patch Set 10: Verified; Looks good to me, approved Rebased, ack (+2) by ofrenkel -- To view, visit http://ge

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 288 - Failure!

2012-03-05 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 288 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/288/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listi

[Engine-patches] [oVirt Jenkins] ovirt_engine_gwt_user-gwtp - Build # 240 - Failure!

2012-03-05 Thread Jenkins oVirt Server
ovirt_engine_gwt_user-gwtp - Build # 240 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_gwt_user-gwtp/240/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman

[Engine-patches] (no subject)

2012-03-05 Thread Jenkins oVirt Server
___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] [oVirt Jenkins] ovirt_engine_dao_unit_tests - Build # 276 - Failure!

2012-03-05 Thread Jenkins oVirt Server
ovirt_engine_dao_unit_tests - Build # 276 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/276/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailm

[Engine-patches] Change in ovirt-engine[master]: core: VmPoolHandler Adaptation

2012-03-05 Thread msalem
Muli Salem has submitted this change and it was merged. Change subject: core: VmPoolHandler Adaptation .. core: VmPoolHandler Adaptation This patch changes the VmPoolHandler to properly clean the stateless images whether the Vm

[Engine-patches] Change in ovirt-engine[master]: core: VmPoolHandler Adaptation

2012-03-05 Thread msalem
Muli Salem has posted comments on this change. Change subject: core: VmPoolHandler Adaptation .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2577 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core: Fixes in quota remove

2012-03-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Fixes in quota remove .. Patch Set 1: (2 inline comments) File backend/manager/modules/bll/src/main/ja

[Engine-patches] Change in ovirt-engine[master]: core: adding service strategy for gluster integration

2012-03-05 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: adding service strategy for gluster integration .. Patch Set 9: Changes in latest patch: Shireesh - changed the process software capabilities as you request

[Engine-patches] Change in ovirt-engine[master]: history: change view to join snapshots

2012-03-05 Thread emesika
Eli Mesika has posted comments on this change. Change subject: history: change view to join snapshots .. Patch Set 3: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2536 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: core: add optional field to cluster networks

2012-03-05 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: add optional field to cluster networks .. Patch Set 4: (1 inline comment) File backend/manager/modules/

[Engine-patches] Change in ovirt-engine[master]: restapi: Fix findbugs errors

2012-03-05 Thread masayag
Moti Asayag has posted comments on this change. Change subject: restapi: Fix findbugs errors .. Patch Set 2: (1 inline comment) File backend/manager/modules/restapi/types/sr

[Engine-patches] Change in ovirt-engine[master]: webadmin: Introducing Quota Feature

2012-03-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: webadmin: Introducing Quota Feature .. Patch Set 1: (1 inline comment) File frontend/webadmin/modules/webadm

[Engine-patches] Change in ovirt-engine[master]: core: add support for bridgeless network in SetupNetworks

2012-03-05 Thread rgolan
Roy Golan has posted comments on this change. Change subject: core: add support for bridgeless network in SetupNetworks .. Patch Set 7: (1 inline comment) File backend/manag

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 287 - Fixed!

2012-03-05 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 287 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/287/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinf

[Engine-patches] Change in ovirt-engine[master]: webadmin: Introducing Quota Feature

2012-03-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: webadmin: Introducing Quota Feature .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/2566 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: Fixes in quota remove

2012-03-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Fixes in quota remove .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/2584 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit

[Engine-patches] Change in ovirt-engine[master]: core: Fixes in quota remove

2012-03-05 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: core: Fixes in quota remove .. core: Fixes in quota remove The following has been changed in the patch: 1. Adding return false in can do action failures 2. get s

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup GetConfigurationValueQuery

2012-03-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup GetConfigurationValueQuery .. Patch Set 9: Verified; Looks good to me, but someone else must approve rebased, no changes since last +2 review --

[Engine-patches] Change in ovirt-engine[master]: core: new GetAllAuditLogsByVMNameQuery

2012-03-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: new GetAllAuditLogsByVMNameQuery .. Patch Set 7: Verified; Looks good to me, but someone else must approve rebased, no changes since last +1 review -- To

[Engine-patches] Change in ovirt-engine[master]: core: AuditLogDAO: get audit log by VM name

2012-03-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: AuditLogDAO: get audit log by VM name .. Patch Set 7: Verified; Looks good to me, but someone else must approve rebased, no changes since last +1 review

[Engine-patches] Change in ovirt-engine[master]: core: Clean up warnings from SearchQuery

2012-03-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Clean up warnings from SearchQuery .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/2396 To unsubscribe, visit http://gerrit.ovirt.org/s

[Engine-patches] Change in ovirt-engine[master]: core: Filtering for GetConfigurationValueQuery

2012-03-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Filtering for GetConfigurationValueQuery .. Patch Set 8: Verified -- To view, visit http://gerrit.ovirt.org/2395 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: core: User Configuration Values

2012-03-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: User Configuration Values .. Patch Set 8: Verified; Looks good to me, but someone else must approve rebased, no changes since last +1 review -- To view,

[Engine-patches] Change in ovirt-engine[master]: core: AuthType for configuration values

2012-03-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: AuthType for configuration values .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/2385 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup ConfigurationValues

2012-03-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup ConfigurationValues .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/2384 To unsubscribe, visit http://gerrit.ovirt.org/settings

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup GetConfigurationValueParameters

2012-03-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Cleanup GetConfigurationValueParameters .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/2383 To unsubscribe, visit http://gerrit.ovirt.

[Engine-patches] Change in ovirt-engine[master]: core: Filtering GetAllVmPoolsAttachedToUserQuery

2012-03-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Filtering GetAllVmPoolsAttachedToUserQuery .. Patch Set 9: Verified rebased, added test case for parameter class -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: core: GetUserVmsByUserIdAndGroupsQuery's super

2012-03-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: GetUserVmsByUserIdAndGroupsQuery's super .. Patch Set 9: Verified rebased, added test case for parameter class -- To view, visit http://gerrit.ovirt.org/

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 430 - Fixed!

2012-03-05 Thread Jenkins oVirt Server
ovirt_engine - Build # 430 - Fixed: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/430/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: core: GetUserVmsByUserIdAndGroupsQuery's super

2012-03-05 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: GetUserVmsByUserIdAndGroupsQuery's super .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2380 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: core: Base class for queries w/user ID parameter

2012-03-05 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Base class for queries w/user ID parameter .. -- To view, visit http://gerrit.ovirt.org/2379 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerri

[Engine-patches] Change in ovirt-engine[master]: core: Base class for queries w/user ID parameter

2012-03-05 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Base class for queries w/user ID parameter .. Patch Set 8: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2379 To unsubscribe, visit

[Engine-patches] [oVirt Jenkins] ovirt_engine - Build # 429 - Failure!

2012-03-05 Thread Jenkins oVirt Server
ovirt_engine - Build # 429 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine/429/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches

[Engine-patches] Change in ovirt-engine[master]: core: GetUserVmsByUserIdAndGroupsQuery's super

2012-03-05 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: GetUserVmsByUserIdAndGroupsQuery's super .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2380 To unsubscribe, visit ht

[Engine-patches] Change in ovirt-engine[master]: webadmin: ImageResourceColumn cleanup

2012-03-05 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: ImageResourceColumn cleanup .. webadmin: ImageResourceColumn cleanup 1. gwt-common's ImageResourceColumn now uses StyledImageResourceCell and GWT.c

[Engine-patches] Change in ovirt-engine[master]: engine: Fix automatic default quota name.

2012-03-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: engine: Fix automatic default quota name. .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2530 To unsubscribe, visi

[Engine-patches] Change in ovirt-engine[master]: engine: Fix automatic default quota name.

2012-03-05 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Fix automatic default quota name. .. engine: Fix automatic default quota name. Changed the quota name resolving which calculate the new default q

[Engine-patches] Change in ovirt-engine[master]: engine: Use default quota when update storage pool

2012-03-05 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: engine: Use default quota when update storage pool .. engine: Use default quota when update storage pool The following patch contains the following chang

[Engine-patches] Change in ovirt-engine[master]: engine: Use default quota when update storage pool

2012-03-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: engine: Use default quota when update storage pool .. Patch Set 4: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2529 To unsubscr

[Engine-patches] [oVirt Jenkins] ovirt_engine_unit_tests - Build # 286 - Failure!

2012-03-05 Thread Jenkins oVirt Server
ovirt_engine_unit_tests - Build # 286 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/286/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listi

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: implement support for collection based parameters

2012-03-05 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: sdk: implement support for collection based parameters .. sdk: implement support for collection based parameters Change-Id: I7cd85ada088034b8e8116f2

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: implement support for collection based parameters

2012-03-05 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: sdk: implement support for collection based parameters .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2582 To

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: rebase to latest api

2012-03-05 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: sdk: rebase to latest api .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2581 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: rebase to latest api

2012-03-05 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: sdk: rebase to latest api .. sdk: rebase to latest api - added support for parameters_set in parameter of RSDL to describe collection oriented par

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: implement support for collection based parameters

2012-03-05 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: sdk: implement support for collection based parameters .. sdk: implement support for collection based parameters Change-Id: I7cd85ada088034b8e8116f224f8d20c

[Engine-patches] Change in ovirt-engine-sdk[master]: sdk: rebase to latest api

2012-03-05 Thread mpastern
Michael Pasternak has uploaded a new change for review. Change subject: sdk: rebase to latest api .. sdk: rebase to latest api - added support for parameters_set in parameter of RSDL to describe collection oriented params Cha

[Engine-patches] Change in ovirt-engine[master]: engine: Fix automatic default quota name.

2012-03-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Fix automatic default quota name. .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2530 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: VmPoolHandler Adaptation

2012-03-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: VmPoolHandler Adaptation .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2577 To unsubscribe, visit http://gerrit.ovirt

[Engine-patches] Change in ovirt-engine[master]: core: Migrate snapshots data & start using table

2012-03-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Migrate snapshots data & start using table .. Patch Set 9: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2314 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: Base class for queries w/user ID parameter

2012-03-05 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Base class for queries w/user ID parameter .. Patch Set 6: Can you please add a unitest so we make sure this is not being broken? -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: Add quota reference to VM and template

2012-03-05 Thread mlipchuk
Maor Lipchuk has submitted this change and it was merged. Change subject: core: Add quota reference to VM and template .. core: Add quota reference to VM and template Adding support for quota id when mapping VM result set, for

[Engine-patches] Change in ovirt-engine[master]: core: Add quota reference to VM and template

2012-03-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add quota reference to VM and template .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2578 To unsubscribe, v

[Engine-patches] Change in ovirt-engine[master]: engine: Fix automatic default quota name.

2012-03-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: engine: Fix automatic default quota name. .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/2530 To unsubscribe, visit http://gerrit.ovirt.org/se

[Engine-patches] Change in ovirt-engine[master]: core: Base class for queries w/user ID parameter

2012-03-05 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Base class for queries w/user ID parameter .. Patch Set 6: Can you please add a unitest so we make sure this is not being broken? -- To view, visit http:/

[Engine-patches] Change in ovirt-engine[master]: core: Add quota reference to VM and template

2012-03-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Add quota reference to VM and template .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2578 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: core: Move disk/device deletion to RemoveImage

2012-03-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Move disk/device deletion to RemoveImage .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2565 To unsubscribe, visit htt

[Engine-patches] Change in ovirt-engine[master]: engine: Fix automatic default quota name.

2012-03-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: engine: Fix automatic default quota name. .. Patch Set 3: Changes from last patch: 1. Change code as Omer suggested 2. Adding Tests 3. In the quota helper method

[Engine-patches] Change in ovirt-engine[master]: core: No need to mark snapshot BROKEN

2012-03-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: No need to mark snapshot BROKEN .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2564 To unsubscribe, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: core: Restore missing image as ILLEGAL

2012-03-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Restore missing image as ILLEGAL .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2563 To unsubscribe, visit http://gerr

[Engine-patches] Change in ovirt-engine[master]: core: Cleanup GetConfigurationValueQuery

2012-03-05 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Cleanup GetConfigurationValueQuery .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2382 To unsubscribe, visit http://g

[Engine-patches] Change in ovirt-engine[master]: core: Filtering GetAllVmPoolsAttachedToUserQuery

2012-03-05 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: core: Filtering GetAllVmPoolsAttachedToUserQuery .. Patch Set 6: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2381 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: core: Migrate snapshots data & start using table

2012-03-05 Thread amureini
Allon Mureinik has posted comments on this change. Change subject: core: Migrate snapshots data & start using table .. Patch Set 9: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/2314

[Engine-patches] Change in ovirt-engine[master]: core: Migrate snapshots data & start using table

2012-03-05 Thread mkolesni
Mike Kolesnik has posted comments on this change. Change subject: core: Migrate snapshots data & start using table .. Patch Set 9: Fixed after amureini's review Also added logic to sync VM even if it has no configuration -- T

[Engine-patches] Change in ovirt-engine[master]: webadmin: adding dashboards to Report.xml

2012-03-05 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: webadmin: adding dashboards to Report.xml .. webadmin: adding dashboards to Report.xml no bz Adding dashboards to Report.xml in order not to have the downstream

[Engine-patches] Change in ovirt-engine[master]: core: Add quota reference to VM and template

2012-03-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Add quota reference to VM and template .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/2578 To unsubscribe, visit http://gerrit.ovirt.org

[Engine-patches] Change in ovirt-engine[master]: core: Add quota reference to VM and template

2012-03-05 Thread mlipchuk
Maor Lipchuk has uploaded a new change for review. Change subject: core: Add quota reference to VM and template .. core: Add quota reference to VM and template Adding support for quota id when mapping VM result set, for VM or fo

[Engine-patches] Change in ovirt-engine[master]: core: Clean up RemoveImageParameters

2012-03-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Clean up RemoveImageParameters .. Patch Set 1: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2562 To unsubscribe, visit http://gerrit

[Engine-patches] Change in ovirt-engine[master]: core: VmPoolHandler Adaptation

2012-03-05 Thread msalem
Muli Salem has uploaded a new change for review. Change subject: core: VmPoolHandler Adaptation .. core: VmPoolHandler Adaptation This patch changes the VmPoolHandler to properly clean the stateless images whether the Vm that is

[Engine-patches] Change in ovirt-engine[master]: gwt: Updated .gitignore file

2012-03-05 Thread asaf
Asaf Shakarchi has posted comments on this change. Change subject: gwt: Updated .gitignore file .. Patch Set 2: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2570 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: webadmin: Host config local storage CSS fix

2012-03-05 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: Host config local storage CSS fix .. webadmin: Host config local storage CSS fix Fixed a typo within UiBinder's declaration, which was causing a CSS

[Engine-patches] Change in ovirt-engine[master]: webadmin: ApplicationPlaces cleanup

2012-03-05 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: webadmin: ApplicationPlaces cleanup .. webadmin: ApplicationPlaces cleanup Removed unnecessary get*Place() methods. These methods were originally meant to be ca

[Engine-patches] Change in ovirt-engine[master]: core: add quota ref to sql StreamReader

2012-03-05 Thread gchaplik
Gilad Chaplik has abandoned this change. Change subject: core: add quota ref to sql StreamReader .. Patch Set 1: Abandoned will be taken care when adding quota ref to vm and template -- To view, visit http://gerrit.ovirt.org/2

[Engine-patches] Change in ovirt-engine[master]: core: Get import VM command to support snapshots

2012-03-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: core: Get import VM command to support snapshots .. Patch Set 7: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2425 To unsubscribe, visit h

[Engine-patches] Change in ovirt-engine[master]: core: add quota ref to sql StreamReader

2012-03-05 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: add quota ref to sql StreamReader .. -- To view, visit http://gerrit.ovirt.org/2567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Message

[Engine-patches] Change in ovirt-engine[master]: core: add quota ref to sql StreamReader

2012-03-05 Thread gchaplik
Gilad Chaplik has posted comments on this change. Change subject: core: add quota ref to sql StreamReader .. Patch Set 1: (1 inline comment) File backend/manager/modules/dal

[Engine-patches] Change in ovirt-engine[master]: gwt: Updated .gitignore file

2012-03-05 Thread asaf
Asaf Shakarchi has posted comments on this change. Change subject: gwt: Updated .gitignore file .. Patch Set 1: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2570 To unsubscribe, visit http://ge

[Engine-patches] Change in ovirt-engine[master]: engine: Use default quota when update storage pool

2012-03-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Use default quota when update storage pool .. Patch Set 2: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/2529 To unsubscribe, visit

[Engine-patches] Change in ovirt-engine[master]: engine: Fix automatic default quota name.

2012-03-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: engine: Fix automatic default quota name. .. Patch Set 2: (2 inline comments) File backend/manager/modules/b

[Engine-patches] Change in ovirt-engine[master]: core: add quota ref to sql StreamReader

2012-03-05 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: add quota ref to sql StreamReader .. Patch Set 1: (1 inline comment) File backend/manager/modules/dal/

[Engine-patches] Change in ovirt-engine[master]: core: add support for bridgeless network in SetupNetworks

2012-03-05 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: add support for bridgeless network in SetupNetworks .. Patch Set 7: Looks good to me, but someone else must approve (1 inline comment) .

[Engine-patches] Change in ovirt-engine[master]: core: add canDoActions on several Vm flows for VmNetworks

2012-03-05 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: add canDoActions on several Vm flows for VmNetworks .. Patch Set 7: (2 inline comments) File backend/ma

[Engine-patches] Change in ovirt-engine[master]: webadmin: formmating error messsage

2012-03-05 Thread alkaplan
Alona Kaplan has uploaded a new change for review. Change subject: webadmin: formmating error messsage .. webadmin: formmating error messsage no bz Orginizing error messages code Change-Id: Icca519266a05da5ba22f5e0e2b76a48818e

[Engine-patches] Change in ovirt-engine[master]: restapi: Support RSDL List-Parameters

2012-03-05 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: Support RSDL List-Parameters .. Patch Set 7: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1831 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: restapi: Support RSDL List-Parameters

2012-03-05 Thread mpastern
Michael Pasternak has submitted this change and it was merged. Change subject: restapi: Support RSDL List-Parameters .. restapi: Support RSDL List-Parameters Support the appropriate display of list parameters in RSDL. List para

[Engine-patches] Change in ovirt-engine[master]: restapi: Support RSDL List-Parameters

2012-03-05 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: Support RSDL List-Parameters .. Patch Set 6: Please rebase the change locally and upload again for review. -- To view, visit http://gerrit.ovirt.or

[Engine-patches] Change in ovirt-engine[master]: restapi: Support RSDL List-Parameters

2012-03-05 Thread mpastern
Michael Pasternak has posted comments on this change. Change subject: restapi: Support RSDL List-Parameters .. Patch Set 6: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1831 To unsubscribe, vis

[Engine-patches] Change in ovirt-engine[master]: restapi: Fix findbugs errors

2012-03-05 Thread ofrenkel
Omer Frenkel has posted comments on this change. Change subject: restapi: Fix findbugs errors .. Patch Set 2: (1 inline comment) File backend/manager/modules/restapi/types/s

[Engine-patches] Change in ovirt-engine[master]: core: adding service strategy for gluster integration

2012-03-05 Thread oourfali
Oved Ourfali has posted comments on this change. Change subject: core: adding service strategy for gluster integration .. Patch Set 8: You are absolutely right, and it is not a complex change. The only fear we have is of changi

  1   2   >