Moti Asayag has posted comments on this change.
Change subject: core: add canDoActions on several Vm flows for VmNetworks
......................................................................
Patch Set 7: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 786: StringBuffer networks = new StringBuffer();
why StringBuffer ? StringBuilder should be enough here.
Line 798: logable.AddCustomValue("Newtorks", networks.toString());
The audit log message refers also to Interfaces:
IMPORTEXPORT_IMPORT_VM_INTERFACES_ON_NON_VM_NETWORKS=Trying to import VM
${VmName} with the interface/s ${Interfaces} attached to non VM network/s
${Networks}.
How the interfaces value is going to be populated ?
--
To view, visit http://gerrit.ovirt.org/2476
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a73545acaff56b2fe277b651f87243ec0df48d4
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
