Omer Frenkel has posted comments on this change. Change subject: restapi: Fix findbugs errors ......................................................................
Patch Set 2: (1 inline comment) .................................................... File backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/utils/VersionUtils.java Line 13: return a.getMajor() != b.getMajor() ? a.getMajor() >= b.getMajor() : a.getMinor() >= b.getMinor(); this method is ok? -- To view, visit http://gerrit.ovirt.org/2547 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I268488cd84cbd9621db4475da5635329250514e7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Michael Pasternak <mpast...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: ol...@redhat.com _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches