Michael Kublin has posted comments on this change.
Change subject: core : Fixing ImportVmCommand scenario
..
Patch Set 1: (5 inline comments)
File
backend/manager/modules/bl
Mike Kolesnik has posted comments on this change.
Change subject: core: Change images_storage_domain_view to left join disks
..
Patch Set 6:
Just rebased
--
To view, visit http://gerrit.ovirt.org/2183
To unsubscribe, visit htt
Mike Kolesnik has posted comments on this change.
Change subject: core: Add method to get images with no disks
..
Patch Set 3:
Just rebased
--
To view, visit http://gerrit.ovirt.org/2311
To unsubscribe, visit http://gerrit.ovi
Mike Kolesnik has posted comments on this change.
Change subject: core: Fixes in SnapshotsManager
..
Patch Set 3:
Just rebased
--
To view, visit http://gerrit.ovirt.org/2312
To unsubscribe, visit http://gerrit.ovirt.org/settin
Mike Kolesnik has posted comments on this change.
Change subject: core: Cleanup RestoreAllSnapshotsCommand async task
..
Patch Set 3:
Just rebased
--
To view, visit http://gerrit.ovirt.org/2313
To unsubscribe, visit http://ger
Mike Kolesnik has posted comments on this change.
Change subject: core: Added can do action message for illegal restore
..
Patch Set 2:
Just rebased
--
To view, visit http://gerrit.ovirt.org/2336
To unsubscribe, visit http://g
Mike Kolesnik has posted comments on this change.
Change subject: [DO NOT SUBMIT] core: Migrate snapshots data & start using table
..
Patch Set 3:
Just rebased
--
To view, visit http://gerrit.ovirt.org/2314
To unsubscribe, vis
Mike Kolesnik has uploaded a new change for review.
Change subject: core: Delete stateless_vm_image_map
..
core: Delete stateless_vm_image_map
Now that stateless snapshot is an actual entity in DB and all work is
done with it, n
Oved Ourfali has posted comments on this change.
Change subject: core: Add methods missing from PGHack
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2347
To unsubscribe, visit ht
Douglas Schilling Landgraf has posted comments on this change.
Change subject: Makefile: Add /etc/engine into create_dirs target
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/2363
To unsubscribe, visit http
Douglas Schilling Landgraf has uploaded a new change for review.
Change subject: Makefile: Add /etc/engine into create_dirs target
..
Makefile: Add /etc/engine into create_dirs target
dbscripts/fill_config.sql uses /etc/engine,
Moti Asayag has posted comments on this change.
Change subject: core : Fixing ImportVmCommand scenario
..
Patch Set 1: (11 inline comments)
File
backend/manager/modules/bll/
ovirt_engine_dao_unit_tests - Build # 213 - Still Failing:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/213/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org
ovirt_engine_dao_unit_tests - Build # 212 - Still Failing:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/212/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org
ovirt_engine_dao_unit_tests - Build # 211 - Failure:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_dao_unit_tests/211/console to view
the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailm
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add validation for importVmCommand
..
engine: Add validation for importVmCommand
Adding validate quota method to import VM command.
For now we on
Omer Frenkel has posted comments on this change.
Change subject: engine: Add validation for importVmCommand
..
Patch Set 4: Verified; Looks good to me, approved
mazal tov!
--
To view, visit http://gerrit.ovirt.org/2335
To unsu
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add validation when remove quota
..
engine: Add validation when remove quota
Adding validation to checkl whether ther are VM's associated with qu
Omer Frenkel has posted comments on this change.
Change subject: engine: Add validation when remove quota
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2310
To unsubscribe, visit
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add support for adding empty quota
..
engine: Add support for adding empty quota
Adding support for adding new empty quota.
By removing validatio
Omer Frenkel has posted comments on this change.
Change subject: engine: Add support for adding empty quota
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2309
To unsubscribe, vis
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add query for permissions to consume qutoa
..
engine: Add query for permissions to consume qutoa
Adding query API to fetch all permissions to con
Omer Frenkel has posted comments on this change.
Change subject: engine: Add query for permissions to consume qutoa
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2308
To unsubscr
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add query to get disks by quota id
..
engine: Add query to get disks by quota id
Adding API to fetch disk images by quota id.
The query should co
Omer Frenkel has posted comments on this change.
Change subject: engine: Add query to get disks by quota id
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2307
To unsubscribe, vis
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add existing VM to FixturesTool
..
engine: Add existing VM to FixturesTool
Adding existing VM used in DiskImageDAOTest to fixtures tool
Change-I
Omer Frenkel has posted comments on this change.
Change subject: engine: Add existing VM to FixturesTool
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2306
To unsubscribe, visit
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add query get all templates by quota id
..
engine: Add query get all templates by quota id
Adding query to fetch all templates which are related
Omer Frenkel has posted comments on this change.
Change subject: engine: Add query get all templates by quota id
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2334
To unsubscribe
Omer Frenkel has posted comments on this change.
Change subject: engine: Add query get all vms by quota id
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2305
To unsubscribe, visi
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add query get all vms by quota id
..
engine: Add query get all vms by quota id
Adding query to fetch all vms which are related to quota id.
The q
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add quota queries
..
engine: Add quota queries
Adding quota queries:
getQuotaByStoragePoolIdQueryCommand - will return Quota by
storage pool id.
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota queries
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2141
To unsubscribe, visit http://gerrit
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Fix quota vds group stored procedure
..
engine: Fix quota vds group stored procedure
Fixed stored procedure of getting quota limitation by vds gr
Omer Frenkel has posted comments on this change.
Change subject: engine: Fix quota vds group stored procedure
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2114
To unsubscribe,
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Quota upgrade script
..
engine: Quota upgrade script
Add quota upgrade script.
The upgrade script includes creating defult unlimited quota for ea
Omer Frenkel has posted comments on this change.
Change subject: engine: Quota upgrade script
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2078
To unsubscribe, visit http://ger
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add consume quota permission to add Tempalte
..
engine: Add consume quota permission to add Tempalte
Adding permission to consume quota when addi
Omer Frenkel has posted comments on this change.
Change subject: engine: Add consume quota permission to add Tempalte
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2112
To unsub
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add consume quota permission to add VM
..
engine: Add consume quota permission to add VM
Adding permission to consume quota in to add VM command.
Omer Frenkel has posted comments on this change.
Change subject: engine: Add consume quota permission to add VM
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2111
To unsubscribe
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add permission support for Quota consume
..
engine: Add permission support for Quota consume
Adding quota consume action group for indicating val
Omer Frenkel has posted comments on this change.
Change subject: engine: Add permission support for Quota consume
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2108
To unsubscri
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Refactor permission subject
..
engine: Refactor permission subject
Adding new class for permission which encapsulate the permission
parameters su
Omer Frenkel has posted comments on this change.
Change subject: engine: Refactor permission subject
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2107
To unsubscribe, visit htt
Omer Frenkel has submitted this change and it was merged.
Change subject: engine:Add quota validation for crateAllSnapshot
..
engine:Add quota validation for crateAllSnapshot
In the current patch, I added support for validating
Moti Asayag has posted comments on this change.
Change subject: core: test for params serialization
..
Patch Set 1: (3 inline comments)
This is very important test and should be expanded to cover the serialized
parameter class
Omer Frenkel has posted comments on this change.
Change subject: engine:Add quota validation for crateAllSnapshot
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2105
To unsubscri
Omer Frenkel has posted comments on this change.
Change subject: engine:Add quota validation for RunVmCommand
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2103
To unsubscribe,
Omer Frenkel has submitted this change and it was merged.
Change subject: engine:Add quota validation for RunVmCommand
..
engine:Add quota validation for RunVmCommand
In the next patch, I added support for validating quota when
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add quota validation for Add Vm Tempalte
..
engine: Add quota validation for Add Vm Tempalte
In the next patch, I added support for validating qu
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota validation for Add Vm Tempalte
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2102
To unsubscri
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add quota validation for Add Disk to VM
..
engine: Add quota validation for Add Disk to VM
In the next patch, I added support for validating quot
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota validation for Add Disk to VM
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2101
To unsubscrib
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add quota validation for AddVmCommand
..
engine: Add quota validation for AddVmCommand
In the next patch, I added support when validating quota a
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota validation for AddVmCommand
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2098
To unsubscribe,
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add quota validation support commandBase
..
engine: Add quota validation support commandBase
In the next patch, I added support in command base f
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota validation support commandBase
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2097
To unsubscri
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add quota manager class
..
engine: Add quota manager class
In the next patch I introduced quota manager.
Quota manager responsibility is to encap
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota manager class
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2096
To unsubscribe, visit http://
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Adding fix to quota stored procedure
..
engine: Adding fix to quota stored procedure
In the next patch I changed the stored procedure to retrieve
Omer Frenkel has posted comments on this change.
Change subject: engine: Adding fix to quota stored procedure
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2095
To unsubscribe,
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add audit log messages to CRUD commands.
..
engine: Add audit log messages to CRUD commands.
Change-Id: Ic2c5aadf999f70b1509621a70970cf1df915d2fd
Omer Frenkel has posted comments on this change.
Change subject: engine: Add audit log messages to CRUD commands.
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2094
To unsubscri
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add audit log messages
..
engine: Add audit log messages
Adding audit log messages for events regarding quota,
mainly will be distinguish when DC
Omer Frenkel has posted comments on this change.
Change subject: engine: Add audit log messages
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2093
To unsubscribe, visit http://g
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add search support for quota.
..
engine: Add search support for quota.
Add implementation for search to the QuotaDAO.
Also add support to search
Omer Frenkel has posted comments on this change.
Change subject: engine: Add search support for quota.
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2091
To unsubscribe, visit h
Omer Frenkel has submitted this change and it was merged.
Change subject: frontend: Add business entities to sharedGWT
..
frontend: Add business entities to sharedGWT
Adding quota business entities to gwt xml,
also adding query
Omer Frenkel has posted comments on this change.
Change subject: frontend: Add business entities to sharedGWT
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2090
To unsubscribe,
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add quota id to vm static
..
engine: Add quota id to vm static
Add quota id mapping for vm static.
Change-Id: Ibfc65886bdbab3cf83da091bedeaef5c6
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota id to vm static
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2088
To unsubscribe, visit http:
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add quota id to disk image
..
engine: Add quota id to disk image
Add quota id support for the disk image DAO class and stored procedure
script.
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota id to disk image
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2087
To unsubscribe, visit http
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add quota id to VM parameters
..
engine: Add quota id to VM parameters
Adding quota id parameter to VdcActionParametersBase, so the client can
co
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota id to VM parameters
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2086
To unsubscribe, visit h
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Remove quota command
..
engine: Remove quota command
Adding remove quota command.
Responsible to remove quota from the system.
Change-Id: I23d91
Omer Frenkel has posted comments on this change.
Change subject: engine: Remove quota command
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2085
To unsubscribe, visit http://ger
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add/Edit quota commands
..
engine: Add/Edit quota commands
The following patch, adds commands for adding and updating quota entity.
Change-Id: I
Omer Frenkel has posted comments on this change.
Change subject: engine: Add/Edit quota commands
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2084
To unsubscribe, visit http://
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add validation for quota name
..
engine: Add validation for quota name
Setting the validation of quota name to be unique in all the setup,
and ad
Omer Frenkel has posted comments on this change.
Change subject: engine: Add validation for quota name
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2083
To unsubscribe, visit h
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add quota to audit log
..
engine: Add quota to audit log
Add quota as part of the audit log table. to support quota with search.
Change-Id: Id51
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota to audit log
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2081
To unsubscribe, visit http://g
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Create default unlimited quota for DC
..
engine: Create default unlimited quota for DC
In the next patch, I added a creation of new default unli
Omer Frenkel has posted comments on this change.
Change subject: engine: Create default unlimited quota for DC
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2079
To unsubscribe,
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add pre defined roles for consume quota
..
engine: Add pre defined roles for consume quota
Adding predefine role for consume quota.
The role shou
Omer Frenkel has posted comments on this change.
Change subject: engine: Add pre defined roles for consume quota
..
Patch Set 16: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2109
To unsubscrib
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add pre defined roles for consume quota
..
--
To view, visit http://gerrit.ovirt.org/2109
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-
Omer Frenkel has posted comments on this change.
Change subject: engine: Add pre defined roles for consume quota
..
Patch Set 15: (1 inline comment)
File backend/manager/dbsc
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota permission
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2077
To unsubscribe, visit http://ger
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add quota permission
..
engine: Add quota permission
The next patch handles permissions for Quota Commands, it handles the
following:
1. Adding n
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add Quota helper class
..
engine: Add Quota helper class
The quota helper class should provide helper procdures, which will be
used when using qu
Omer Frenkel has posted comments on this change.
Change subject: engine: Add Quota helper class
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2082
To unsubscribe, visit http://g
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add quota by storage pool Id query
..
engine: Add quota by storage pool Id query
Adding query of getting quota by storage pool id.
For GUI suppor
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota by storage pool Id query
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2092
To unsubscribe, vi
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add Quota canDoActionErrors
..
engine: Add Quota canDoActionErrors
Adding quota GUI messages which will be used when validating quota CRUD
comma
Omer Frenkel has posted comments on this change.
Change subject: engine: Add Quota canDoActionErrors
..
Patch Set 13: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2080
To unsubscribe, visit htt
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota enforcement type to storage pool
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2076
To unsubsc
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Add quota enforcement type to storage pool
..
engine: Add quota enforcement type to storage pool
Add quota_enforcement_type mapping to storage po
1 - 100 of 307 matches
Mail list logo
