Michael Kublin has posted comments on this change.
Change subject: core : Fixing ImportVmCommand scenario
......................................................................
Patch Set 1: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
Line 80: imageList = new
ArrayList<DiskImage>(getVm().getDiskMap().values());
Done
Line 93: boolean retVal =
ImportExportCommon.checkStoragePool(getStoragePool(), getReturnValue()
maybe
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveVmCommand.java
Line 242: for (DiskImage image : getVm().getDiskMap().values()) {
same, was there before and will stay
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java
Line 30:
For each result create a new class, when there are no need for these. Sorry
never will do these.
Line 30:
For each result create a new class, when there are no need for these. Sorry
never will do these.
--
To view, visit http://gerrit.ovirt.org/2351
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icc830aef5dfbd10b8061df08f0f353ec2e71a502
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
