Moti Asayag has posted comments on this change. Change subject: core: test for params serialization ......................................................................
Patch Set 1: (3 inline comments) This is very important test and should be expanded to cover the serialized parameter classes. .................................................... File backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/serialization/json/JsonObjectSerializationParamsTest.java Line 75: Date now = GregorianCalendar.getInstance().getTime(); why not just new Date() ? Line 88: Date now = GregorianCalendar.getInstance().getTime(); same here Line 95: @Test I'd add tests for each parameter class being serialized and deserialized, especially those with the MixIn interfaces. That way errors will pop-up as the problem introduced in code. -- To view, visit http://gerrit.ovirt.org/1173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3215f293f034fd43d03f21c912951e9f8ccb3dd3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Moti Asayag <masa...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
