[Engine-patches] [oVirt Jenkins] ovirt_server_gwt_profiles - Build # 180 - Still Failing!

2012-02-24 Thread Jenkins oVirt Server
ovirt_server_gwt_profiles - Build # 180 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_server_gwt_profiles/180/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mai

[Engine-patches] [oVirt Jenkins] ovirt_server_gwt_profiles - Build # 179 - Failure!

2012-02-24 Thread Jenkins oVirt Server
ovirt_server_gwt_profiles - Build # 179 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_server_gwt_profiles/179/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/l

[Engine-patches] [oVirt Jenkins] ovirt_engine_purge_maven_repo - Build # 48 - Failure!

2012-02-24 Thread Jenkins oVirt Server
ovirt_engine_purge_maven_repo - Build # 48 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_engine_purge_maven_repo/48/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mai

[Engine-patches] [oVirt Jenkins] ovirt_server_gwt_profiles - Build # 177 - Still Failing!

2012-02-24 Thread Jenkins oVirt Server
ovirt_server_gwt_profiles - Build # 177 - Still Failing: Check console output at http://jenkins.ovirt.org/job/ovirt_server_gwt_profiles/177/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mai

[Engine-patches] [oVirt Jenkins] ovirt_server_gwt_profiles - Build # 176 - Failure!

2012-02-24 Thread Jenkins oVirt Server
ovirt_server_gwt_profiles - Build # 176 - Failure: Check console output at http://jenkins.ovirt.org/job/ovirt_server_gwt_profiles/176/console to view the results. ___ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/l

[Engine-patches] Change in ovirt-engine[master]: Refactor UpdateStoragePoolCommand

2012-02-24 Thread smizrahi
Saggi Mizrahi has uploaded a new change for review. Change subject: Refactor UpdateStoragePoolCommand .. Refactor UpdateStoragePoolCommand I'm a measly python programmer. I can't follow your long invocation chains and complex co

[Engine-patches] Change in ovirt-engine[master]: engine-core: [autorecovery] database changes

2012-02-24 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine-core: [autorecovery] database changes .. Patch Set 6: (1 inline comment) Minor issue, besides that - looks good. ...

[Engine-patches] Change in ovirt-engine[master]: core: make network DAO extend the generic DAO

2012-02-24 Thread masayag
Moti Asayag has posted comments on this change. Change subject: core: make network DAO extend the generic DAO .. Patch Set 4: (1 inline comment) File backend/manager/modules

[Engine-patches] Change in ovirt-engine[master]: Refactor UpdateVdsGroupCommand

2012-02-24 Thread smizrahi
Saggi Mizrahi has posted comments on this change. Change subject: Refactor UpdateVdsGroupCommand .. Patch Set 1: (1 inline comment) File backend/manager/modules/bll/src/main

[Engine-patches] Change in ovirt-engine[master]: VdsInstaller: drop dead usevdcrepo code

2012-02-24 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: VdsInstaller: drop dead usevdcrepo code .. Patch Set 2: Verified; Looks good to me, approved Rebased patch. -- To view, visit http://gerrit.ovirt.org/1848 To un

[Engine-patches] Change in ovirt-engine[master]: VdsInstaller: drop dead usevdcrepo code

2012-02-24 Thread dfediuck
Doron Fediuck has submitted this change and it was merged. Change subject: VdsInstaller: drop dead usevdcrepo code .. VdsInstaller: drop dead usevdcrepo code Engine had "-u False" hard-coded, so vds_installer can drop this anti

[Engine-patches] Change in ovirt-engine[master]: VdsInstaller: drop netconsole code

2012-02-24 Thread dfediuck
Doron Fediuck has submitted this change and it was merged. Change subject: VdsInstaller: drop netconsole code .. VdsInstaller: drop netconsole code netconsole has been disentangled from host installation long ago. ovirt-engine

[Engine-patches] Change in ovirt-engine[master]: VdsInstaller: drop netconsole code

2012-02-24 Thread dfediuck
Doron Fediuck has posted comments on this change. Change subject: VdsInstaller: drop netconsole code .. Patch Set 4: Verified; Looks good to me, approved Renamed upgrade script and rebased. -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: Prestarted Vm (2)

2012-02-24 Thread msalem
Muli Salem has posted comments on this change. Change subject: core: Prestarted Vm (2) .. Patch Set 13: Rebase. -- To view, visit http://gerrit.ovirt.org/1798 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Mess

[Engine-patches] Change in ovirt-engine[master]: core: Prestarted Vm (6)

2012-02-24 Thread msalem
Muli Salem has posted comments on this change. Change subject: core: Prestarted Vm (6) .. Patch Set 2: Rebase. -- To view, visit http://gerrit.ovirt.org/2268 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-Messa

[Engine-patches] Change in ovirt-engine[master]: core: Prestarted Vm (5)

2012-02-24 Thread msalem
Muli Salem has posted comments on this change. Change subject: core: Prestarted Vm (5) .. Patch Set 1: (3 inline comments) Fixed according to Kublins comments File backend/

[Engine-patches] Change in ovirt-engine[master]: userportal: VM Permission sub-tab

2012-02-24 Thread vszocs
Vojtech Szocs has uploaded a new change for review. Change subject: userportal: VM Permission sub-tab .. userportal: VM Permission sub-tab - Reused PermissionListModelTable widget already used in Template Permission sub-tab Vi

[Engine-patches] Change in ovirt-engine[master]: core: Prestarted Vm (2)

2012-02-24 Thread msalem
Muli Salem has posted comments on this change. Change subject: core: Prestarted Vm (2) .. Patch Set 12: (2 inline comments) File backend/manager/modules/bll/src/main/java/or

[Engine-patches] Change in ovirt-engine[master]: engine-core: [autorecovery] Autorecovery logic

2012-02-24 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: engine-core: [autorecovery] Autorecovery logic .. Patch Set 7: (3 inline comments) File backend/manager/mo

[Engine-patches] Change in ovirt-engine[master]: core: Set default is plugged flag to true(ReviewOnly)

2012-02-24 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Set default is plugged flag to true(ReviewOnly) .. Patch Set 4: (1 inline comment) Commit Message Line

[Engine-patches] Change in ovirt-engine[master]: Refactor UpdateVdsGroupCommand

2012-02-24 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: Refactor UpdateVdsGroupCommand .. Patch Set 1: (2 inline comments) File backend/manager/modules/bll/src/main

[Engine-patches] Change in ovirt-engine[master]: core: Prestarted Vm (5)

2012-02-24 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core: Prestarted Vm (5) .. Patch Set 1: (3 inline comments) File backend/manager/modules/bll/src/main/java

[Engine-patches] Change in ovirt-engine[master]: userportal: cleanup of extended tab->template->subtabs

2012-02-24 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: cleanup of extended tab->template->subtabs .. userportal: cleanup of extended tab->template->subtabs Cleaned up the code after implementatio

[Engine-patches] Change in ovirt-engine[master]: userportal: cleanup of extended tab->template->subtabs

2012-02-24 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal: cleanup of extended tab->template->subtabs .. Patch Set 3: Verified; Looks good to me, approved Rebased and verified. -- To view, visit http://gerri

[Engine-patches] Change in ovirt-engine[master]: userportal: extended tab->templates->permissions

2012-02-24 Thread vszocs
Vojtech Szocs has submitted this change and it was merged. Change subject: userportal: extended tab->templates->permissions .. userportal: extended tab->templates->permissions Implementation of the Permissions subtab of the tem

[Engine-patches] Change in ovirt-engine[master]: userportal: extended tab->templates->permissions

2012-02-24 Thread vszocs
Vojtech Szocs has posted comments on this change. Change subject: userportal: extended tab->templates->permissions .. Patch Set 2: Verified; Looks good to me, approved Rebased and verified. -- To view, visit http://gerrit.ovir

[Engine-patches] Change in ovirt-engine[master]: core: Prestarted Vm (6)

2012-02-24 Thread mlipchuk
Maor Lipchuk has posted comments on this change. Change subject: core: Prestarted Vm (6) .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/2268 To unsubscribe, visit http:

[Engine-patches] Change in ovirt-engine[master]: engine: Get quota id parameter for import

2012-02-24 Thread mlipchuk
Maor Lipchuk has abandoned this change. Change subject: engine: Get quota id parameter for import .. Patch Set 8: Abandoned This patch should be abandoned, since the parameter of quota_id is already in one of the parent parame

[Engine-patches] Change in ovirt-engine[master]: core : Fixing brokem import scenarious

2012-02-24 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core : Fixing brokem import scenarious .. Patch Set 1: About 1 - I was asking, as I'm afraid we might have more situations like this, but I guess you're checki

[Engine-patches] Change in ovirt-engine[master]: core : Fixing brokem import scenarious

2012-02-24 Thread mkublin
Michael Kublin has posted comments on this change. Change subject: core : Fixing brokem import scenarious .. Patch Set 1: Answers: 1. I think, if we adding image to the db, we also should add the storage where image located, t

[Engine-patches] Change in ovirt-engine[master]: core: Add device id to specParams when creating VM from temp...

2012-02-24 Thread yzaslavs
Yair Zaslavsky has posted comments on this change. Change subject: core: Add device id to specParams when creating VM from tempalte and vice versa(ReviewOnly) .. Patch Set 4: Looks good to me, approved (1 inline comment) Just

[Engine-patches] Change in ovirt-engine[master]: engine: Get quota id parameter for import

2012-02-24 Thread masayag
Moti Asayag has posted comments on this change. Change subject: engine: Get quota id parameter for import .. Patch Set 8: (1 inline comment) File backend/manager/modules/com

[Engine-patches] Change in ovirt-engine[master]: VdsInstaller: drop netconsole code

2012-02-24 Thread masayag
Moti Asayag has posted comments on this change. Change subject: VdsInstaller: drop netconsole code .. Patch Set 3: The upgrade script should be renamed (03_01_0260_drop_netconsole.sql) so the sequence is maintained under backe

[Engine-patches] Change in ovirt-engine[master]: core: Fixing vds status when installed without boot.

2012-02-24 Thread dfediuck
Doron Fediuck has uploaded a new change for review. Change subject: core: Fixing vds status when installed without boot. .. core: Fixing vds status when installed without boot. This patch sets non-responsive status to a host whi