Yair Zaslavsky has posted comments on this change. Change subject: core: Add device id to specParams when creating VM from tempalte and vice versa(ReviewOnly) ......................................................................
Patch Set 4: Looks good to me, approved (1 inline comment) Just fix the minor comment, and that's it - I dont think that after that this patch needs another round of review. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java Line 169: this.specParams = VmDeviceCommonUtils.appendDeviceIdToSpecParams(this.getId().getDeviceId(), this.specParams); Please use formatter to format this line -- To view, visit http://gerrit.ovirt.org/1987 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia2481729b6e8d9a6205ce2ba509cb67fc9b2161f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
