Muli Salem has posted comments on this change.

Change subject: core: Prestarted Vm (2)
......................................................................


Patch Set 12: (2 inline comments)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmToPoolCommand.java
Line 70:         DbFacade.getInstance().getVmPoolDAO().addVmToPool(new 
vm_pool_map(getVmId(), getVmPoolId()));
I agree, but if Im since I am already here...

....................................................
File 
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAOHibernateImpl.java
Line 159:     }
Yes, I was wondering the same thing. I think it should be done separately 
though.

--
To view, visit http://gerrit.ovirt.org/1798
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3c0b0d69c0da82d3ba2dcbcf045cd92a6db7bef
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Muli Salem <msa...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to