Michael Kublin has posted comments on this change.
Change subject: core: Minor code cleanup for CommandBase
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1304
To unsubscribe, visit http://
ovirt_engine_unit_tests - Build # 141 - Failure:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/141/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listi
Yair Zaslavsky has uploaded a new change for review.
Change subject: common: DO NOT SUBMIT common introducing VmEntityType
..
common: DO NOT SUBMIT common introducing VmEntityType
This enum will help destinguish between entities
Muli Salem has posted comments on this change.
Change subject: engine-core: Uniting 2 Commands (Review Only)
..
Patch Set 9:
Rebase.
--
To view, visit http://gerrit.ovirt.org/1711
To unsubscribe, visit http://gerrit.ovirt.org/
Muli Salem has posted comments on this change.
Change subject: engine-core: Prestarted Vm (2 - Review Only)
..
Patch Set 4:
Changed the flow of AddVmToVmPool so the Vm images will not be pushed to any
table. This is the new fl
Muli Salem has posted comments on this change.
Change subject: engine-core: Prestarted Vm (3 - Review Only)
..
Patch Set 4:
Rebase.
--
To view, visit http://gerrit.ovirt.org/1799
To unsubscribe, visit http://gerrit.ovirt.org/s
Muli Salem has posted comments on this change.
Change subject: engine-core: Prestarted Vm (4 - Review Only)
..
Patch Set 4:
Rebase.
--
To view, visit http://gerrit.ovirt.org/1800
To unsubscribe, visit http://gerrit.ovirt.org/s
Roy Golan has posted comments on this change.
Change subject: engine : NullPointerException during score domain
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1186
To unsubscribe, visit htt
Muli Salem has posted comments on this change.
Change subject: engine-core: Prestarted Vm (5 - Review Only)
..
Patch Set 2:
Needs Review.
--
To view, visit http://gerrit.ovirt.org/1878
To unsubscribe, visit http://gerrit.ovirt
Muli Salem has posted comments on this change.
Change subject: engine-core: Prestarted Vm (6 - Review Only)
..
Patch Set 3:
Needs Review.
--
To view, visit http://gerrit.ovirt.org/1879
To unsubscribe, visit http://gerrit.ovirt
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager monitor async commands
..
Patch Set 5:
rebase
--
To view, visit http://gerrit.ovirt.org/1239
To unsubscribe, visit http://gerrit.ovirt.org/sett
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Adds Jobs clean up manager
..
Patch Set 3:
replaced DateUtils usage and extracted the manager initialization to a separate
method to be invoked
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager overload CreateTask with description
..
Patch Set 3:
rebase
--
To view, visit http://gerrit.ovirt.org/1302
To unsubscribe, visit http://gerrit.
Moti Asayag has posted comments on this change.
Change subject: core: Minor code cleanup for CommandBase
..
Patch Set 3:
removed CommandBase.getNow()
--
To view, visit http://gerrit.ovirt.org/1304
To unsubscribe, visit http://
Moti Asayag has posted comments on this change.
Change subject: core: Extend the fn_get_entity_name DB function
..
Patch Set 3:
rebase
--
To view, visit http://gerrit.ovirt.org/1305
To unsubscribe, visit http://gerrit.ovirt.or
Muli Salem has submitted this change and it was merged.
Change subject: core: Implement Serializable by ExternalSystem
..
core: Implement Serializable by ExternalSystem
The patch adds Serializable implementation ExternalSystem
Muli Salem has posted comments on this change.
Change subject: core: Implement Serializable by ExternalSystem
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1881
To unsubscribe, v
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: fixing disk device creation on vm import
..
Patch Set 2: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/
Moti Asayag has uploaded a new change for review.
Change subject: core: Implement Serializable by ExternalSystem
..
core: Implement Serializable by ExternalSystem
The patch adds Serializable implementation ExternalSystem and its
Eli Mesika has posted comments on this change.
Change subject: backend: Remove the time_lease_vm_pool_map in updating scripts.
..
Patch Set 1: I would prefer that you didn't submit this
Views should be updated ONLY is the sourc
Eli Mesika has posted comments on this change.
Change subject: core: Extend the fn_get_entity_name DB function
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1305
To unsubscribe,
Eli Mesika has posted comments on this change.
Change subject: engine: Quota upgrade script
..
Patch Set 3: (2 inline comments)
File backend/manager/dbscripts/upgrade/03_01_0
Eli Mesika has posted comments on this change.
Change subject: core: Views for handling query permissions
..
Patch Set 15: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1699
To unsubscribe, visi
Eli Mesika has posted comments on this change.
Change subject: engine: Add audit log messages
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/common/src/main
Eli Mesika has posted comments on this change.
Change subject: engine: Adding fix to quota stored procedure
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1748
To unsubscribe, vis
Eli Mesika has posted comments on this change.
Change subject: engine-core: fixing disk device creation on vm import
..
Patch Set 1:
please update your code as described in prev comment and submit a patch fix ,
thanks
--
To v
Moti Asayag has posted comments on this change.
Change subject: core: DiskImageDAODbFacadeImpl cleanup
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1840
To unsubscribe, visit http://gerri
Moti Asayag has posted comments on this change.
Change subject: core: Clean up warnings in VmNetworkInterfaceDAODbFacadeImpl
..
Patch Set 7: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1795
To
Moti Asayag has posted comments on this change.
Change subject: core: Rename runAsUser notion to filtered
..
Patch Set 8: (2 inline comments)
File
backend/manager/modules/co
Muli Salem has posted comments on this change.
Change subject: engine-core: Uniting 2 Commands (Review Only)
..
Patch Set 8:
No need to review - already has +2 (only rebase).
--
To view, visit http://gerrit.ovirt.org/1711
To u
Muli Salem has posted comments on this change.
Change subject: engine-core: Prestarted Vm (2 - Review Only)
..
Patch Set 3:
Still has whitespace - removed it in next patch from patch set:
http://gerrit.ovirt.org/#change,1799,p
Muli Salem has posted comments on this change.
Change subject: engine-core: Prestarted Vm (3 - Review Only)
..
Patch Set 3:
Just rebased.
--
To view, visit http://gerrit.ovirt.org/1799
To unsubscribe, visit http://gerrit.ovirt
Muli Salem has posted comments on this change.
Change subject: engine-core: Prestarted Vm (4 - Review Only)
..
Patch Set 3:
Changed the upgrade script from function to not function.
Changed from truncating the image_vm_pool_map
Muli Salem has posted comments on this change.
Change subject: engine-core: Prestarted Vm (5 - Review Only)
..
Patch Set 1:
Needs Review.
--
To view, visit http://gerrit.ovirt.org/1878
To unsubscribe, visit http://gerrit.ovirt
Muli Salem has posted comments on this change.
Change subject: engine-core: Prestarted Vm (6 - Review Only)
..
Patch Set 2:
Needs Review.
--
To view, visit http://gerrit.ovirt.org/1879
To unsubscribe, visit http://gerrit.ovirt
Muli Salem has uploaded a new change for review.
Change subject: engine-core: Prestarted Vm (6 - Review Only)
..
engine-core: Prestarted Vm (6 - Review Only)
This patch adds a periodic job that maintains the desired
number of Vm
Muli Salem has uploaded a new change for review.
Change subject: engine-core: Prestarted Vm (5 - Review Only)
..
engine-core: Prestarted Vm (5 - Review Only)
This patch adds the prestarted_vms field to the vm_pools class.
It upd
ovirt_engine_unit_tests - Build # 140 - Still Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/140/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailma
ovirt_engine_unit_tests - Build # 139 - Still Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/139/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailma
Danny Rankevich has uploaded a new change for review.
Change subject: webadmin: no refresh after removing a bookmark (#783922)
..
webadmin: no refresh after removing a bookmark (#783922)
https://bugzilla.redhat.com/show_bug.cgi?
Danny Rankevich has uploaded a new change for review.
Change subject: webadmin: setup networks UI
..
webadmin: setup networks UI
Change-Id: I2b79c1e02f38c2e2078a5ad19dcc7a4d7f2232ea
---
M
frontend/webadmin/modules/uicommonweb/s
Alona Kaplan has uploaded a new change for review.
Change subject: core: add HasStoragePool interface
..
core: add HasStoragePool interface
no bz
add HasStoragePool interface and implement it in VDS, VDSGroup and VM
(these clas
Allon Mureinik has posted comments on this change.
Change subject: core: Views for handling query permissions
..
Patch Set 12: (1 inline comment)
answered yzaslavas' question.
..
Eli Mesika has submitted this change and it was merged.
Change subject: core: fixing upgrade script numbering
..
core: fixing upgrade script numbering
Change-Id: I831b15f5ccf528ec3275d1ed17ccbc58e7ba8581
---
R
backend/manager/
Eli Mesika has posted comments on this change.
Change subject: core: fixing upgrade script numbering
..
Patch Set 3: Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/1871
To unsubscribe, visit http:/
Eli Mesika has posted comments on this change.
Change subject: core: fixing upgrade script numbering
..
Patch Set 3: Verified
rebase only
--
To view, visit http://gerrit.ovirt.org/1871
To unsubscribe, visit http://gerrit.ovirt
Eli Mesika has posted comments on this change.
Change subject: core: fixing upgrade script numbering
..
Patch Set 3:
rebase only
--
To view, visit http://gerrit.ovirt.org/1871
To unsubscribe, visit http://gerrit.ovirt.org/sett
ovirt_engine_unit_tests - Build # 138 - Still Unstable:
Check console output at
http://jenkins.ovirt.org/job/ovirt_engine_unit_tests/138/console to view the
results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailma
Allon Mureinik has uploaded a new change for review.
Change subject: core: Permissions for GetAllDisksByVmIdQuery
..
core: Permissions for GetAllDisksByVmIdQuery
Use the permission filtering API in GetAllDisksByVmIdQuery.
Also i
Muli Salem has submitted this change and it was merged.
Change subject: core: Fix NPE when creating VM from blank template
..
core: Fix NPE when creating VM from blank template
Blank template is created with fictive disk and on
Muli Salem has posted comments on this change.
Change subject: core: Fix NPE when creating VM from blank template
..
Patch Set 2: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1870
To unsubscrib
Eli Mesika has uploaded a new change for review.
Change subject: core: fixing upgrade script numbering
..
core: fixing upgrade script numbering
https://bugzilla.redhat.com/XX
Longer description using lines' length under 72
Muli Salem has posted comments on this change.
Change subject: core: Fix NPE when creating VM from blank template
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1870
To unsubscrib
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: bz786886, cancel-migrate: action is not supported
..
engine: bz786886, cancel-migrate: action is not supported
wrong error formating when trying
Omer Frenkel has posted comments on this change.
Change subject: engine: bz786886, cancel-migrate: action is not supported
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1868
To unsubscribe
Eli Mesika has uploaded a new change for review.
Change subject: core: Fix NPE when creating VM from blank template
..
core: Fix NPE when creating VM from blank template
Blank template is created with fictive disk and one monito
Shahar Havivi has posted comments on this change.
Change subject: engine: bz786886, cancel-migrate: action is not supported
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/1868
To unsubscribe, visit http://ge
Omer Frenkel has posted comments on this change.
Change subject: engine: bz786886, cancel-migrate: action is not supported
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1868
To unsubscribe
Alona Kaplan has uploaded a new change for review.
Change subject: core: storage_domains implements BusinessEntity
..
core: storage_domains implements BusinessEntity
no bz
The business entities have common procedures- getId and
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: Detail (sub-tab) support for side-tabs
..
userportal: Detail (sub-tab) support for side-tabs
This patch adds some general GWTP-related infra
Vojtech Szocs has posted comments on this change.
Change subject: userportal: Detail (sub-tab) support for side-tabs
..
Patch Set 2: Verified; Looks good to me, approved
Rebased and verified.
Added UpdateActionAvailability() c
Roy Golan has submitted this change and it was merged.
Change subject: rest-api: exposing setupnetworks action under
/api/hosts/{id}/nics
..
rest-api: exposing setupnetworks action under /api/hosts/{id}/nics
Exposing the "setu
Roy Golan has posted comments on this change.
Change subject: rest-api: exposing setupnetworks action under
/api/hosts/{id}/nics
..
Patch Set 4: Verified; Looks good to me, approved
rebase, already acked
--
To view, visit htt
Roy Golan has posted comments on this change.
Change subject: rest-api: exposing setupnetworks action under
/api/hosts/{id}/nics
..
Patch Set 3: Verified; Looks good to me, approved
already acked
--
To view, visit http://gerr
Shahar Havivi has posted comments on this change.
Change subject: engine: bz786886, cancel-migrate: action is not supported
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/1868
To unsubscribe, visit http://ge
Shahar Havivi has uploaded a new change for review.
Change subject: engine: bz786886, cancel-migrate: action is not supported
..
engine: bz786886, cancel-migrate: action is not supported
wrong error formating when trying to canc
Ronen Angluster has uploaded a new change for review.
Change subject: packaging: add controller class (plugins step 3/3) DO NOT REVIEW
..
packaging: add controller class (plugins step 3/3) DO NOT REVIEW
Change-Id: Idb95ecfb2e4a4
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: UiCommon model activation upon tab selection
..
userportal: UiCommon model activation upon tab selection
1. Added base presenter for UiCommo
Vojtech Szocs has posted comments on this change.
Change subject: userportal: UiCommon model activation upon tab selection
..
Patch Set 2: Verified; Looks good to me, approved
Rebased and verified.
--
To view, visit http://ger
Mike Kolesnik has posted comments on this change.
Change subject: core: DO NOT SUBMIT DAL: removing of DiskImageTemplate
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1568
To unsubscribe,
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Prevent browser from caching selector script (#784379)
..
webadmin: Prevent browser from caching selector script (#784379)
https://bugzilla.re
Vojtech Szocs has posted comments on this change.
Change subject: webadmin: Prevent browser from caching selector script (#784379)
..
Patch Set 2: Verified; Looks good to me, approved
Rebased and verified.
--
To view, visit ht
Mike Kolesnik has posted comments on this change.
Change subject: core: DO NOT SUBMIT Fixing DB conf (and conf test) files
..
Patch Set 5: (2 inline comments)
File backend/ma
Yair Zaslavsky has posted comments on this change.
Change subject: core: DO NOT SUBMIT common: Fixing entities to reflect removal
of DiskImageTemplate
..
Patch Set 5: (2 inline comments)
...
Yair Zaslavsky has posted comments on this change.
Change subject: core: DO NOT SUBMIT db scripts for removing disk image template
..
Patch Set 5: (3 inline comments)
File
b
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: Prevent browser from caching selector script (#784379)
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/1802
To unsubscribe, visit h
ovirt_engine - Build # 191 - Fixed:
Check console output at http://jenkins.ovirt.org/job/ovirt_engine/191/console
to view the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
Roy Golan has submitted this change and it was merged.
Change subject: engine-core: clean and fix typos
..
engine-core: clean and fix typos
Change-Id: I5d516b6b0cdba3232982be0253ad56de4e062c3e
---
M
backend/manager/modules/bll
Roy Golan has posted comments on this change.
Change subject: engine-core: clean and fix typos
..
Patch Set 19: Verified; Looks good to me, approved
already acked
--
To view, visit http://gerrit.ovirt.org/1062
To unsubscribe,
Roy Golan has submitted this change and it was merged.
Change subject: engine-core: setupNetworks api change
..
engine-core: setupNetworks api change
Introducing the new api of setupNetworks.
The new form to attach/detach multi
Roy Golan has posted comments on this change.
Change subject: engine-core: setupNetworks api change
..
Patch Set 16: Verified; Looks good to me, approved
already acked
--
To view, visit http://gerrit.ovirt.org/1061
To unsubscr
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager overload CreateTask with description
..
Patch Set 2: (1 inline comment)
File
backend/manag
Michael Pasternak has posted comments on this change.
Change subject: rest-api: exposing setupnetworks action under
/api/hosts/{id}/nics
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1853
Michael Kublin has posted comments on this change.
Change subject: engine-core: setupNetworks api change
..
Patch Set 15: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1061
To unsubscribe, visit http://ge
ol...@redhat.com has uploaded a new change for review.
Change subject: restapi: Restore Snapshot Deletes Return Point (#783954)
..
restapi: Restore Snapshot Deletes Return Point (#783954)
https://bugzilla.redhat.com/783954
Chan
Allon Mureinik has uploaded a new change for review.
Change subject: core: Extract base class for query tests
..
core: Extract base class for query tests
An abstract base class that handles common mocking situations for queries.
Alona Kaplan has uploaded a new change for review.
Change subject: core: VDS implements BusinessEntity
..
core: VDS implements BusinessEntity
no bz
The business entities have common procedures- getId and setId.
But as they don'
Daniel Erez has posted comments on this change.
Change subject: userportal: Detail (sub-tab) support for side-tabs
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1734
To unsubscri
Daniel Erez has posted comments on this change.
Change subject: userportal: UiCommon model activation upon tab selection
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1733
To uns
Michael Pasternak has posted comments on this change.
Change subject: cli: add copyright header to autocompletionhelper.py
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1858
To u
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: add copyright header to autocompletionhelper.py
..
cli: add copyright header to autocompletionhelper.py
Change-Id: Ie80d144e8d33d0cf39919d3010a
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: implement custom options for auto-completion
..
cli: implement custom options for auto-completion
Change-Id: Ic515693d9cef9efb40989219e02e1dcd2
Michael Pasternak has posted comments on this change.
Change subject: cli: implement custom options for auto-completion
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1857
To unsu
Michael Pasternak has uploaded a new change for review.
Change subject: cli: implement custom options for auto-completion
..
cli: implement custom options for auto-completion
Change-Id: Ic515693d9cef9efb40989219e02e1dcd2ca96324
Michael Pasternak has uploaded a new change for review.
Change subject: cli: add copyright header to autocompletionhelper.py
..
cli: add copyright header to autocompletionhelper.py
Change-Id: Ie80d144e8d33d0cf39919d3010a1f94a101
Moti Asayag has posted comments on this change.
Change subject: core: Minor code cleanup for CommandBase
..
Patch Set 2: (1 inline comment)
File
backend/manager/modules/bll/
ovirt_engine - Build # 190 - Still Failing:
Check console output at http://jenkins.ovirt.org/job/ovirt_engine/190/console
to view the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patche
Ofer Schreiber has posted comments on this change.
Change subject: dbscripts: fix adjustment for engine-db-install to support
systemd
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.o
Ofer Schreiber has submitted this change and it was merged.
Change subject: dbscripts: fix adjustment for engine-db-install to support
systemd
..
dbscripts: fix adjustment for engine-db-install to support systemd
Additional ch
ovirt_engine - Build # 189 - Still Failing:
Check console output at http://jenkins.ovirt.org/job/ovirt_engine/189/console
to view the results.
___
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patche
1 - 100 of 140 matches
Mail list logo
