Roy Golan has submitted this change and it was merged. Change subject: engine-core: setupNetworks api change ......................................................................
engine-core: setupNetworks api change Introducing the new api of setupNetworks. The new form to attach/detach multiple network/bond is REST style: Take a list of interfaces and changes on them are translated to 4 lists, networks, bonds, removedNetworks, removedBonds (what was the old api style) e.g: current list of interfaces: | name | networkName | bonded | bondName | ip ... | eth0 | ovirtmgmt | false | | ... | eth1 | | false | | ... | eth2 | otherNet | false | | ... to bond ovirtmgmt over eth0 and eth1 and detach "otherNet" send: | bond0| ovirtmgmt | | | | eth0 | ovirtmgmt | true | bond0 | | eth1 | ovirtmgmt | true | bond0 | | eth2 | | | ... | Change-Id: I6b6e2482876764c0a6384cffc02afaa980192317 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksParametersTest.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ValidationUtilsTest.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 7 files changed, 783 insertions(+), 119 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1061 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6b6e2482876764c0a6384cffc02afaa980192317 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
