Yair Zaslavsky has posted comments on this change. Change subject: core: DO NOT SUBMIT db scripts for removing disk image template ......................................................................
Patch Set 5: (3 inline comments) .................................................... File backend/manager/dbscripts/upgrade/03_01_0320_remove_image_templates_table.sql Line 1: --insert into images (image_guid,creation_date,size,description,boot,it_guid,internal_drive_mapping) select it_guid,creation_date,size,description,bootable,it_guid,internal_drive_mapping from image_templates imgtmpl where not exists I know. I will introduce a final version later on, I would like you to review my fixes first. Line 2: --(select image_guid from images where image_guid = imgtmpl.it_guid); Done Line 4: insert into images (image_guid,creation_date,size,description,boot,it_guid,internal_drive_mapping) select '00000000-0000-0000-0000-000000000000','2008/04/01 00:00:00',85899345920,'Blanc Image Template',false,'00000000-0000-0000-0000-000000000000',''; Done -- To view, visit http://gerrit.ovirt.org/1565 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If83885966ca8c187351623acbe502cb6ce218e2a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
