Moti Asayag has submitted this change and it was merged.
Change subject: core: Task Manager VDSM tasks monitoring - cont.
..
core: Task Manager VDSM tasks monitoring - cont.
The patch passes the execution context to internal co
Moti Asayag has submitted this change and it was merged.
Change subject: core: Task Manager Add StepId property to async_tasks entity
..
core: Task Manager Add StepId property to async_tasks entity
The patch adds the step ID pr
Michael Kublin has submitted this change and it was merged.
Change subject: core: Add ExecutionMessageDirector for job messages
..
core: Add ExecutionMessageDirector for job messages
The patch adds the ExecutionMessageDirector,
Moti Asayag has submitted this change and it was merged.
Change subject: core: Task Manager Support monitoring of VDSM tasks
..
core: Task Manager Support monitoring of VDSM tasks
The patch adds support for monitoring VDSM task
Moti Asayag has submitted this change and it was merged.
Change subject: core: Introduce CommandContext class
..
core: Introduce CommandContext class
The CommandContext class encapsulates the context of command execution,
both
Moti Asayag has submitted this change and it was merged.
Change subject: core: Modify commands invocation with compansation context
..
core: Modify commands invocation with compansation context
The patch modifies invocation of
Moti Asayag has submitted this change and it was merged.
Change subject: core: Task Manager Define Actions as Non-Monitored
..
core: Task Manager Define Actions as Non-Monitored
The patch extends the VdcActionType with new prop
Moti Asayag has submitted this change and it was merged.
Change subject: core: Task Manager Add Job Support to Multiple Action
..
core: Task Manager Add Job Support to Multiple Action
The patch adds support for the multiple act
Michael Kublin has submitted this change and it was merged.
Change subject: core: Task Manager Add Default Command Monitoring
..
core: Task Manager Add Default Command Monitoring
The patch implements the default monitoring of t
Moti Asayag has submitted this change and it was merged.
Change subject: core: Modify internal backend API to use CommandContext
..
core: Modify internal backend API to use CommandContext
The patch modifies the internal backend
Michael Kublin has posted comments on this change.
Change subject: core: Add ExecutionMessageDirector for job messages
..
Patch Set 5: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1303
To unsub
Michael Kublin has posted comments on this change.
Change subject: core: Task Manager Add Default Command Monitoring
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1089
To unsubs
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager VDSM tasks monitoring - cont.
..
Patch Set 8: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/1237
To uns
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: Prestarted Vm (4 - Review Only)
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/1800
To unsubscribe, visit http://gerrit.ovirt.o
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: Prestarted Vm (4 - Review Only)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1800
To u
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: Prestarted Vm (3 - Review Only)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1799
To u
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: Prestarted Vm (2 - Review Only)
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1798
To u
Eli Mesika has posted comments on this change.
Change subject: core: Task Manager Add StepId property to async_tasks entity
..
Patch Set 11: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1092
To
Muli Salem has posted comments on this change.
Change subject: engine-core: Prestarted Vm (2 - Review Only)
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/b
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Support monitoring of VDSM tasks
..
Patch Set 11: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/1094
To
Muli Salem has posted comments on this change.
Change subject: engine-core: Uniting 2 Commands (Review Only)
..
Patch Set 6: (2 inline comments)
File
backend/manager/modules
Moti Asayag has posted comments on this change.
Change subject: core: Modify internal backend API to use CommandContext
..
Patch Set 4: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/1709
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: Prestarted Vm (4 - Review Only)
..
Patch Set 1: (2 inline comments)
File backend/manager/dbscr
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: Prestarted Vm (3 - Review Only)
..
Patch Set 1: (3 inline comments)
File
backend/manager/modu
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: Uniting 2 Commands (Review Only)
..
Patch Set 6: (2 inline comments)
File
backend/manager/mod
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: Prestarted Vm (2 - Review Only)
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Please fix trailing whitespace
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add Job Support to Multiple Action
..
Patch Set 10: Verified; Looks good to me, approved
A separate patch will be sent to handle the comment abo
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Define Actions as Non-Monitored
..
Patch Set 10: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1091
To unsubscr
Moti Asayag has posted comments on this change.
Change subject: core: Modify commands invocation with compansation context
..
Patch Set 4: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/1
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add Default Command Monitoring
..
Patch Set 10:
The patch includes treatment for comments from patch-ste 7 about redundant
instantiation of the
Moti Asayag has posted comments on this change.
Change subject: core: Introduce CommandContext class
..
Patch Set 4: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1708
To unsubscribe, visit http
Moti Asayag has posted comments on this change.
Change subject: core: Add ExecutionMessageDirector for job messages
..
Patch Set 5:
This patch is part of a wider patch set. Please do not submit before submitting
the rest of th
Daniel Erez has posted comments on this change.
Change subject: userportal: Basic view -> details
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1752
To unsubscribe, visit http://
Daniel Erez has posted comments on this change.
Change subject: userportal: Basic view tile grid
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1751
To unsubscribe, visit http://g
Moti Asayag has posted comments on this change.
Change subject: core: Add ExecutionMessageDirector for job messages
..
Patch Set 4:
This patch is part of a wider patch set. Please do not submit before submitting
the rest of th
Moti Asayag has posted comments on this change.
Change subject: core: Refactor AuditLogDirector
..
Patch Set 4: Verified; Looks good to me, approved
rebase
--
To view, visit http://gerrit.ovirt.org/1301
To unsubscribe, visit h
Moti Asayag has submitted this change and it was merged.
Change subject: core: Refactor AuditLogDirector
..
core: Refactor AuditLogDirector
The patch refactors the resolveMessage method by extracting to method
the message resol
Moti Asayag has posted comments on this change.
Change subject: core: Refactor AuditLogDirector
..
Patch Set 3: Verified; Looks good to me, approved
rebased
--
To view, visit http://gerrit.ovirt.org/1301
To unsubscribe, visit
Eli Mesika has posted comments on this change.
Change subject: engine: Add audit log messages
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/dal/src/main/ja
Moti Asayag has posted comments on this change.
Change subject: core: Task Manager Add Default Command Monitoring
..
Patch Set 8:
rebased
--
To view, visit http://gerrit.ovirt.org/1089
To unsubscribe, visit http://gerrit.ovirt
Michael Pasternak has posted comments on this change.
Change subject: restapi: Remove Spring Framework (#NA)
..
Patch Set 1: (2 inline comments)
File backend/manager/modules/
Roy Golan has posted comments on this change.
Change subject: engine-core: clean and fix typos
..
Patch Set 16: Verified; Looks good to me, approved
rebase patch
--
To view, visit http://gerrit.ovirt.org/1062
To unsubscribe, v
Roy Golan has posted comments on this change.
Change subject: engine-core: add validations on VdsNetworkInterface
..
Patch Set 13: Verified
--
To view, visit http://gerrit.ovirt.org/1060
To unsubscribe, visit http://gerrit.ovir
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: add validations on VdsNetworkInterface
..
Patch Set 13: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1060
To unsubscribe, v
Roy Golan has posted comments on this change.
Change subject: engine-core: add validations on VdsNetworkInterface
..
Patch Set 12: (3 inline comments)
File
backend/manager/m
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota validation to commands
..
Patch Set 1: (3 inline comments)
File
backend/manager/modules/bl
Roy Golan has submitted this change and it was merged.
Change subject: packaging: fix engine-encryptutils.jar in Makefile
..
packaging: fix engine-encryptutils.jar in Makefile
Change-Id: I878617a469275e203fd62ad35de4926c0ad3c08
Roy Golan has posted comments on this change.
Change subject: packaging: fix engine-encryptutils.jar in Makefile
..
Patch Set 2: Looks good to me, approved
rebase patch
--
To view, visit http://gerrit.ovirt.org/1730
To unsubsc
Roy Golan has posted comments on this change.
Change subject: packaging: fix engine-encryptutils.jar in Makefile
..
Patch Set 2: Verified
rebase patch
--
To view, visit http://gerrit.ovirt.org/1730
To unsubscribe, visit http:/
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add quota manager
..
Patch Set 1: (5 inline comments)
File
backend/manager/modules/bll/src/main/java
Roy Golan has abandoned this change.
Change subject: packaging: fix engine-encryptutils.jar in Makefile
..
Patch Set 2: Abandoned
duplicate of 1730
--
To view, visit http://gerrit.ovirt.org/1385
To unsubscribe, visit http://ge
Yair Zaslavsky has posted comments on this change.
Change subject: core: VM implements BusinessEntity
..
Patch Set 2:
I see you uploaded patchset2 before my comments.
In general -
a. You introduced some new files - why? If this
Yair Zaslavsky has posted comments on this change.
Change subject: core: VM implements BusinessEntity
..
Patch Set 1: (4 inline comments)
Please explain the motivation for this patch, and address my comments.
.
Doron Fediuck has posted comments on this change.
Change subject: VdsInstaller: drop dead usevdcrepo code
..
Patch Set 1: Looks good to me, approved
Thanks for sending it, Dan.
Please ask someone to /verify/ it with older vdsm'
Ofer Schreiber has posted comments on this change.
Change subject: packaging: copy engine-encryptutils.jar
..
--
To view, visit http://gerrit.ovirt.org/1730
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Messag
Roy Golan has posted comments on this change.
Change subject: packaging: fix engine-encryptutils.jar in Makefile
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/1385
To unsubscribe, visit http://gerrit.ovirt.
Dan Kenigsberg has uploaded a new change for review.
Change subject: VdsInstaller: drop dead usevdcrepo code
..
VdsInstaller: drop dead usevdcrepo code
Engine had "-u False" hard-coded, so vds_installer can drop this
antiquated
Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: add validations on VdsNetworkInterface
..
Patch Set 12: (3 inline comments)
File
backend/mana
Alona Kaplan has uploaded a new change for review.
Change subject: core: VM implements BusinessEntity
..
core: VM implements BusinessEntity
no bz
Add to the VMs implemented interfaces BusinessEntity.
In VM- refactoring getvm_id
Roy Golan has posted comments on this change.
Change subject: engine-core: clean and fix typos
..
--
To view, visit http://gerrit.ovirt.org/1062
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comme
Roy Golan has posted comments on this change.
Change subject: engine-core: clean and fix typos
..
Patch Set 15: Verified; Looks good to me, approved
rebase patch
--
To view, visit http://gerrit.ovirt.org/1062
To unsubscribe, v
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota validation to commands
..
Patch Set 1: (3 inline comments)
File
backend/manager/modules/bl
Moti Asayag has posted comments on this change.
Change subject: core: Add ExecutionMessageDirector for job messages
..
Patch Set 3:
This patch is part of a wider patch set. Please do not submit before submitting
the rest of th
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota manager
..
Patch Set 1: (4 inline comments)
half reviewed
File
backend/manager/modules/bl
Michael Kublin has posted comments on this change.
Change subject: engine-core: poll vds while setupnetwork is running
..
Patch Set 13: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/880
To unsubscribe, vi
Michael Kublin has posted comments on this change.
Change subject: engine-core: Adding non-blocking VDSM api
..
Patch Set 5: Looks good to me, approved
resend patch with proper exception handler, but in general +2
--
To view,
Ofer Schreiber has posted comments on this change.
Change subject: dbscripts: fix adjustment for engine-db-install to support
systemd
..
Patch Set 1: Fails
(2 inline comments)
.
Mike Kolesnik has submitted this change and it was merged.
Change subject: core : Fixing typo
..
core : Fixing typo
Fixed typo in UpdateVmDiskCommand
Change-Id: Icfbd3375aa1dbb544a1f641e1ee25c0271d52a7f
---
M
backend/manager/
Mike Kolesnik has posted comments on this change.
Change subject: core : Fixing typo
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1846
To unsubscribe, visit http://gerrit.ovirt.
Michael Kublin has uploaded a new change for review.
Change subject: core : Fixing typo
..
core : Fixing typo
Fixed typo in UpdateVmDiskCommand
Change-Id: Icfbd3375aa1dbb544a1f641e1ee25c0271d52a7f
---
M
backend/manager/modules
Allon Mureinik has uploaded a new change for review.
Change subject: core: Add filtering to VmDeviceDAO
..
core: Add filtering to VmDeviceDAO
Added overloaded versions of required methods with filtering
parameters, and their tes
Ronen Angluster has uploaded a new change for review.
Change subject: dbscripts: fix adjustment for engine-db-install to support
systemd
..
dbscripts: fix adjustment for engine-db-install to support systemd
Additional changes w
Moti Asayag has posted comments on this change.
Change subject: engine-core: clean and fix typos
..
Patch Set 14: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1062
To unsubscribe, visit http://gerrit.ovi
Roy Golan has posted comments on this change.
Change subject: engine-core: clean and fix typos
..
Patch Set 14: (3 inline comments)
File backend/manager/modules/dal/src/main/
Omer Frenkel has posted comments on this change.
Change subject: engine: Adding fix to quota stored procedure
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/1748
To uns
Omer Frenkel has posted comments on this change.
Change subject: engine: Add audit log messages to CRUD commands.
..
Patch Set 1: (4 inline comments)
File
backend/manager/mo
Omer Frenkel has posted comments on this change.
Change subject: engine: Add audit log messages
..
Patch Set 1: (3 inline comments)
File
backend/manager/modules/dal/src/main
Omer Frenkel has posted comments on this change.
Change subject: Adding get Quota by storage pool Id
..
Patch Set 1: (1 inline comment)
File
backend/manager/modules/dal/src/
Omer Frenkel has posted comments on this change.
Change subject: engine: Add search support for quota.
..
Patch Set 2: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1721
To unsubscribe, visit http://gerri
Omer Frenkel has posted comments on this change.
Change subject: engine: Add quota to audit log
..
Patch Set 2: (2 inline comments)
File
backend/manager/modules/dal/src/main
Roy Golan has posted comments on this change.
Change subject: engine-core: poll vds while setupnetwork is running
..
Patch Set 12: (4 inline comments)
File
backend/manager/m
Moti Asayag has submitted this change and it was merged.
Change subject: core : Added audit log severities for hot plug/unplug audit log
messages
..
core : Added audit log severities for hot plug/unplug audit log messages
Adde
Moti Asayag has posted comments on this change.
Change subject: core : Added audit log severities for hot plug/unplug audit log
messages
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovir
Omer Frenkel has posted comments on this change.
Change subject: engine: Assign quota id for consumable commands
..
Patch Set 4:
IIUC, the use in getQuotaIdToConsume should change, so waiting to that change
--
To view, visit h
Roy Golan has posted comments on this change.
Change subject: engine-core: Adding non-blocking VDSM api
..
Patch Set 5: (1 inline comment)
File
backend/manager/modules/vdsbr
Omer Frenkel has posted comments on this change.
Change subject: engine: Add Quota helper class
..
Patch Set 4: (2 inline comments)
File
backend/manager/modules/bll/src/main
Michael Kublin has posted comments on this change.
Change subject: engine-core: Adding non-blocking VDSM api
..
Patch Set 5: (2 inline comments)
File
backend/manager/modules
Michael Kublin has posted comments on this change.
Change subject: engine-core: poll vds while setupnetwork is running
..
Patch Set 12: (2 inline comments)
File
backend/mana
Michael Kublin has uploaded a new change for review.
Change subject: core : Added audit log severities for hot plug/unplug audit log
messages
..
core : Added audit log severities for hot plug/unplug audit log messages
Added aud
Omer Frenkel has posted comments on this change.
Change subject: engine-core: poll vds while setupnetwork is running
..
Patch Set 12: (5 inline comments)
File
backend/manage
Daniel Erez has submitted this change and it was merged.
Change subject: core : Changed a way of handling unplugged disks during run vm
..
core : Changed a way of handling unplugged disks during run vm
1. Instead of query per d
Daniel Erez has posted comments on this change.
Change subject: core : Changed a way of handling unplugged disks during run vm
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1842
Moti Asayag has posted comments on this change.
Change subject: engine-core: clean and fix typos
..
Patch Set 14: (3 inline comments)
please remove TWS.
File backend/manager
Michael Kublin has uploaded a new change for review.
Change subject: core : Changed a way of handling unplugged disks during run vm
..
core : Changed a way of handling unplugged disks during run vm
1. Instead of query per disk t
Yair Zaslavsky has posted comments on this change.
Change subject: core: Views for handling query permissions
..
Patch Set 12: (1 inline comment)
File backend/manager/dbscrip
Asaf Shakarchi has posted comments on this change.
Change subject: webadmin: Prevent browser from caching selector script (#784379)
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1802
To un
Ofer Schreiber has posted comments on this change.
Change subject: packaging: copy engine-encryptutils.jar
..
Patch Set 1: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/1730
To unsubscribe, visi
Allon Mureinik has uploaded a new change for review.
Change subject: core: DiskImageDAODbFacadeImpl cleanup
..
core: DiskImageDAODbFacadeImpl cleanup
Remvoed unneeded @SuppressWarnings("unchecked") annotattions
from places that
Allon Mureinik has uploaded a new change for review.
Change subject: core: Added filtering option to DiskImageDAO
..
core: Added filtering option to DiskImageDAO
Overloaded DiskImageDAO.getAllForVM with filtering parameters
and
Maor Lipchuk has posted comments on this change.
Change subject: engine: Add Quota helper class
..
Patch Set 4: (1 inline comment)
File
backend/manager/modules/bll/src/main/
1 - 100 of 178 matches
Mail list logo
