Yair Zaslavsky has posted comments on this change.
Change subject: engine-core: add validations on VdsNetworkInterface
......................................................................
Patch Set 12: (3 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/SetupNetworksParameters.java
Line 21: @XmlElement(name = "Interfaces")
I know I did not review the original code - why do we need @XmlElement? please
remove.
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
Line 27:
Can this throw an exception? How will you handle such a case?
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/NetworkInterfaceValidator.java
Line 15: public class NetworkInterfaceValidator implements
ConstraintValidator<ValidNetworkConfiguration, VdsNetworkInterface> {
Just add a comment here (above the class ) of what do you intend to validate.
--
To view, visit http://gerrit.ovirt.org/1060
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie90a25bc30c948c444ea4823c9a2aba7628ba94d
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
