Omer Frenkel has posted comments on this change.
Change subject: engine-core: poll vds while setupnetwork is running
......................................................................
Patch Set 12: (5 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java
Line 180: : Config.<Integer>
GetValue(ConfigValues.vdsTimeout);
what is the difference between this timeout and the new configurable timeout
added in this patchset?
Line 187: log.debug("Setup networks command timed out for " +
timeout + " seconds");
why aren't you using log.debugFormat? instead of adding strings...
Line 235: log.debug("polling host " + getVdsName());
same here
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/PollVDSCommand.java
Line 18: httpTask = getBroker().poll();
no need to call ProceedProxyReturnValue() ?
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java
Line 95: httpTask = getBroker().setupNetworks(networks, bonds, options);
why did you remove the call to ProceedProxyReturnValue() ?
--
To view, visit http://gerrit.ovirt.org/880
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I340df50a5889cb57b9919079d196f3d950e5272d
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
