> Pass all previous test cases that failed due to MIPS non-support.
> The following are the test results on mips64el.
> # TOTAL: 271
> # PASS: 263
> # SKIP: 8
> # XFAIL: 0
> # FAIL: 0
> # XPASS: 0
> # ERROR: 0
That looks pretty good. What distro/gcc/glibc/kernel was this against?
Cheers,
Mark
ry to make
sure it won't be too long (max 3 months) till the next release.
Cheers,
Mark
> ---
> backends/Makefile.am| 6 +-
> backends/mips_init.c| 52
> backends/mips_reloc.def | 93
> backends/mips_symbol.c | 63 +
On Fri, 2023-11-03 at 12:56 +0100, Mark Wielaard wrote:
> Hi Yimg,
Sorry, typo, Ying.
> On Thu, 2023-11-02 at 14:55 +0800, Ying Huang wrote:
> > This is a series of modifications about MIPS.
> > Support src/readelf, strip, elflint, objdump related tools.
>
> Than
merge with the ref
'refs/heads/master' from the remote, but no such ref was
fetched.
Make sure to rename your branch to main and set the new upstream:
$ git branch -m master main
$ git branch --unset-upstream
$ git branch -u origin/main
Signed-off-by: Mark Wielaard
---
CONTRIBUTING
Set version to 0.190
Update NEWS and elfutils.spec.in
Regenerate po/*.po files.
Signed-off-by: Mark Wielaard
---
NEWS| 17 +-
config/elfutils.spec.in | 15 +-
configure.ac|2 +-
po/de.po| 1482 +++---
po
ohn Gallagher (1):
libdwfl: Fix memory leak in unzip()
Luke Diamand (1):
report_r_debug: handle `-z separate-code' and find more modules
Mark Wielaard (27):
Fix static build when zstd is enabled for libelf
configure.ac contains Bashisms
tests: skip '(null)' symname frame
Although most things are automated there are a couple of manual steps.
I thought I would write those down, so others can also create a
release.
- Pre-release, go over any pending patches or recently updated
bugs making sure there isn't anything urgent (or note those as
known issues in the rele
The elfutils.spec was missing the new eu-srcfiles program. Add a new
rpmbuild target to test a whole rpm build to catch such issues early.
* config/elfutils.spec.in: Add eu-srcfiles to files.
* Makefile.am (rpmbuild): New target.
Signed-off-by: Mark Wielaard
---
Makefile.am
unk.c (elf_getdata_rawchunk):
Call free on the rawchunk if new buffer was allocated.
Signed-off-by: Mark Wielaard
---
libelf/elf_getdata_rawchunk.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/libelf/elf_getdata_rawchunk.c b/libelf/elf_getdata_rawchunk.c
index 05ff329c..175
eful
please just submit those parts and we can integrate them early.
Thanks,
Mark
Hi elfutils hackers,
This sounds like a fun devroom. I will definitely go to Fosdem.
Please consider submitting a talk and/or coming next year, February to
Fosdem in Brussels.
Cheers,
Mark
--- Begin Message ---
Hi All,
We are excited to announce that the call for proposals is now open for
the
tps://sourceware.org/bugzilla/show_bug.cgi?id=31058
Signed-off-by: Mark Wielaard
---
backends/arm_machineflagname.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/backends/arm_machineflagname.c b/backends/arm_machineflagname.c
index e93092ae..d700d5f4 100644
--- a/backe
gt;
> Build state: failed test (failure)
> Revision: 373f5212677235fc3ca6068b887111554790f944
> Worker: bb1-2
> Build Reason: (unknown)
> Blamelist: Mark Wielaard
>
> Steps:
> [...]
> - 9: make rpmbuild ( failure )
> Logs:
> - stdio:
> https://b
* Makefile.am (rpmbuild): Use mkdir -p. Use $(shell pwd).
---
Makefile.am | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.am b/Makefile.am
index 87debb48..c9d59d4a 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -47,9 +47,9 @@ rpm: dist
rpmbuild -ts e
some of the if statements. Does that make the code too
complicated?
Also this only resolves the issue for the 64bit ELF case. Just above
this code is basically the same code for 32bit ELF. That code also
needs to be fixed.
Thanks,
Mark
form-indirect.sh \
> run-nvidia-extended-linemap-libdw.sh
> run-nvidia-extended-linemap-readelf.sh \
> run-readelf-dw-form-indirect.sh run-strip-largealign.sh \
> - run-readelf-Dd.sh
> + run-readelf-Dd.sh run-unstrip-noncontig.sh
>
> if !BIARCH
> export ELFUTILS_DISABLE_BIARCH = 1
> @@ -632,7 +632,8 @@ EXTRA_DIST = run-arextract.sh run-arsymtest.sh run-ar.sh \
>run-nvidia-extended-linemap-libdw.sh
> run-nvidia-extended-linemap-readelf.sh \
>testfile_nvidia_linemap.bz2 \
>testfile-largealign.o.bz2 run-strip-largealign.sh \
> - run-funcretval++11.sh
> + run-funcretval++11.sh \
> + run-unstrip-noncontig.sh testcore-noncontig.bz2
>
>
> if USE_VALGRIND
I really like to have a testcase, but only if we can find/construct
something much smaller.
Thanks,
Mark
Hi,
On Wed, 2023-11-08 at 13:59 +0100, Mark Wielaard wrote:
> If the rawchunk is not properly aligned we'll create a new buffer
> that is correctly aligned and put the data in that new buffer with
> memcpy or the conversion function. In such cases the rawchunk leaks
> because
Hi Paul,
On Tue, 2023-11-14 at 08:12 -0800, Paul Pluzhnikov wrote:
> On Tue, Nov 14, 2023 at 4:57 AM Mark Wielaard wrote:
>
> > Urgh, I had no idea NULL + ... was technically undefined behavior.
>
> ISO/IEC 9899:201x
> 6.5.6p8
>
> When an expression that has
Hi Paul,
On Tue, 2023-11-14 at 09:04 -0800, Paul Pluzhnikov wrote:
> On Tue, Nov 14, 2023 at 8:57 AM Mark Wielaard wrote:
> > Looks good. Applied.
>
> Thanks!
>
> Appreciate the speedy reviews.
Unfortunately our 32bit buildbots were also very quick to poin
Hi Paul,
On Tue, Nov 14, 2023 at 10:56:50AM -0800, Paul Pluzhnikov wrote:
> On Tue, Nov 14, 2023 at 9:55 AM Mark Wielaard wrote:
>
> > Unfortunately our 32bit buildbots were also very quick to point out an
> > issue: https://builder.sourceware.org/buildbot/#/changes/35202
&g
nse. Pushed.
Thanks,
Mark
PLv2 is
> > > compatible with GPLv2+.)
> >
> > But GPLv2-only is not compatible with GPLv3 which is used by e.g. gdb.
> > This is a bit of a pickle :{
>
> I interpret that as a veto. OK, will have to set time aside to
> rewrite this code.
Yeah it is somewhat unfortunate this code is GPLv2-only. But it also
doesn't really look like it was meant to be used as a generic library.
If it was maybe you can ask the copyright holders to use LGPLv2+ or
similar so it can be used with a (L)GPLv3+ code base?
Cheers,
Mark
00.0%
Average number of tests: successful lookup: -nan
unsuccessful lookup: 0.00
Only print out the Average number of tests when there were actual
tests to do.
Signed-off-by: Mark Wielaard
---
src/readelf.c | 7 ---
1 file changed, 4 insertions(+), 3
Hi,
On Thu, 2023-11-16 at 12:09 +, buil...@sourceware.org wrote:
> A new failure has been detected on builder elfutils-debian-testing-x86_64
> while building elfutils.
>
> Full details are available at:
> https://builder.sourceware.org/buildbot/#builders/145/builds/217
>
> Build state:
ned (dbg, datap);
> -
> - if (off >= data_size)
> - goto invalid_offset;
> }
>
> + if (off >= data_size)
> +goto invalid_offset;
> +
>return (const char *) data->d_buf + off;
> }
> INTDEF(dwarf_formstring)
Applied.
Thanks,
Mark
is GCed in dwfl_report_end it will close the elf handle
again.
Should we instead move the elf_end and reassignment of main.elf to
after this if statement?
Thanks,
Mark
check.
Cheers,
Mark
'scanned_files_total{source=".rpm archive"}'
instead of sending an kill -USR1.
Signed-off-by: Mark Wielaard
---
tests/run-debuginfod-response-headers.sh | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/tests/run-debuginfod-response-hea
Hi,
On Sun, Nov 19, 2023 at 03:11:28PM +0100, Mark Wielaard wrote:
> run-debuginfod-response-headers.sh does occassionally fail because
> it might scan an rpm more than once. Try to fix this by making sure
> all files that debuginfod is supposed to scan are ready before the
> server
Hi,
On Wed, 2023-11-15 at 17:41 +0100, Mark Wielaard wrote:
> If the symbol hash table only contains lenght zero chains, no lookup
> tests need to be done and eu-readelf -I would print out bogus numbers
> for the number of tests that were successful/unsuccessful.
>
> e.g. for an
50c7f71496149d064aa8b1441f786df88a@0x7f14e357e1d8
> +0x7f14e3794000 7615604eaf4a068dfae5085444d15c0dee93dfbd@0x7f14e37941d8
> +0x7f14e3a96000 09cfb171310110bc7ea9f4476c9fa044d85baff4@0x7f14e3a96210
> +0x7f14e3d9e000 e10cc8f2b932fc3daeda22f8dac5ebb969524e5b@0x7f14e3d9e248
> +0x7f14e3fba000 fc4fa58e47a5acc137eadb7689bce4357c557a96@0x7f14e3fba280
> +0x7f14e4388000 7f2e9cb0769d7e57bd669b485a74b537b63a57c4@0x7f14e43881d8
> +0x7f14e458c000 62c449974331341bb08dcce3859560a22af1e172@0x7f14e458c1d8
> +0x7f14e4795000 175efdcef445455872a86a6fbee7567ca16a513e@0x7f14e4795248
> +0x7ffcfe59f000 80d79b32785868a2dc10047b39a80d1daec8923d@0x7ffcfe59f328
> +EOF
> +
> +exit 0
Nice collection of tests.
> diff --git a/tests/testcore-noncontig.bz2 b/tests/testcore-noncontig.bz2
> new file mode 100644
> index
> ..514ad010e00499b9a75a98800aa20ec61596d491
> GIT binary patch
OK.
All looks good. Maybe add the suggested comment about looking at the
program headers to undestand the testscase and please restore the
original commit message before applying.
Thanks,
Mark
new Elf object in
> the already existing Dwfl_Module.
>
> * libdwfl/dwfl_report_elf.c (__libdwfl_report_elf): Replace Elf in
> the Dwfl_Module in case of duplicate modules to prolong its
> lifetime for subsequent processing.
Thanks, pushed.
Mark
fline-memory.sh: Test new
> test-ar-duplicates.a.bz2.
> * tests/Makefile.am (EXTRA_DIST): Add test-ar-duplicates.a.bz2.
Thanks. Also tested it fails before your fix.
Pushed,
Mark
hanks, this makes sense. If the decompressed size isn't what was
encoded in the Chdr then we could reduce the size of the d_buf/d_size,
but that probably is not what the user expects. Flagging it as
bad/inconsistent data makes sense. Especially since we do the same for
zlib compressed data.
Pushed,
Mark
Sourceware infrastructure community updates for Q4 2023
- 6 months with the Software Freedom Conservancy
- Sourceware @ Fosdem
- OSUOSL provides extra larger arm64 and x86_64 buildbot servers
- No more From rewriting for patches mailinglists
= 6 months with the Software Freedom Conservancy
Sourc
By redirecting all output to /dev/null in run-native-test.sh the
run-native-test.sh.log file will be empty on failures. This makes
it hard to figure out what went wrong.
* tests/run-native-test.sh: Remove /dev/null redirects.
Signed-off-by: Mark Wielaard
---
tests/run-native-test.sh
t isn't. So that all the
code can just keep using basename (we just have to make sure libeu.h is
included)?
Cheers,
Mark
Hi Khem,
On Tue, 2023-12-12 at 09:16 -0800, Khem Raj wrote:
> On Tue, Dec 12, 2023 at 5:18 AM Mark Wielaard wrote:
> > On Sun, 2023-12-10 at 12:20 -0800, Khem Raj wrote:
> > > musl does not provide GNU version of basename and lately have removed
> > > the defini
On Wed, Dec 13, 2023 at 08:29:01AM -0800, Khem Raj wrote:
> On Wed, Dec 13, 2023 at 7:10 AM Mark Wielaard wrote:
> >
> > Hi Khem,
> >
> > On Tue, 2023-12-12 at 09:16 -0800, Khem Raj wrote:
> > > On Tue, Dec 12, 2023 at 5:18 AM Mark Wielaard wrote:
> > &
k
that is acceptable.
I don't like the const cast away in ar.c, but that seems necessary
because we are using search.h and that interface just takes non-cast
char pointers (even though they really are const).
What do you think of the attached variant of your patch?
Thanks,
Mark
From 3dfbc
whether or not it works as intended that would be really
appreciated.
Cheers,
Mark
On Tue, 2023-12-12 at 10:49 +0100, Mark Wielaard wrote:
> By redirecting all output to /dev/null in run-native-test.sh the
> run-native-test.sh.log file will be empty on failures. This makes
> it hard to figure out what went wrong.
>
> * tests/run-native-test.sh: Remove /dev
sts/varlocs.c: Likewise.
* debuginfod/debuginfod.cxx: Move include system.h to the end.
(register_file_name): Rename basename to filename.
Signed-off-by: Khem Raj
Signed-off-by: Mark Wielaard
BTW. There is a musl tracking bug:
https://sourceware.org/bugzilla/show_bug.
^~~~
> elfstrmerge.c:450:32: note: earlier argument should specify number of
> elements, later size of each element
>
Thanks, looks good. Pushed.
Cheers,
Mark
Hi Aaron,
On Wed, Dec 06, 2023 at 08:35:03PM -0500, Aaron Merey wrote:
> Add INTDECL for dwarf_get_units and call dwarf_get_units with INTUSE.
This is obviously OK. Although it is a bit of a micro-optimization.
Thanks,
Mark
om doing this, and take responsibility of how the
sections are layed out yourself you have to call:
elf_flagelf (elf, ELF_C_SET, ELF_F_LAYOUT);
Before calling elf_update. Note that in that case you are responsible
for setting/updating the sh_offset fields of the Shdrs yourself.
See for example the elfutils src/elfcompress.c program to see what it
does in case the Elf file has program headers.
Hope that helps,
Mark
get_units and
possibly dwarf_cu_info. In general you shouldn't mix them.
Hope this helps and let me know if you need more info.
Cheers,
Mark
ste 496 bytes on the stack at the front of the buffer that
is never used.
* libdwfl/image-header.c (__libdw_image_header): Add H_START
to header_buffer size and return
Signed-off-by: Mark Wielaard
---
libdwfl/image-header.c | 8
1 file changed, 4 insertions(+), 4 deleti
Hi,
On Sun, 2024-01-21 at 20:54 +0100, Mark Wielaard wrote:
> GCC 14 notices we play some tricks with the array into which we try
> to read the kernel image header.
>
> image-header.c: In function ‘__libdw_image_header’:
> image-header.c:77:18: error: array subscript -496 is outsi
Call
__libelf_read_mmaped_file with ELF_C_READ_MMAP.
* tests/elfgetzdata.c (main): Add new "mem" option.
* tests/run-elfgetzdata.sh: Also run all tests with new
"mem" option.
https://sourceware.org/bugzilla/show_bug.cgi?id=31225
Reported-by: Derek Bruening
Sig
-coverage
and provides fresh coverage reports again at
https://snapshots.sourceware.org/elfutils/coverage/latest/
* Makefile.am (BUILD_STATIC): Provide libdebuginfod.a
Signed-off-by: Mark Wielaard
---
src/Makefile.am | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff
// This is a common symptom for dwz-compressed debug files,
> > - // where the altdebug file cannot be resolved.
> >if (verbose > 3)
> > obatched(clog) << "skipping cu=" << cuname << " due to empty
>
{
> + /* Print the names of symbols referred to by relocations. */
> + if (shdr->sh_type == SHT_REL)
> + {
> + size_t sh_entsize = gelf_fsize (elf, ELF_T_REL, 1, EV_CURRENT);
> + print_reloc_symnames (elf, scn, shdr, sh_entsize);
> + }
> + else if (shdr->sh_type == SHT_RELA)
> + {
> + size_t sh_entsize = gelf_fsize (elf, ELF_T_RELA, 1, EV_CURRENT);
> + print_reloc_symnames (elf, scn, shdr, sh_entsize);
> + }
> + }
> +}
> +}
It is just a testcase, but cleaning up would be nice.
elf_end(elf);
close (fd);
(See also below for runtest support)
> diff --git a/tests/run-unstrip-test.sh b/tests/run-unstrip-test.sh
> index dc7d3a42..03373b3f 100755
> --- a/tests/run-unstrip-test.sh
> +++ b/tests/run-unstrip-test.sh
> @@ -33,6 +33,14 @@ testrun ${abs_top_builddir}/src/unstrip -o
> testfile.unstrip $stripped $debugfile
>
> testrun ${abs_top_builddir}/src/elfcmp --hash-inexact $original
> testfile.unstrip
>
> +tempfiles syms-orig syms-testfile
> +
> +# Check whether relocated symbols changed.
> +${abs_top_builddir}/tests/elf-print-reloc-syms $original > syms-orig
> +${abs_top_builddir}/tests/elf-print-reloc-syms testfile.unstrip >
> syms-testfile
>
These really should run under "testrun" so they will use the just build
libelf (and run under valgrind with --enable-valgrind, which would have
caught that the testcase doesn't clean up all resources it allocates).
> +testrun diff syms-orig syms-testfile
> +
> # Also test modifying the file in place.
>
> rm -f testfile.inplace
Looks good in general. Just clean up in the new testcase and run it
with testrun.
Thanks,
Mark
Hi Ying,
Sorry I keep postponing this. I don't have access to a mips64le box,
the cfarm only has 64bit big endian mips machines. But the part I am
struggling with is the relocation data conversion needed in the
mips64le case.
On Fri, Nov 03, 2023 at 01:18:12PM +0100, Mark Wielaard wrote:
tfile-largealign.o.bz2 run-strip-largealign.sh \
>run-funcretval++11.sh \
>test-ar-duplicates.a.bz2 \
> - run-dwfl-core-noncontig.sh testcore-noncontig.bz2
> + run-dwfl-core-noncontig.sh testcore-noncontig.bz2 \
> + testfile-dwarf5-line-
Hi Aaron,
On Mon, Feb 12, 2024 at 01:16:30PM -0500, Aaron Merey wrote:
> On Mon, Feb 12, 2024 at 12:31 PM Mark Wielaard wrote:
> > >(void) INTUSE(dwarf_getsrclines) (&CUDIE (cu), &lines, &nlines);
> > > - assert (cu->lines != NULL);
> > &g
ild on dwarf_getaranges,
but could maybe use a new interface?
> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=22288#c5
So this comment says that "parsing CUs lightly (just enough to get
their CU ranges) should be fairly cheap", but it seems that isn't
really true. Or at least parsing .debug_aranges is a lot (2.5 times)
faster (measured in seconds).
It would be good to better understand why this is.
Cheers,
Mark
Hi Omar,
On Wed, 2023-12-06 at 01:22 -0800, Omar Sandoval wrote:
> The .debug_cu_index and .debug_tu_index sections in DWARF package files
> are basically hash tables mapping a unit's 8 byte signature to an offset
> and size in each section used by that unit [1]. Add support for parsing
> and doi
__libdw_find_split_unit (Dwarf_CU *cu)
> @@ -98,14 +159,18 @@ __libdw_find_split_unit (Dwarf_CU *cu)
> same id as the skeleton. */
>if (cu->unit_type == DW_UT_skeleton)
> {
> + /* First, try the dwp file. */
> + try_dwp_file (cu);
> +
>Dwarf_Die cudie = CUDIE (cu);
>Dwarf_Attribute dwo_name;
> - /* It is fine if dwo_dir doesn't exists, but then dwo_name needs
> - to be an absolute path. */
> - if (dwarf_attr (&cudie, DW_AT_dwo_name, &dwo_name) != NULL
> - || dwarf_attr (&cudie, DW_AT_GNU_dwo_name, &dwo_name) != NULL)
> + /* Try a dwo file. It is fine if dwo_dir doesn't exist, but then
> + dwo_name needs to be an absolute path. */
> + if (cu->split == (Dwarf_CU *) -1
> + && (dwarf_attr (&cudie, DW_AT_dwo_name, &dwo_name) != NULL
> + || dwarf_attr (&cudie, DW_AT_GNU_dwo_name, &dwo_name) != NULL))
> {
> - /* First try the dwo file name in the same directory
> + /* Try the dwo file name in the same directory
>as we found the skeleton file. */
> const char *dwo_file = dwarf_formstring (&dwo_name);
> const char *debugdir = cu->dbg->debugdir;
Nicely integrated.
Pushed,
Mark
ZE to zero. It also makes sure the documentation is < 76 chars
wide.
* libdw/libdw.h (dwarf_cu_dwp_section_info): Update docs.
Signed-off-by: Mark Wielaard
---
libdw/libdw.h | 42 +++---
1 file changed, 23 insertions(+), 19 deletions(-)
diff
hack similar to ranges in __libdw_formptr?).
We might want to add a test for run-next-lines.sh and run-next-
files.sh?
Thanks,
Mark
Hi Aaron,
We already discussed on irc, but just for the record.
On Mon, Feb 19, 2024 at 11:20:13PM -0500, Aaron Merey wrote:
> On Tue, Feb 13, 2024 at 8:28 AM Mark Wielaard wrote:
> >
> > > This patch's method of building the aranges list is slower than simply
> >
.
* libebl/eblobjnote.c (ebl_object_note): Set addr_size to one
ELF_T_ADDR. Check descsz equals two times addr_size.
Signed-off-by: Mark Wielaard
---
libebl/eblobjnote.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libebl/eblobjnote.c b/libebl/eblobjnote.c
d cnt, cnt2.
(handle_verdef): Likewise.
Signed-off-by: Mark Wielaard
---
src/readelf.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/readelf.c b/src/readelf.c
index 802f8ede..0e931184 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -3159,7 +3
Hi Omar,
On Thu, Feb 22, 2024 at 09:54:29AM -0800, Omar Sandoval wrote:
> On Fri, Feb 16, 2024 at 02:34:18PM +0100, Mark Wielaard wrote:
> > Update the documentation of dwarf_cu_dwp_section_info to make clear
> > that the function only returns an error if the DWARF package file da
d GCC 14 (trunk).
>
> Xi Ruoyao (2):
> libelf: Sync elf.h from glibc
> backends: Update list of LoongArch relocations
Thanks, looks good.
Both patches pushed.
Cheers,
Mark
Hi Omar,
On Thu, Feb 22, 2024 at 04:53:19PM -0800, Omar Sandoval wrote:
> On Fri, Feb 16, 2024 at 04:00:47PM +0100, Mark Wielaard wrote:
> > The code and tests look good. run-varlocs.sh seems good, which seems to
> > confirm DW_SECT_LOCLISTS is handled correctly (but why doesn&
Hi Omar,
On Thu, Feb 22, 2024 at 05:03:44PM -0800, Omar Sandoval wrote:
> On Thu, Feb 22, 2024 at 04:53:19PM -0800, Omar Sandoval wrote:
> > On Fri, Feb 16, 2024 at 04:00:47PM +0100, Mark Wielaard wrote:
> > > Don't we also need to handle DW_SECT_LINE i
Sourceware infrastructure community updates for Q1 2024
A summary of news about Sourceware, the Free Software hosting project
for core toolchain and developer tools, from the last 3 months.
- Sourceware now has an official donation page
- StarFive VisionFive-2 RISC-V boards for builder.sourceware
t;if (arange->cu == NULL)
> {
> - const Dwarf_Arange *dwarange = &mod->dw->aranges->info[arange->arange];
> + const Dwarf_Arange *dwarange =
> &mod->dw->dieranges->info[arange->arange];
>Dwfl_Error result = intern_cu (mod, dwarange->offset, &arange->cu);
>if (result != DWFL_E_NOERROR)
> return result;
OK. It is a little scary how directly this code uses the libdw
internals, but the changes look just fine.
> diff --git a/tests/run-getsrc-die.sh b/tests/run-getsrc-die.sh
> index 4da16e7a..3418b33a 100755
> --- a/tests/run-getsrc-die.sh
> +++ b/tests/run-getsrc-die.sh
> @@ -23,6 +23,11 @@
> # dwarf_getsrc_die
> testfiles testfile testfile-inlines testfile-lex-inlines
>
> +# The following tests should pass without .debug_aranges present.
> +objcopy --remove-section .debug_aranges testfile
> +objcopy --remove-section .debug_aranges testfile-inlines
> +objcopy --remove-section .debug_aranges testfile-lex-inlines
> +
> testrun_compare ${abs_top_builddir}/tests/getsrc_die testfile 0x08048468
> 0x0804845c <<\EOF
> /home/drepper/gnu/new-bu/build/ttt/f.c:3
> /home/drepper/gnu/new-bu/build/ttt/b.c:4
It might be an idea to run the tests twice, once with and once without
.debug_aranges present. Shouldn't really matter now, but could in the
future when things might get refactored (of course you can say, someone
who does that, should then adjust the testcases).
Cheers,
Mark
Hi,
On Wed, 2024-02-21 at 21:59 +0100, Mark Wielaard wrote:
> Annobin address ranges were always printed as if they were 64bit wide
> because addr_size was set to twice the size. This was done because the
> note description size should contain two addresses. Fix this by setting
> the
On Wed, 2024-02-21 at 22:19 +0100, Mark Wielaard wrote:
> Prevent signed underflow by changing loop variables to unsigned and
> doing count checks before decrementing. This isn't really a bug, but
> prevents UB detected by ubsan on fuzzed input. The bad (fuzzed) input
> data
853.html
>
> Avoid calling free on arangelist when it's possibly corrupt.
> Run tests in run-getsrc-die.sh twice, once with .debug_aranges
> present in the testfile and once with the section removed.
This looks good to me.
Please also add a NEWS entry about this.
Thanks,
Mark
dd run-declfiles.sh.
> (declfiles_LDADD): New variable.
> * tests/declfiles.c: New test.
> * tests/run-declfiles.sh: New test.
All looks good. Pushed.
Cheers,
Mark
warf_next_lines.c (dwarf_next_lines): Refactor loops
> over CUs into one loop.
Thanks. The patch itself was hard to understand, but when applied the
code is pretty clear. I only had to double check the reversal of the
split unit check was correct.
Pushed,
Mark
&& next_cu->unit_type != DW_UT_split_type)
> continue;
>
> + Dwarf_Off dwp_off;
> + if (INTUSE(dwarf_cu_dwp_section_info) (next_cu, DW_SECT_LINE,
> + &dwp_off, NULL) == 0)
> + stmt_off += dwp_off;
> +
> if (stmt_off == off)
> {
> *cu = next_cu;
Also correct.
And the new tests in run-declfiles.sh, run-get-files.sh,
run-get-lines.sh, run-next-files.sh and run-next-lines.sh.
You are certainly very thorough. Thanks.
Pushed,
Mark
}
> + if (unit_type != DW_UT_split_type && cui < cu_count)
> + {
> + if ((off & UINT32_MAX) != read_4ubyte_unaligned (dbg, cu_offset))
> + goto not_sorted;
> + cu_index->debug_info_offsets[cui++] = off;
> +
Hi,
On Fri, 2024-03-01 at 15:59 +0100, Mark Wielaard wrote:
> This looks correct, but gcc noticed a path to use tu_offset (and
> tu_index) if they weren't initialized or NULL:
>
> In file included from /home/mark/src/elfutils/libdw/libdwP.h:684,
> from
>
Signed-off-by: Mark Wielaard
---
GPG-KEY | 34 ++
1 file changed, 34 insertions(+)
diff --git a/GPG-KEY b/GPG-KEY
index 671373e6..dca558b7 100644
--- a/GPG-KEY
+++ b/GPG-KEY
@@ -112,3 +112,37 @@
AwhaG1W+Y3LDe7S19M0cUzftEUeq3Jd89hoijC72tdba+BRfW0ncfvEcsk9QifSU
otherwise wrong symbols
> are going to be returned.
Could you give an example or testcase for this?
Thanks,
Mark
Hi Martin,
On Sat, Mar 02, 2024 at 07:43:38PM -0300, Martin Rodriguez Reboredo wrote:
> On 3/2/24 17:47, Mark Wielaard wrote:
> >On Fri, Mar 01, 2024 at 05:04:05PM -0300, Martin Rodriguez Reboredo wrote:
> >>Added a new function dwfl_set_offline_next_addres which will set said
seems to be a space missing in
the make -kcheck command (after the -k). I'll go look in the builder
sources where that came from.
Cheers,
Mark
On Mon, Mar 11, 2024 at 07:05:53AM -0700, Khem Raj wrote:
> On Mon, Mar 11, 2024 at 4:23 AM Mark Wielaard wrote:
> > > - 5: make check ( failure )
> > > Logs:
> > > - stdio:
> > > https://builder.sourceware.org/buildbot/#/bui
-native.sh: New test.
* tests/run-funcretval-struct.sh: Likewise.
https://sourceware.org/bugzilla/show_bug.cgi?id=31142
Signed-off-by: Mark Wielaard
---
backends/riscv_retval.c| 123 ++---
tests/Makefile.am | 7 ++
tests
Hi Aaron,
On Wed, Mar 20, 2024 at 02:14:18PM -0400, Aaron Merey wrote:
> On Wed, Mar 20, 2024 at 11:03 AM Mark Wielaard wrote:
> >
> > dwfl_module_return_value_location would fail on riscv for functions
> > which return a (small) struct. This patch implements the
gle object file. So maybe this is a functionality we need to
expose. But I don't fully understand why you need both a getter and a
setter for any arbitrary address.
Thanks,
Mark
trip this up with
> something along those lines.
aha, I see...
"A struct containing one floating-point real and one integer (or
bitfield), in either order, is passed in a floating-point register and
an integer register, provided the floating-point real is no more than
ABI_FLEN bits wide and the integer is no more than XLEN bits wide."
Yes, that isn't currently recognized. I'll try to add an update to
handle this specific case.
Thanks,
Mark
. Olesen
> +
> + * profile.fish.in: Set $DEBUGINFOD_URLS in fish shells.
> + * Makefile.am: Include profile.fish in install and uninstall targets.
Since we have been putting the ChangeLog entry into the commit message
it doesn't need to also go into the actual Changelog file.
> 202
uninstall targets.
Looks good. Pushed.
Thanks,
Mark
Hi Martin,
On Sun, Mar 24, 2024 at 11:11:21AM -0300, Martin Rodriguez Reboredo wrote:
> On 3/20/24 19:52, Mark Wielaard wrote:
> >Could you show an example of when/where you need it and what address
> >you set it to?
>
> For example, this test program reports the name an
file:981: rpmbuild] Error 1
Aha, we forgot to add it to the debuginfod-client package.
That is what the attached patch does. Which I just pushed.
Cheers,
Mark>From 8f3818574a6abe1fbab1682698b2cef146522148 Mon Sep 17 00:00:00 2001
From: Mark Wielaard
Date: Sun, 24 Mar 2024 18:46:02 +0100
Subject:
file.sh.in: Add || echo -n "" at end of pipe.
* tests/run-debuginfod-client-profile.sh: New test.
* tests/Makefile.am (TESTS): Add run-debuginfod-client-profile.sh.
(EXTRA_DIST): Likewise.
https://sourceware.org/bugzilla/show_bug.cgi?id=31562
Signed-off-by: Ma
Hi Dmitry,
On Wed, Mar 27, 2024 at 12:59:13AM +0200, Dmitry V. Levin wrote:
> On Tue, Mar 26, 2024 at 09:49:48PM +0100, Mark Wielaard wrote:
> > profile.sh might fail with set -o pipefail because:
> >
> > cat /dev/null "${prefix}/etc/debuginfod"/*.urls 2>/dev
Hi Aaron,
Adding Freso to the CC since he is the original author of the fish
support.
On Tue, Mar 26, 2024 at 07:52:49PM -0400, Aaron Merey wrote:
> Fish does not support bracketed variables in scripts. Remove brackets
> from the variable ${prefix} in profile.fish before installation to
> preven
The test uses set -o pipefail which is a bashism and so the test fails
on systems where /bin/sh isn't bash.
* tests/run-debuginfod-client-profile.sh: Use bash.
Signed-off-by: Mark Wielaard
---
tests/run-debuginfod-client-profile.sh | 2 +-
1 file changed, 1 insertion(+), 1 del
Is there a public psabi for Hexagon? Then including an URL to it would
be helpful.
If possible you might want to include some simple test file. See
tests/run-strip-reloc-ko.sh
Thanks,
Mark
Hi Maks,
On Thu, Mar 28, 2024 at 11:29:22PM +0300, Maks Mishin wrote:
> Pointer 'lookup_module' which is a field of the structure 'Dwfl'
> freed at segment.c:88 is not overwritten, but it is usually overwritten
> after free.
But the very next statement is a return true; so old isn't in scope
anym
Hi,
On Thu, Mar 28, 2024 at 11:49:58PM +0300, Maks Mishin wrote:
> The descriptor 'dwfl_fd' is created at nm.c:1278 by calling
> function 'dup' and lost at nm.c:1593.
Sorry, I don't follow, the code at nm.c:1278 says:
/* Duplicate an fd for dwfl_report_offline to swallow. */
tests/Makefile.am (libelf.h): Make symlink instead of copy.
Signed-off-by: Mark Wielaard
---
config/.gitignore | 1 +
tests/.gitignore | 3 +++
tests/Makefile.am | 2 +-
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/config/.gitignore b/config/.gitignore
index 8cd8ccdbf3c1..b789715
posted a patch
to do that:
https://inbox.sourceware.org/elfutils-devel/20240328234308.1032110-1-m...@klomp.org/
Besides that the patch looks fine. I did add a ChangeLog entry to the
commit message. Pushed as attached.
Thanks,
Mark
>From e259f126f5077923e415e306915de50ed0f0db56 Mon Sep 17 00:00:00 2001
Fro
401 - 500 of 3433 matches
Mail list logo
