Hi Paul, On Tue, 2023-11-14 at 09:04 -0800, Paul Pluzhnikov wrote: > On Tue, Nov 14, 2023 at 8:57 AM Mark Wielaard <m...@klomp.org> wrote: > > Looks good. Applied. > > Thanks! > > Appreciate the speedy reviews.
Unfortunately our 32bit buildbots were also very quick to point out an issue: https://builder.sourceware.org/buildbot/#/changes/35202 elfutils-debian-i386 and elfutils-debian-armhf fail to compile the same way: elf_begin.c: In function ‘file_read_elf’: elf_begin.c:495:30: error: cast to pointer from integer of different size [-Werror=int-to-pointer-cast] elf->state.elf64.shdr = (Elf64_Shdr *) (ehdr + e_shoff); ^ cc1: all warnings being treated as errors This is I think because e_shoff is an Elf64_Off, so (ehdr + e_shoff) gets promoted to 64bits... Which does expose an interesting issue that (theoretically) mmaped 64bit Elf files cannot be used on 32bit architectures... hohum. I don't immediately know what the correct fix is here. I'll think about it over dinner. Cheers, Mark
