Re: [PATCH] Add helper function for basename

2023-12-20 Thread Mark Wielaard
Hi Khem, On Wed, Dec 20, 2023 at 08:43:57AM -0800, Khem Raj wrote: > This patch seem to work fine Thanks for double checking. I pushed it as: commit a2194f6b305bf0d0b9dd49dccd0a5c21994c8eea Author: Khem Raj Date: Sun Dec 10 12:20:33 2023 -0800 Add helper function for basename mu

Re: [PATCH] Add helper function for basename

2023-12-20 Thread Khem Raj
Hi Mark This patch seem to work fine On Thu, Dec 14, 2023 at 11:28 AM Khem Raj wrote: > > On Thu, Dec 14, 2023 at 11:22 AM Mark Wielaard wrote: > > > > Hi Khem, > > > > On Thu, Dec 14, 2023 at 10:15:00AM -0800, Khem Raj wrote: > > > Overall, this looks a good improvement on top of my patch so g

Re: [PATCH] Add helper function for basename

2023-12-14 Thread Khem Raj
On Thu, Dec 14, 2023 at 11:22 AM Mark Wielaard wrote: > > Hi Khem, > > On Thu, Dec 14, 2023 at 10:15:00AM -0800, Khem Raj wrote: > > Overall, this looks a good improvement on top of my patch so good to go. > > I will also try it in my local distro builds and see how it goes. > > Thanks. I didn't a

Re: [PATCH] Add helper function for basename

2023-12-14 Thread Mark Wielaard
Hi Khem, On Thu, Dec 14, 2023 at 10:15:00AM -0800, Khem Raj wrote: > Overall, this looks a good improvement on top of my patch so good to go. > I will also try it in my local distro builds and see how it goes. Thanks. I didn't actually test it against musl. So if you could and report whether or n

Re: [PATCH] Add helper function for basename

2023-12-14 Thread Khem Raj
On Thu, Dec 14, 2023 at 10:07 AM Mark Wielaard wrote: > > Hi Khem, > > On Sun, 2023-12-10 at 12:20 -0800, Khem Raj wrote: > > musl does not provide GNU version of basename and lately have removed > > the definiton from string.h [1] which exposes this problem. It can be > > made to work by providin

Re: [PATCH] Add helper function for basename

2023-12-14 Thread Mark Wielaard
0f4381c835004544f7c5ee596845bb17044 Mon Sep 17 00:00:00 2001 From: Khem Raj Date: Sun, 10 Dec 2023 12:20:33 -0800 Subject: [PATCH] Add helper function for basename musl does not provide GNU version of basename and lately have removed the definiton from string.h [1] which exposes this problem. It

Re: [PATCH] Add helper function for basename

2023-12-13 Thread Mark Wielaard
On Wed, Dec 13, 2023 at 08:29:01AM -0800, Khem Raj wrote: > On Wed, Dec 13, 2023 at 7:10 AM Mark Wielaard wrote: > > > > Hi Khem, > > > > On Tue, 2023-12-12 at 09:16 -0800, Khem Raj wrote: > > > On Tue, Dec 12, 2023 at 5:18 AM Mark Wielaard wrote: > > > > On Sun, 2023-12-10 at 12:20 -0800, Khem R

Re: [PATCH] Add helper function for basename

2023-12-13 Thread Khem Raj
On Wed, Dec 13, 2023 at 7:10 AM Mark Wielaard wrote: > > Hi Khem, > > On Tue, 2023-12-12 at 09:16 -0800, Khem Raj wrote: > > On Tue, Dec 12, 2023 at 5:18 AM Mark Wielaard wrote: > > > On Sun, 2023-12-10 at 12:20 -0800, Khem Raj wrote: > > > > musl does not provide GNU version of basename and late

Re: [PATCH] Add helper function for basename

2023-12-13 Thread Mark Wielaard
Hi Khem, On Tue, 2023-12-12 at 09:16 -0800, Khem Raj wrote: > On Tue, Dec 12, 2023 at 5:18 AM Mark Wielaard wrote: > > On Sun, 2023-12-10 at 12:20 -0800, Khem Raj wrote: > > > musl does not provide GNU version of basename and lately have removed > > > the definiton from string.h [1] which exposes

Re: [PATCH] Add helper function for basename

2023-12-12 Thread Khem Raj
On Tue, Dec 12, 2023 at 5:18 AM Mark Wielaard wrote: > > Hi Khem, > > On Sun, 2023-12-10 at 12:20 -0800, Khem Raj wrote: > > musl does not provide GNU version of basename and lately have removed > > the definiton from string.h [1] which exposes this problem. It can be > > made to work by providing

Re: [PATCH] Add helper function for basename

2023-12-12 Thread Mark Wielaard
Hi Khem, On Sun, 2023-12-10 at 12:20 -0800, Khem Raj wrote: > musl does not provide GNU version of basename and lately have removed > the definiton from string.h [1] which exposes this problem. It can be > made to work by providing a local implementation of basename which > implements the GNU base

[PATCH] Add helper function for basename

2023-12-10 Thread Khem Raj
musl does not provide GNU version of basename and lately have removed the definiton from string.h [1] which exposes this problem. It can be made to work by providing a local implementation of basename which implements the GNU basename behavior, this makes it work across C libraries which have POSIX