On Tue, Dec 12, 2023 at 5:18 AM Mark Wielaard <m...@klomp.org> wrote: > > Hi Khem, > > On Sun, 2023-12-10 at 12:20 -0800, Khem Raj wrote: > > musl does not provide GNU version of basename and lately have removed > > the definiton from string.h [1] which exposes this problem. It can be > > made to work by providing a local implementation of basename which > > implements the GNU basename behavior, this makes it work across C > > libraries which have POSIX implementation only. > > Thanks, this should work, but wouldn't it be easier to add a configure > test for having basename defined in string.h and then only define > basename in libeu.h (and build basename.c) if it isn't. So that all the > code can just keep using basename (we just have to make sure libeu.h is > included)?
we could do that but it will not work as expected with older musl releases where the prototype in string.h will exist. > > Cheers, > > Mark
