From: Timm Bäder
Get rid of a nested function this way.
---
libdwfl/dwfl_segment_report_module.c | 162 +--
1 file changed, 80 insertions(+), 82 deletions(-)
diff --git a/libdwfl/dwfl_segment_report_module.c
b/libdwfl/dwfl_segment_report_module.c
index a082886a..c48d9ab
From: Timm Bäder
---
libdwfl/dwfl_segment_report_module.c | 65 +++-
1 file changed, 35 insertions(+), 30 deletions(-)
diff --git a/libdwfl/dwfl_segment_report_module.c
b/libdwfl/dwfl_segment_report_module.c
index 391fd761..a082886a 100644
--- a/libdwfl/dwfl_segment_rep
From: Timm Bäder
Use a read_state struct here to minimize the amount of parameters we
pass.
---
libdwfl/dwfl_segment_report_module.c | 38
1 file changed, 28 insertions(+), 10 deletions(-)
diff --git a/libdwfl/dwfl_segment_report_module.c
b/libdwfl/dwfl_segment_rep
Here are the three patches to remove the three remaining nested
functions from libdwfl/dwfl_segment_report_module.c.
On 25/11/2020 17:33, Mark Wielaard wrote:
Hi Timm,
On Mon, 2020-11-23 at 13:27 +0100, Timm Bäder via Elfutils-devel wrote:
version 2 of this patch set. I removed segmend_read() entirely now,
which meant modifying a bunch of later patches. Other than that, they
are the same.
Hope the --from to
On Wed, Nov 25, 2020 at 12:50:18PM -0500, Frank Ch. Eigler via Elfutils-devel
wrote:
> Hi -
>
> > Looks good. Just one question about the RAII timing metrics.
> > It is using gettimeofday which I believe might jump around since it
> > tracks "human time". Might it be better to use clock_gettime
>