On Wed, Nov 25, 2020 at 12:50:18PM -0500, Frank Ch. Eigler via Elfutils-devel wrote: > Hi - > > > Looks good. Just one question about the RAII timing metrics. > > It is using gettimeofday which I believe might jump around since it > > tracks "human time". Might it be better to use clock_gettime > > (CLOCK_MONOTONIC) instead? Note that uses nanoseconds instead of > > microseconds, so needs adjusting a factor 1000. > > Sure, can switch the new and old code over to that.
Thanks, I hadn't realized (remembered) we were using gettimeofday all over the place already. It might not cause real issues, but better to make sure we are measuring monotonic time to prevent "impossible" metrics. Cheers, Mark
