On Saturday 26 September 2009 20:10:59 kmike wrote:
> Not true. cache_page decorator is now documented as putting view
> first and timeout second. Take a look at
> http://docs.djangoproject.com/en/dev/topics/cache/#the-per-view-ca
> che
Doh, I don't know how I managed to read those several tim
If you search for `cache_page` decorator than it becomes clear that
traditional approach is to use it in now unsupported way:
myview = cache_page(myviewt, timeout)
For example here:
http://www.google.com/codesearch?hl=ru&sa=N&q=%22+%3D+cache_page%22++lang:python&ct=rr&cs_r=lang:python
nobody u
On Monday 21 September 2009 20:27:50 Jacob Kaplan-Moss wrote:
> No, I think this is precisely correct. I've been meaning to do
> exactly what you're proposing for a while myself; just haven't
> gotten around to it.
>
> > decorator_from_middleware isn't actually documented anywhere
>
> I actua
On Wednesday 23 September 2009 23:40:25 James Bennett wrote:
> So, I've worked out what the problem is.
>
> Previously either of these worked:
>
> cache_page(timeout, view)
> cache_page(view, timeout)
>
> Now, cache_page assumes that the first positional argument will be
> the timeout. So wha
On Tue, Sep 22, 2009 at 4:07 PM, Luke Plant wrote:
> Bummer, I tried hard not to break it - I added backwards
> compatibility tests for the basic different uses. Could you produce
> a test case?
So, I've worked out what the problem is.
Previously either of these worked:
cache_page(timeout, vi
On Tue, Sep 22, 2009 at 6:04 PM, Jacob Kaplan-Moss wrote:
>
> On Tue, Sep 22, 2009 at 4:16 PM, Luke Plant wrote:
>> James B - do we have a place to list things like this i.e. things
>> that probably should go in release notes?
>
> I think it'd probably be best to just start
> docs/releases/1.2-a
On Tue, Sep 22, 2009 at 4:16 PM, Luke Plant wrote:
> James B - do we have a place to list things like this i.e. things
> that probably should go in release notes?
I think it'd probably be best to just start
docs/releases/1.2-alpha.txt right now. We can list this stuff as we
add it, and then some
Regarding key_prefix parameter: it's all simply about that:
http://code.djangoproject.com/ticket/11269
My proposal was to move things in opposite direction: to promote
`key_prefix` parameter, document it and make it more useful. If it is
an 'Design decision needed'-type of issue and design decisio
On Tuesday 22 September 2009 20:37:05 kmike wrote:
> cache_page decorator previously used to have optional
> 'key_prefix' argument, not only timeout. Is it gone? Can I use
>
> @cache_page(3600, key_prefix='vasia')
> def my_func(request)
>...
>
That wasn't documented anywhere as far as I ca
On Tuesday 22 September 2009 21:31:08 James Bennett wrote:
> On Mon, Sep 21, 2009 at 9:04 PM, Luke Plant
wrote:
> > I've committed my change [1], and also replaced _CheckLogin
> > with my method [2] (it was essentially the same method, just
> > generalised).
>
> The decorator_from_middleware ch
On Mon, Sep 21, 2009 at 9:04 PM, Luke Plant wrote:
> I've committed my change [1], and also replaced _CheckLogin with my method [2]
> (it was essentially the same method, just generalised).
The decorator_from_middleware change appears to have broken
cache_page; I'm now getting "AttributeError: '
cache_page decorator previously used to have optional 'key_prefix'
argument, not only timeout. Is it gone? Can I use
@cache_page(3600, key_prefix='vasia')
def my_func(request)
...
Another question: in 'decorator_from_middleware_with_args' docstring
example stated:
Use like::
cache_page =
On Monday 21 September 2009 20:27:50 Jacob Kaplan-Moss wrote:
> On Mon, Sep 21, 2009 at 1:21 PM, Luke Plant wrote:
> > However, decorator_from_middleware is a pain, since it doesn't always
> > return a an actual decorator, for "historical reasons". I need to change
> > this to fix the bug. Is a
On Mon, Sep 21, 2009 at 1:21 PM, Luke Plant wrote:
> However, decorator_from_middleware is a pain, since it doesn't always return a
> an actual decorator, for "historical reasons". I need to change this to fix
> the bug. Is anyone against this?
No, I think this is precisely correct. I've been
14 matches
Mail list logo
