On Saturday 26 September 2009 20:10:59 kmike wrote: > Not true. cache_page decorator is now documented as putting view > first and timeout second. Take a look at > http://docs.djangoproject.com/en/dev/topics/cache/#the-per-view-ca > che
Doh, I don't know how I managed to read those several times and not see that! I've fixed it now, thanks! Alex Gaynor reckoned both ways round were possible with previous code. I haven't checked that, but I'll believe him, and I've added compatibility for that. > Another thought. If key_prefix is deprecated in cache_page > decorator maybe it should be also deprecated in CacheMiddleware? It's not 'deprecated' - it was never documented, and therefore never a feature in the first place, and so I didn't see the need to implement it. We could of course re-add it, and document it. As it happens, doing so looks easy. I'm not sure why those arguments are not documented anywhere, either for cache_page or CacheMiddleware, that's why I'm reluctant to add this -- we would then be committing ourselves to supporting something that we might have wanted to remove. Putting specific support for it in cache_page would make it harder to remove. Does anyone else know if we want to expose all the arguments of CacheMiddleware in cache_page? I can easily add them if so. Regards, Luke -- "Smoking cures weight problems...eventually..." (Steven Wright) Luke Plant || http://lukeplant.me.uk/ --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
