Re: Psycopg2 version support

2015-02-16 Thread Collin Anderson
On Mon, Feb 16, 2015 at 1:41 PM, Thomas Stephenson wrote: > And now I'll shut up, because I'm not entitled to an opinion here yet :D > By the way, Thomas, your opinion is welcome. :) Collin -- You received this message because you are subscribed to the Google Groups "Django developers (Cont

Re: Psycopg2 version support

2015-02-16 Thread Thomas Stephenson
ps. 2.4.5 is the real minimum. The db.backends module loads without error at 2.4.3, but proper support for Inet arrays was not added until 2.4.5, so any code that uses GenericIPAddressField could fail unexpectedly. And now I'll shut up, because I'm not entitled to an opinion here yet :D Thomas

Re: Psycopg2 version support

2015-02-16 Thread Thomas Stephenson
2.5 is relatively easy to work around in contrib.postgres and a consistent minimum everywhere is more straightforward. There is just a conditional import on the fields.Range and forms.Range modules to deal with. I'd also add in a module level check that the psycopg2 version is OK, so that the

Re: Psycopg2 version support

2015-02-16 Thread Tim Graham
Hi Wim, Thanks for the feedback. My thinking is that requiring 2.5 will needlessly cut off anyone who really wants to use an older version (like Debian stable), but patching contrib.postgres to work with < 2.5 will add complexity which we want to avoid. Here's the pull request that implements

Re: Psycopg2 version support

2015-02-16 Thread Wim Feijen
Hi, I am definitely in favor of just one version requirement in order not to complicate things. So then the minimum version would be either 2.5; or 2.4.5 and write special cases in contrib.postgres to deal with that. Regards, Wim On Monday, 16 February 2015 16:04:50 UTC+1, Tim Graham wrote: >

Re: Psycopg2 version support

2015-02-16 Thread Tim Graham
How about this plan: * Document 2.4.3 as the minimum if you don't want to use contrib.postgres * Recommend 2.5+ and document it as the minimum to use contrib.postgres * Require 2.5+ for Django's test suite to avoid having to add conditional imports/test skipping. On Monday, February 16, 2015 at 9

Re: Psycopg2 version support

2015-02-16 Thread Gert Van Gool
In CentOS 6, you can't run Django 1.8 anyway. It ships Python 2.6. So if you want to run Django 1.8 on CentOS 6, you need to compile Python yourself. In that case I don't think they'll complain about having to build psycopg2 separately as well. In the RHEL/CentOS universe, anyone who wants to run

Re: Psycopg2 version support

2015-02-16 Thread Thomas Stephenson
My mistake, sorry. So, to get the conversation back on track, is `2.4.5` acceptable as the minimum version, even if users who - use CentOS 6 - install dependencies via the OS package manager - don't have sudo/root - can't request the sysadmin to install dev packages; and - keep django at the lat

Re: Psycopg2 version support

2015-02-16 Thread Florian Apolloner
Not exactly, cause installing psycopg2 via the OS package manager should __not__ require dev packages at all. On Monday, February 16, 2015 at 11:57:01 AM UTC+1, Thomas Stephenson wrote: > > > Installing psycopg2 does require development tools, while Django does not > > Installing psycopg2 2.0.0 r

Re: Psycopg2 version support

2015-02-16 Thread Raphael Michel
Am Mon, 16 Feb 2015 01:15:53 -0800 (PST) schrieb Thomas Stephenson : > The postgres-*.*-dev libraries are a requirement for both 2.0.14 and > 2.5, so if it's possible to install 2.0.14 via the package manager > then it's possible to pip install 2.5. No, I believe this is not correct. The system pa

Re: Psycopg2 version support

2015-02-16 Thread Thomas Stephenson
> Installing psycopg2 does require development tools, while Django does not. I'm not offering this as a compelling argument for anything, just an observation. The postgres-*.*-dev libraries are a requirement for both 2.0.14 and 2.5, so if it's possible to install 2.0.14 via the package manage

Re: Psycopg2 version support

2015-02-16 Thread Thomas Stephenson
> Installing psycopg2 does require development tools, while Django does not Installing psycopg2 2.0.0 requires exactly the same `postgres-*-dev` libraries that 2.5 does as far as I know. If it is possible to install psycopg2 via the OS package manager then 2.5 can be installed via pip. On Monda

Re: Psycopg2 version support

2015-02-16 Thread Gert Van Gool
For what it's worth, CentOS 6 (supported until November 30, 2020) ships with 2.0.14. CentOS 7 has 2.5.1. -- Gert Mobile: +32 498725202 Twitter: @gvangool Web: http://gertvangool.be On Mon, Feb 16, 2015 at 9:11 AM, Florian Apolloner wrote: > Core could stay at 2.4.

Re: Psycopg2 version support

2015-02-16 Thread Florian Apolloner
Core could stay at 2.4.5 and contrib.postgresql could require a newer version :) On Saturday, February 14, 2015 at 9:53:43 PM UTC+1, Marc Tamlyn wrote: > > Hi all, > > Related ticket - https://code.djangoproject.com/ticket/24335 > > Django 1.8 will necessarily be the first version with a true min

Re: Psycopg2 version support

2015-02-15 Thread Collin Anderson
Right, I think the situation would be if you don't have admin/sudo and the -dev / -devel header files are not present. Seems to me 2.4.5 would be a safe minimum today, but supporting it until 2018 seems a bit excessive. On Sun, Feb 15, 2015 at 7:18 PM, Christophe Pettus wrote: > > On Feb 15, 20

Re: Psycopg2 version support

2015-02-15 Thread Christophe Pettus
On Feb 15, 2015, at 4:14 PM, Tim Graham wrote: > Is there a scenario where you could pip install Django but not pip install > psycopg2? Installing psycopg2 does require development tools, while Django does not. I'm not offering this as a compelling argument for anything, just an observation.

Re: Psycopg2 version support

2015-02-15 Thread Tim Graham
Unless any counter arguments are presented, I suggest let's require psycopg 2.5 for now. Is there a scenario where you could pip install Django but not pip install psycopg2? On Saturday, February 14, 2015 at 5:43:32 PM UTC-5, Shai Berger wrote: > > Hi all, > > On Saturday 14 February 2015 22:53

Re: Psycopg2 version support

2015-02-14 Thread Shai Berger
Hi all, On Saturday 14 February 2015 22:53:13 Marc Tamlyn wrote: > > Django 1.8 will necessarily be the first version with a true minimum > requirement on psycopg2 version. Historically we have never documented a > required version. > FWIW, we have long had minimum requirements for other backen

Psycopg2 version support

2015-02-14 Thread Marc Tamlyn
Hi all, Related ticket - https://code.djangoproject.com/ticket/24335 Django 1.8 will necessarily be the first version with a true minimum requirement on psycopg2 version. Historically we have never documented a required version. - The new UUIDField requires at least 2.0.9 - Some code which is cu