ps. 2.4.5 is the real minimum. The db.backends module loads without error at 2.4.3, but proper support for Inet arrays was not added until 2.4.5, so any code that uses GenericIPAddressField could fail unexpectedly.
And now I'll shut up, because I'm not entitled to an opinion here yet :D Thomas On Tuesday, February 17, 2015 at 5:35:12 AM UTC+11, Thomas Stephenson wrote: > > 2.5 is relatively easy to work around in contrib.postgres and a consistent > minimum everywhere is more straightforward. There is just a conditional > import on the fields.Range and forms.Range modules to deal with. > > I'd also add in a module level check that the psycopg2 version is OK, so > that the module loads with a clear error. Not everyone checks the > documentation. > > On Tuesday, February 17, 2015 at 5:07:47 AM UTC+11, Tim Graham wrote: >> >> Hi Wim, >> >> Thanks for the feedback. My thinking is that requiring 2.5 will >> needlessly cut off anyone who really wants to use an older version (like >> Debian stable), but patching contrib.postgres to work with < 2.5 will add >> complexity which we want to avoid. >> >> Here's the pull request that implements my proposal: >> >> https://github.com/django/django/pull/4148 >> <https://www.google.com/url?q=https%3A%2F%2Fgithub.com%2Fdjango%2Fdjango%2Fpull%2F4148&sa=D&sntz=1&usg=AFQjCNGbV7bKcuqvm4YrFpSmowjbM1d9rg> >> >> I think it's simple enough. How about you? >> >> On Monday, February 16, 2015 at 12:49:57 PM UTC-5, Wim Feijen wrote: >>> >>> Hi, >>> >>> I am definitely in favor of just one version requirement in order not to >>> complicate things. So then the minimum version would be either 2.5; or >>> 2.4.5 and write special cases in contrib.postgres to deal with that. >>> >>> Regards, Wim >>> >>> On Monday, 16 February 2015 16:04:50 UTC+1, Tim Graham wrote: >>>> >>>> How about this plan: >>>> * Document 2.4.3 as the minimum if you don't want to use >>>> contrib.postgres >>>> * Recommend 2.5+ and document it as the minimum to use contrib.postgres >>>> * Require 2.5+ for Django's test suite to avoid having to add >>>> conditional imports/test skipping. >>>> >>>> On Monday, February 16, 2015 at 9:20:51 AM UTC-5, Gert Van Gool wrote: >>>>> >>>>> In CentOS 6, you can't run Django 1.8 anyway. It ships Python 2.6. >>>>> >>>>> So if you want to run Django 1.8 on CentOS 6, you need to compile >>>>> Python yourself. In that case I don't think they'll complain about having >>>>> to build psycopg2 separately as well. >>>>> >>>>> In the RHEL/CentOS universe, anyone who wants to run Django 1.8 needs >>>>> either SCL's (software collections that are installed next to system >>>>> binaries) or has access to psycopg2 2.5. >>>>> >>>>> So my point for CentOS/RHEL 6 can be ignored. >>>>> >>>>> -- Gert >>>>> >>>>> Mobile: +32 498725202 >>>>> Twitter: @gvangool <http://twitter.com/gvangool> >>>>> Web: http://gertvangool.be >>>>> >>>>> On Mon, Feb 16, 2015 at 3:10 PM, Thomas Stephenson <ova...@gmail.com> >>>>> wrote: >>>>> >>>>>> My mistake, sorry. >>>>>> >>>>>> So, to get the conversation back on track, is `2.4.5` acceptable as >>>>>> the minimum version, even if users who >>>>>> >>>>>> - use CentOS 6 >>>>>> - install dependencies via the OS package manager >>>>>> - don't have sudo/root >>>>>> - can't request the sysadmin to install dev packages; and >>>>>> - keep django at the latest version >>>>>> >>>>>> don't have a valid upgrade path? >>>>>> >>>>>> Thomas >>>>>> >>>>>> >>>>>> On Tuesday, February 17, 2015 at 12:36:11 AM UTC+11, Florian >>>>>> Apolloner wrote: >>>>>>> >>>>>>> Not exactly, cause installing psycopg2 via the OS package manager >>>>>>> should __not__ require dev packages at all. >>>>>>> >>>>>>> On Monday, February 16, 2015 at 11:57:01 AM UTC+1, Thomas Stephenson >>>>>>> wrote: >>>>>>>> >>>>>>>> > Installing psycopg2 does require development tools, while Django >>>>>>>> does not >>>>>>>> >>>>>>>> Installing psycopg2 2.0.0 requires exactly the same >>>>>>>> `postgres-*-dev` libraries that 2.5 does as far as I know. If it is >>>>>>>> possible to install psycopg2 via the OS package manager then 2.5 can >>>>>>>> be >>>>>>>> installed via pip. >>>>>>>> >>>>>>>> On Monday, February 16, 2015 at 11:18:56 AM UTC+11, Xof wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>> On Feb 15, 2015, at 4:14 PM, Tim Graham <timog...@gmail.com> >>>>>>>>> wrote: >>>>>>>>> >>>>>>>>> > Is there a scenario where you could pip install Django but not >>>>>>>>> pip install psycopg2? >>>>>>>>> >>>>>>>>> Installing psycopg2 does require development tools, while Django >>>>>>>>> does not. I'm not offering this as a compelling argument for >>>>>>>>> anything, >>>>>>>>> just an observation. >>>>>>>>> >>>>>>>>> -- >>>>>>>>> -- Christophe Pettus >>>>>>>>> x...@thebuild.com >>>>>>>>> >>>>>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Django developers (Contributions to Django itself)" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to django-develop...@googlegroups.com. >>>>>> To post to this group, send email to django-d...@googlegroups.com. >>>>>> Visit this group at http://groups.google.com/group/django-developers. >>>>>> To view this discussion on the web visit >>>>>> https://groups.google.com/d/msgid/django-developers/4efc59f0-0b97-4ed9-bbce-bd1b124ea978%40googlegroups.com >>>>>> >>>>>> <https://groups.google.com/d/msgid/django-developers/4efc59f0-0b97-4ed9-bbce-bd1b124ea978%40googlegroups.com?utm_medium=email&utm_source=footer> >>>>>> . >>>>>> >>>>>> For more options, visit https://groups.google.com/d/optout. >>>>>> >>>>> >>>>> -- You received this message because you are subscribed to the Google Groups "Django developers (Contributions to Django itself)" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-developers+unsubscr...@googlegroups.com. To post to this group, send email to django-developers@googlegroups.com. Visit this group at http://groups.google.com/group/django-developers. To view this discussion on the web visit https://groups.google.com/d/msgid/django-developers/07b8e166-ac66-4d6c-82eb-e28f3756ccac%40googlegroups.com. For more options, visit https://groups.google.com/d/optout.
