Re: #11834: colorized debug page. Assigned to buriy

2010-08-12 Thread burc...@gmail.com
Hi, On Thu, Aug 12, 2010 at 9:54 PM, Thomas Guettler wrote: > Hi, > > a colorized debug page helps a lot. More than 99% of errors > are in my code, and not in django's. This patch gives "own" code > a different color. > > It is assigned to "buriy" since 6 months. > >  http://code.djangoproject.co

Re: Invalid deleted forms in formsets break form data access

2010-08-12 Thread petr.marhoun
There is another ticket which try to solve this problem: http://code.djangoproject.com/ticket/13878 The proposed solution is to add new attribute "formset.valid_forms" - list of valid (and filled) forms. So problematic attribute "formset.cleaned_data" (which sometimes raises "AttributeError" for v

modelform_factory and metaclasses

2010-08-12 Thread Joseph Spiros
I reported ticket #14082[1] a few days ago, but I apparently skipped the step in the "Contributing to Django" guide where I should mention the problem here. So, hello! Anyway, the problem is: If I create a ModelForm subclass and specify a custom metaclass, it is not honored by modelform_factory. T

Re: #11834: colorized debug page. Assigned to buriy

2010-08-12 Thread Dougal Matthews
On 12 August 2010 15:54, Thomas Guettler wrote: > Why not commit? > I don't know the exact reason but its missing a few things. There are no tests or documentation and these are both required. Reading through the comments there doesn't seem to be a final decision on the colours and the latest p

#11834: colorized debug page. Assigned to buriy

2010-08-12 Thread Thomas Guettler
Hi, a colorized debug page helps a lot. More than 99% of errors are in my code, and not in django's. This patch gives "own" code a different color. It is assigned to "buriy" since 6 months. http://code.djangoproject.com/ticket/11834 Why not commit? Thomas -- Thomas Guettler, http://www.th

Re: Invalid deleted forms in formsets break form data access

2010-08-12 Thread Karen Tracey
On Thu, Aug 12, 2010 at 3:32 AM, Tomi Pieviläinen wrote: > This problem is encountered when a user starts modifying a form but > decides that the whole set of data should be deleted anyway. Requiring > that the form should be fixed before deletion is possible seems like > an unreasonable request,

Invalid deleted forms in formsets break form data access

2010-08-12 Thread Tomi Pieviläinen
I first approached the users-list to find out if I was simply doing something wrong, but seems like there's no (obvious) mistake. In a formset with can_delete, fs.is_valid() passes even if some of the deleted forms are invalid. However fs.cleaned_data tries to access every form, including the dele