I reported ticket #14082[1] a few days ago, but I apparently skipped the step in the "Contributing to Django" guide where I should mention the problem here. So, hello!
Anyway, the problem is: If I create a ModelForm subclass and specify a custom metaclass, it is not honored by modelform_factory. This results in inconsistency between my own direct instantiation of my ModelForm subclass, versus when I'm using something that indirectly instantiates using modelform_factory (most relevant to me being the admin). I'm new to submitting patches, as well as writing tests, so I didn't include any tests in my patch. That said, my patch is fairly simple and self-explanatory: I've changed modelform_factory to check if the form being passed in as the parent is a ModelForm subclass, and, if so, it uses the metaclass set on the parent form. Otherwise, it works as it did previously, using ModelFormMetaclass. This should change behavior only in cases where a ModelForm subclass is provided as a parent, and a custom metaclass is set. Comments? Suggestions? Could anyone take a look? [1]: http://code.djangoproject.com/ticket/14082 -- Joseph Spiros iThink Software joseph.spi...@ithinksw.com +1 (440) 707-6855 -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
