Re: [PATCH 3/3] rbtree: Do not set node off-tree in extract

2014-07-21 Thread Joel Sherrill
On 7/21/2014 12:54 PM, Sebastian Huber wrote: > On 07/21/2014 07:23 PM, Joel Sherrill wrote: >> Unless the chain has changed to have the property of >> "dangerous to extract if not on", this should be OK. >> >> My thinking is that higher level code would be checking a state >> of some sort and kno

Re: [PATCH 3/3] rbtree: Do not set node off-tree in extract

2014-07-21 Thread Sebastian Huber
On 07/21/2014 07:23 PM, Joel Sherrill wrote: Unless the chain has changed to have the property of "dangerous to extract if not on", this should be OK. My thinking is that higher level code would be checking a state of some sort and know whether to extract from the underlying chain or rbtree cont

Re: [PATCH 3/3] rbtree: Do not set node off-tree in extract

2014-07-21 Thread Joel Sherrill
Unless the chain has changed to have the property of "dangerous to extract if not on", this should be OK. My thinking is that higher level code would be checking a state of some sort and know whether to extract from the underlying chain or rbtree container. Is this true? If so, this looks OK. O