Re: [PATCH v7] tests for fenv.h functions

2020-03-22 Thread Gedare Bloom
On Sun, Mar 22, 2020 at 3:59 AM Eshan Dhawan wrote: > > > > On Sun, Mar 22, 2020 at 12:21 AM Gedare Bloom wrote: >> >> I liked it better before, when the test prints nothing if it is >> successful. I think this is the trend we are heading toward in rtems >> tests. >> > I will incorporate more cha

Re: [PATCH v7] tests for fenv.h functions

2020-03-22 Thread Eshan Dhawan
On Sun, Mar 22, 2020 at 12:21 AM Gedare Bloom wrote: > I liked it better before, when the test prints nothing if it is > successful. I think this is the trend we are heading toward in rtems > tests. > > I will incorporate more changes to the test so there is minimal printing if the test is succes

Re: [PATCH v7] tests for fenv.h functions

2020-03-21 Thread Gedare Bloom
PS: This is getting better incrementally, you're doing a good job getting through your first real patch :) It can be a real challenge sometimes especially since there are a lot of nit-picky things to learn with the coding style issues. On Sat, Mar 21, 2020 at 12:51 PM Gedare Bloom wrote: > > I li

Re: [PATCH v7] tests for fenv.h functions

2020-03-21 Thread Gedare Bloom
I liked it better before, when the test prints nothing if it is successful. I think this is the trend we are heading toward in rtems tests. On Sat, Mar 21, 2020 at 11:46 AM Eshan Dhawan wrote: > > I ran the code using qemu for risc-v architecture. > The value of r = 0 for the function to run with

Re: [PATCH v7] tests for fenv.h functions

2020-03-21 Thread Eshan Dhawan
I ran the code using qemu for risc-v architecture. The value of r = 0 for the function to run without error while the error is raised when the value is not matched with the correct value defined in rtems_test_assert(). ___ devel mailing list devel@rtems.o

Re: [PATCH v7] tests for fenv.h functions

2020-03-21 Thread Aditya Upadhyay
On Sat, Mar 21, 2020 at 11:04 PM Eshan Dhawan wrote: > > > > On Sat, Mar 21, 2020 at 10:48 PM Aditya Upadhyay wrote: >> >> On Sat, Mar 21, 2020 at 9:32 PM Eshan Dhawan wrote: >> > >> > I have added the changes as told by Aditya >> > I would like to know is any other changes are required to be ma

Re: [PATCH v7] tests for fenv.h functions

2020-03-21 Thread Eshan Dhawan
On Sat, Mar 21, 2020 at 10:48 PM Aditya Upadhyay wrote: > On Sat, Mar 21, 2020 at 9:32 PM Eshan Dhawan > wrote: > > > > I have added the changes as told by Aditya > > I would like to know is any other changes are required to be made to > make the patch usable > > > > Thanks > > Eshan > > > On 21

Re: [PATCH v7] tests for fenv.h functions

2020-03-21 Thread Aditya Upadhyay
On Sat, Mar 21, 2020 at 9:32 PM Eshan Dhawan wrote: > > I have added the changes as told by Aditya > I would like to know is any other changes are required to be made to make the > patch usable > > Thanks > Eshan > > On 21-Mar-2020, at 8:20 PM, Eshan dhawan wrote: > > > > --- > > testsuites/psx

Re: [PATCH v7] tests for fenv.h functions

2020-03-21 Thread Eshan Dhawan
I have added the changes as told by Aditya I would like to know is any other changes are required to be made to make the patch usable Thanks Eshan > On 21-Mar-2020, at 8:20 PM, Eshan dhawan wrote: > > --- > testsuites/psxtests/psxfenv01/init.c | 89 ++-- > 1 file cha

[PATCH v7] tests for fenv.h functions

2020-03-21 Thread Eshan dhawan
--- testsuites/psxtests/psxfenv01/init.c | 89 ++-- 1 file changed, 71 insertions(+), 18 deletions(-) diff --git a/testsuites/psxtests/psxfenv01/init.c b/testsuites/psxtests/psxfenv01/init.c index cdb0fa596e..0ea820c523 100644 --- a/testsuites/psxtests/psxfenv01/init.c ++