Re: [PATCH 04/22] dosfs: Avoid MIN() re-definition

2014-11-21 Thread Peter Dufault
Much better, thanks. I should have read all the email first, I was getting caught up on the last few days. I recall you asked about doing that. > On Nov 21, 2014, at 06:11 , Sebastian Huber > wrote: > > On 21/11/14 11:26, Peter Dufault wrote: >> I don't like these kind of "ifndef" tests befo

Re: [PATCH 04/22] dosfs: Avoid MIN() re-definition

2014-11-21 Thread Sebastian Huber
On 21/11/14 11:26, Peter Dufault wrote: I don't like these kind of "ifndef" tests before defining something because how do you know it was defined compatibly? Granted MIN is well-known so that's less likely than other uses of this pattern. Can the definition be made identical to the other def

Re: [PATCH 04/22] dosfs: Avoid MIN() re-definition

2014-11-21 Thread Peter Dufault
I don't like these kind of "ifndef" tests before defining something because how do you know it was defined compatibly? Granted MIN is well-known so that's less likely than other uses of this pattern. Can the definition be made identical to the other definition to eliminate a warning or does GC

[PATCH 04/22] dosfs: Avoid MIN() re-definition

2014-11-18 Thread Sebastian Huber
--- cpukit/libfs/src/dosfs/fat.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/cpukit/libfs/src/dosfs/fat.h b/cpukit/libfs/src/dosfs/fat.h index 2f0f75f..26f0699 100644 --- a/cpukit/libfs/src/dosfs/fat.h +++ b/cpukit/libfs/src/dosfs/fat.h @@ -68,7 +68,9 @@ extern "C" { #define CT_LE_L