Re: [PATCH] cpukit/include/dev/can: Disabled debug prints in CAN Framework

2022-12-01 Thread Prashanth S
>The CAN bus changes have warnings ... > >In file included from ../../../cpukit/include/dev/can/canqueueimpl.h:48, >from ../../../cpukit/dev/can/can.c:45: >../../../cpukit/dev/can/can.c: In function 'can_bus_read': >../../../cpukit/dev/can/can.c:213:15: warning: format '%u' expects

Re: [PATCH] cpukit/include/dev/can: Disabled debug prints in CAN Framework

2022-12-01 Thread Chris Johns
On 2/12/2022 2:38 pm, Chris Johns wrote: > The CAN bus changes have warnings ... > > In file included from ../../../cpukit/include/dev/can/canqueueimpl.h:48, > from ../../../cpukit/dev/can/can.c:45: > ../../../cpukit/dev/can/can.c: In function 'can_bus_read': > ../../../cpukit/dev

Re: [PATCH] cpukit/include/dev/can: Disabled debug prints in CAN Framework

2022-12-01 Thread Chris Johns
The CAN bus changes have warnings ... In file included from ../../../cpukit/include/dev/can/canqueueimpl.h:48, from ../../../cpukit/dev/can/can.c:45: ../../../cpukit/dev/can/can.c: In function 'can_bus_read': ../../../cpukit/dev/can/can.c:213:15: warning: format '%u' expects argum

Re: [PATCH] cpukit/include/dev/can: Disabled debug prints in CAN Framework

2022-11-29 Thread Prashanth S
>On Tue, Nov 29, 2022 at 6:58 AM Prashanth S wrote: >> >> > On 29/11/2022 05:57, Gedare Bloom wrote: >> > >> @@ -111,18 +113,18 @@ static void test_task(rtems_task_argument data) >> > >> >> > >> msg_size = ((char *)&msg.data[msg.len] - (char *)&msg); >> > >> >> > >> -printf("calling writ

Re: [PATCH] cpukit/include/dev/can: Disabled debug prints in CAN Framework

2022-11-29 Thread Gedare Bloom
On Tue, Nov 29, 2022 at 6:58 AM Prashanth S wrote: > > > On 29/11/2022 05:57, Gedare Bloom wrote: > > >> @@ -111,18 +113,18 @@ static void test_task(rtems_task_argument data) > > >> > > >> msg_size = ((char *)&msg.data[msg.len] - (char *)&msg); > > >> > > >> -printf("calling write task =

Re: [PATCH] cpukit/include/dev/can: Disabled debug prints in CAN Framework

2022-11-29 Thread Prashanth S
> On 29/11/2022 05:57, Gedare Bloom wrote: > >> @@ -111,18 +113,18 @@ static void test_task(rtems_task_argument data) > >> > >> msg_size = ((char *)&msg.data[msg.len] - (char *)&msg); > >> > >> -printf("calling write task = %u\n", task_num); > >> +CAN_DEBUG("calling write task =

Re: [PATCH] cpukit/include/dev/can: Disabled debug prints in CAN Framework

2022-11-29 Thread Prashanth S
>On Mon, Nov 28, 2022 at 8:46 PM Prashanth S wrote: >> >> --- >> cpukit/include/dev/can/can.h | 2 +- >> testsuites/libtests/can01/init.c | 14 -- >> 2 files changed, 9 insertions(+), 7 deletions(-) >> >> diff --git a/cpukit/include/dev/can/can.h b/cpukit/include/dev/can/ca

Re: [PATCH] cpukit/include/dev/can: Disabled debug prints in CAN Framework

2022-11-28 Thread Sebastian Huber
On 29/11/2022 05:57, Gedare Bloom wrote: @@ -111,18 +113,18 @@ static void test_task(rtems_task_argument data) msg_size = ((char *)&msg.data[msg.len] - (char *)&msg); -printf("calling write task = %u\n", task_num); +CAN_DEBUG("calling write task = %u\n", task_num); The general

Re: [PATCH] cpukit/include/dev/can: Disabled debug prints in CAN Framework

2022-11-28 Thread Gedare Bloom
Hi Prashanth, On Mon, Nov 28, 2022 at 8:46 PM Prashanth S wrote: > > --- > cpukit/include/dev/can/can.h | 2 +- > testsuites/libtests/can01/init.c | 14 -- > 2 files changed, 9 insertions(+), 7 deletions(-) > > diff --git a/cpukit/include/dev/can/can.h b/cpukit/include/dev/can/c

[PATCH] cpukit/include/dev/can: Disabled debug prints in CAN Framework

2022-11-28 Thread Prashanth S
--- cpukit/include/dev/can/can.h | 2 +- testsuites/libtests/can01/init.c | 14 -- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/cpukit/include/dev/can/can.h b/cpukit/include/dev/can/can.h index 9e55395039..27afd00088 100644 --- a/cpukit/include/dev/can/can.h +++