Re: [Bugfix rtems-lwip 4/4] Fix crash due to link_detect_thread

2024-04-02 Thread Bernd Moessner
ive > and properly wrapped in the __rtems__ check. The addition of thread startup > at the end should also be wrapped in !NO_SYS. > > Kinsey > > On Sun, Mar 31, 2024 at 5:49 PM Bernd Moessner > wrote: > >> Within xemac_add, the link_detect_thread is set up before the et

[Bugfix rtems-lwip 4/4] Fix crash due to link_detect_thread

2024-03-31 Thread Bernd Moessner
Within xemac_add, the link_detect_thread is set up before the ethernet interface is configured and all data structures have been set up correctly. The steps within xemac_add are basically: 1) Set up link_detect_thread 2) Initialize the interface 3) Set up the link speed / start autonegotiation 4) W

[Bugfix rtems-lwip 3/4] Correct the task prio of link_detect_thread

2024-03-31 Thread Bernd Moessner
On my side, the link_detect_thread never gets to running state. I assume that the issues with the FreeRTOS tick rate and delay definitions have never been observed as the associated thread was never running / no one requied it to run. Previously, the link_detect_thread was set to RTEMS_MAXIMUM_PRIO

[Bugfix rtems-lwip 2/4] Fix definition of vTaskDelay(x)

2024-03-31 Thread Bernd Moessner
FreeRTOS's vTaskDelay(x) is the FreeRTOS equivalent to rtems_task_wake_after(x), it suspends a task for x Ticks. The previously used sys_arch_delay(x) would add x/10 before passing it to rtems_task_wake_after. Due to the fact that portTICK_RATE_MS was set to wrong value the previous impl always cal

[Bugfix rtems-lwip 1/4] Fix definition of portTICK_RATE_MS

2024-03-31 Thread Bernd Moessner
The FreeRTOS define portTICK_RATE_MS must represent the time in ms between two system ticks. --- rtemslwip/xilinx/xlwipopts.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rtemslwip/xilinx/xlwipopts.h b/rtemslwip/xilinx/xlwipopts.h index d915c3c..23b942f 100644 --- a/rtemslwi

[Bugfix rtems-lwip 0/4] XILINX Link detect issues

2024-03-31 Thread Bernd Moessner
been set up correctly. Even if the link detect thread would become running - it would wake up too often (every tick, instead of every second). Bernd Moessner (4): Fix definition of portTICK_RATE_MS Fix definition of vTaskDelay(x) Correct the task prio of link_detect_thread Fix crash due to

Re: Xilinx header files installed by BSP

2024-03-25 Thread Bernd Moessner
On 25.03.2024 13:26, Sebastian Huber wrote: Hello, the BSPs for the Xilinx Zynq/ZynqMP/Versal platforms use code from Xilinx. They also install some header files from Xilinx in the top-level include directory of the BSP, for example: sleep.h  xbasic_types.h  xil_assert.h  xil_cache.h xil_ex

Re: Latest toolchain throws error when including newlib's regex.h

2024-01-20 Thread Bernd Moessner
On 20.01.2024 16:49, Sebastian Huber wrote: On 19.01.24 21:31, Bernd Moessner wrote: Dear all, I'm currently encountering an issue with the latest RTEMS toolchain (GCC 13) while attempting to build GoogleTest. Simple example, test.cpp with the following content: #include #in

Latest toolchain throws error when including newlib's regex.h

2024-01-19 Thread Bernd Moessner
Dear all, I'm currently encountering an issue with the latest RTEMS toolchain (GCC 13) while attempting to build GoogleTest. Simple example, test.cpp with the following content: #include #include compiled with ~/quick-start/install/tools/toolchain-arm/bin/arm-rtems6-g++ test.cpp gives me

Re: [PATCH rtems] Include support files also for Zynq7000

2024-01-05 Thread Bernd Moessner
On 05.01.2024 18:54, Kinsey Moore wrote: I assume this is to support the Zynq7000 under rtems-lwip since it would need those installed headers. This looks good to me. Kinsey On Sat, Dec 23, 2023 at 7:00 AM wrote: From: Bernd Moessner ---  spec/build/bsps/arm/xilinx-zynq

Re: [PATCH rtems-lwip - v1 02/11] FIX: add library search path to allow lwip being installed aside the RTEMS installation

2024-01-04 Thread Bernd Moessner
On 04.01.2024 23:26, Kinsey Moore wrote: On Thu, Jan 4, 2024 at 4:03 PM Bernd Moessner wrote: On 04.01.2024 22:33, Kinsey Moore wrote: > This looks like it should be fine for now to enable installing into > somewhere that isn't the installed BSP directory.

Re: [PATCH rtems-lwip - v1 06/11] FIX: printf format spec compiler warning due to uintptr having 64bits on 64bit machines

2024-01-04 Thread Bernd Moessner
On 04.01.2024 23:22, Kinsey Moore wrote: Comments inline. On Thu, Jan 4, 2024 at 12:54 PM wrote: From: Bernd Moessner ---  .../lwip211/src/contrib/ports/xilinx/netif/xadapter.c     | 3 ++-  1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/embeddedsw

Re: [PATCH rtems6 - v1 07/16] Flashdev: Refactor write_block_size and add function to dergister flashdev

2024-01-04 Thread Bernd Moessner
On 04.01.2024 20:05, Kinsey Moore wrote: A few comments inline. On Thu, Jan 4, 2024 at 12:35 PM wrote: From: Bernd Moessner ---  cpukit/dev/flash/flashdev.c                   |  71 --  cpukit/include/dev/flash/flashdev.h           |  22 +-  cpukit/libmisc/shell

Re: [PATCH rtems-lwip - v1 04/11] FIX: warning variable might be used without initialization

2024-01-04 Thread Bernd Moessner
an 4, 2024 at 12:54 PM wrote: From: Bernd Moessner ---  rtemslwip/common/sys_arch.c | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rtemslwip/common/sys_arch.c b/rtemslwip/common/sys_arch.c index 2651c9c..b97404c 100644 --- a/rtemslwip/common/

Re: [PATCH rtems-lwip - v1 02/11] FIX: add library search path to allow lwip being installed aside the RTEMS installation

2024-01-04 Thread Bernd Moessner
n the configure line using --rtems=. Kinsey On Thu, Jan 4, 2024 at 12:55 PM wrote: From: Bernd Moessner ---  lwip.py | 7 ---  1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lwip.py b/lwip.py index bd743a1..65f1ead 100644 --- a/lwip.py +++ b/lw

Re: [PATCH rtems6 - v1 06/16] Flashdev: Make mutex name more generic

2024-01-04 Thread Bernd Moessner
On 04.01.2024 19:55, Kinsey Moore wrote: On Thu, Jan 4, 2024 at 12:35 PM wrote: From: Bernd Moessner ---  cpukit/dev/flash/flashdev.c | 5 -  1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cpukit/dev/flash/flashdev.c b/cpukit/dev/flash/flashdev.c

Re: [PATCH rtems6 - v1 00/16] Overwork flashdev - V1

2024-01-04 Thread Bernd Moessner
On 04.01.2024 20:40, Kinsey Moore wrote: On Thu, Jan 4, 2024 at 12:34 PM wrote: From: Bernd Moessner Dear all, as outlined in https://devel.rtems.org/ticket/4981 I`d like to overwork the flashdev API. The provided patch series should at least serve as a fundament for the

Re: [PATCH rtems6 - v1 05/16] FIX: Add missing default case

2024-01-04 Thread Bernd Moessner
default case ? On 04.01.2024 19:48, Kinsey Moore wrote: All of the patches here need an issue reference. Beyond that, this patch is good to go in. I'm still reviewing the remainder of the set and I'll leave the renaming discussion to Aaron. Kinsey On Thu, Jan 4, 2024 at 12:35 PM w

Re: [rtems-lwip] Switch submodule protocol to https to allow use in restricted network environments

2023-12-23 Thread Bernd Moessner
Sry, the patch contains a wrong url. Will provide an updated version next week. schrieb am Sa., 23. Dez. 2023, 09:36: > From: Bernd Moessner > > --- > .gitmodules | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.gitmodules b/.gitmodules >

[PATCH v3 rtems master 3/3] ZYNQ7000: Add support PYNQ, PicoZed, MicroZed, ZYBO and ZYBO Z7

2023-11-21 Thread Bernd Moessner
This patch adds basic support for the following boards: xilinx_zynq_pynq - PYNQ Z1 / Z2 xilinx_zynq_microzed - MicroZed 7010 / 7020 xilinx_zynq_picozed - PicoZed 7010 / 7015 / 7020 / 7030 xilinx_zynq_zybo - ZYBO xilinx_zynq_zybo_z7 - ZYBO Z7-10 / Z7-20 N.b. Arty Z7-20 is basically a PYNQ Z1 - dif

[PATCH v3 rtems master 2/3] Fix zedboard clock settings

2023-11-21 Thread Bernd Moessner
From: Bernd Moessner --- spec/build/bsps/arm/xilinx-zynq/opta9periphclk.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/spec/build/bsps/arm/xilinx-zynq/opta9periphclk.yml b/spec/build/bsps/arm/xilinx-zynq/opta9periphclk.yml index fdee4c0568..ad34974665 100644 --- a

[PATCH v3 rtems master 1/3] Fix add missing clock settings for zc706

2023-11-21 Thread Bernd Moessner
From: Bernd Moessner --- spec/build/bsps/arm/xilinx-zynq/opta9periphclk.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/spec/build/bsps/arm/xilinx-zynq/opta9periphclk.yml b/spec/build/bsps/arm/xilinx-zynq/opta9periphclk.yml index 7233f73d5a..fdee4c0568 100644 --- a