On 04.01.2024 23:22, Kinsey Moore wrote:
Comments inline.
On Thu, Jan 4, 2024 at 12:54 PM <berndmoessne...@gmail.com> wrote:
From: Bernd Moessner <berndmoessne...@gmail.com>
---
.../lwip211/src/contrib/ports/xilinx/netif/xadapter.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
a/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xadapter.c
b/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xadapter.c
index 9594ff5..98e7a8e 100644
---
a/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xadapter.c
+++
b/embeddedsw/ThirdParty/sw_services/lwip211/src/contrib/ports/xilinx/netif/xadapter.c
@@ -184,8 +184,9 @@ xemac_add(struct netif *netif,
#endif
#endif
default:
- xil_printf("unable to determine
type of EMAC with baseaddress 0x%08x\r\n",
+ xil_printf("unable to determine
type of EMAC with baseaddress %" PRIXPTR,
mac_baseaddr);
+ xil_printf("\r\b");
The second line has a \b instead of a \n.
Beyond that typo, changes in third-party sources in rtems-lwIP are
treated just like they are in rtems-libbsd. Changes are additive only
and gated by __rtems__. So if you wanted to change line A to line B,
you'd have this construct:
#ifdef __rtems__
line B
#else
line A
#endif
Okay, if fixed it in a later patch. I`ll merge the patches and add the
gates. I guess there are some other places where I ll have to add the
gates. I have reported one of the issues already to xilinx. I`ll report
all of them to Xilinx and until they've patched their sources we need to
stick to the gates.
_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel
