Re: libdl documentation?

2023-10-19 Thread Sebastian Huber
Hello Chris, thanks for the information. I will try to figure out if I can get the 64-bit powerpc ELFv2 support working. -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax: +49-89-18 94

Re: [PATCH v2 3/9] bsps/leon3: Make GPTIMER fall back mandatory

2023-10-19 Thread Martin Åberg
Hello Sebastian, On 2023-10-19 15:44, Sebastian Huber wrote: On 19.10.23 12:22, Martin Åberg wrote: On 2023-10-13 13:00, Sebastian Huber wrote >> LEON3_Timer_Regs is probed in amba.c. There is a link time option to set GPTIMER core index (leon3_timer_core_index). Instances could have unique G

Re: device tree loading from uboot.

2023-10-19 Thread Kinsey Moore
On Mon, Oct 16, 2023 at 11:19 AM Sam Price wrote: > i want to test the device tree loading stuff in qemu. > I don't see a way to set the r5 register on startup via command line in > qemu. > > > void bsp_fdt_copy(const void *src) > { > const volatile uint32_t *s = (const uint32_t *) src; > > im

Re: [PATCH v2 3/9] bsps/leon3: Make GPTIMER fall back mandatory

2023-10-19 Thread Sebastian Huber
Hello Martin, thanks for the review. On 19.10.23 12:22, Martin Åberg wrote: On 2023-10-13 13:00, Sebastian Huber wrote: Hello Martin, On 13.10.23 12:09, Martin Åberg wrote: What are the implications when using RTEMS_MULTIPROCESSING together with "use_gptimer"? In bsps/sparc/leon3/includ

Re: [PATCH v1 3/4] aarch64/versal: Port JFFS2 GQSPI NOR Driver from Zynqmp

2023-10-19 Thread Kinsey Moore
It looks like this is an older version of the JFFS2 XQspiPsu adapter. The only real difference other than this being dated is the IRQ used. I'd rather that be factored out and make the existing code shared. Beyond that, both this and the ZynqMP version it was pulled from would be obviated by a gene

Re: [PATCH v1 4/4] libmisc/shell: Improve print messages for flashdev command

2023-10-19 Thread Kinsey Moore
This patch looks good. On Thu, Oct 19, 2023 at 12:43 AM wrote: > From: Aaron Nyholm > > --- > cpukit/libmisc/shell/main_flashdev.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/cpukit/libmisc/shell/main_flashdev.c > b/cpukit/libmisc/shell/main_flashdev.c

Re: [PATCH v1 2/4] aarch64/versal: Add flash wrapper for Xilinx GQSPI

2023-10-19 Thread Kinsey Moore
Comments inline below. On Thu, Oct 19, 2023 at 12:43 AM wrote: > From: Aaron Nyholm > > --- > .../dev/spi/versal_xqspi_flash.c | 296 ++ > bsps/aarch64/xilinx-versal/include/bsp/irq.h | 1 + > .../include/dev/spi/versal_xqspi_flash.h | 49 +++ > bsps/inclu

Re: [PATCH v1 1/4] bsps: Fix xqspipsu build issues on versal

2023-10-19 Thread Kinsey Moore
Files imported from Xilinx's embeddedsw repository into RTEMS are treated much like imports in libbsd such that modifications should be purely additive and gated by "#ifdef __rtems__" to maintain the ability to update them easily. A better way to accomplish the goal of this patch would be to defin

Re: [PATCH v2 9/9] bsps/leon3: Use DSU time tag for GR712RC

2023-10-19 Thread Martin Åberg
OK, but please see the comment below. On 2023-09-21 17:19, Sebastian Huber wrote: Update #4954. --- bsps/sparc/leon3/start/cpucounter.c| 62 -- spec/build/bsps/sparc/leon3/grp.yml| 2 + spec/build/bsps/sparc/leon3/optdsubase.yml | 24 + 3 files c

Re: [PATCH v2 8/9] bsps/leon3: leon3_counter_use_irqamp_timestamp()

2023-10-19 Thread Martin Åberg
OK On 2023-09-21 17:19, Sebastian Huber wrote: Simplify leon3_counter_use_irqamp_timestamp(). Update #4954. --- bsps/sparc/leon3/start/cpucounter.c | 4 1 file changed, 4 deletions(-) -- Best regards, Martin Åberg Software Engineer Frontgrade Gaisler martin.ab...@gaisler.com Front

Re: [PATCH v2 7/9] bsps/leon3: Statically initialize get timecount

2023-10-19 Thread Martin Åberg
OK On 2023-09-21 17:19, Sebastian Huber wrote: Update #4954. --- bsps/sparc/leon3/include/bsp/leon3.h | 2 +- bsps/sparc/leon3/start/cpucounter.c | 30 +--- 2 files changed, 19 insertions(+), 13 deletions(-) -- Best regards, Martin Åberg Software Engineer Front

Re: [PATCH v2 6/9] bsps/leon3: Move code blocks

2023-10-19 Thread Martin Åberg
OK On 2023-09-21 17:19, Sebastian Huber wrote: Move code blocks to simplify C preprocessor usage. Update #4954. --- bsps/sparc/leon3/start/cpucounter.c | 110 ++-- 1 file changed, 57 insertions(+), 53 deletions(-) -- Best regards, Martin Åberg Software Engineer F

Re: [PATCH v2 5/9] bsps/leon3: Use custom CPU counter implementation

2023-10-19 Thread Martin Åberg
OK On 2023-09-21 17:19, Sebastian Huber wrote: Merge the timecounter and CPU counter support for the leon3 BSP family. Remove now unused functions from the CPU counter support of the erc32 and leon3 BSPs. Update #4954. --- bsps/sparc/include/bsp/sparc-counter.h | 12 -- bsps/sparc/leon

Re: [PATCH v2 4/9] bsps/leon3: Simplify clock and CPU counter

2023-10-19 Thread Martin Åberg
OK On 2023-09-21 17:19, Sebastian Huber wrote: Share the timecounter instance between the clock and the CPU counter. This greatly simplifies the clock driver since we have to do the device selection only in one place, the CPU counter support. Update #4954. --- bsps/sparc/leon3/clock/ckinit.c

Re: [PATCH v2 2/9] sparc: Move CPU counter implementation

2023-10-19 Thread Martin Åberg
OK On 2023-09-21 17:19, Sebastian Huber wrote: Enable a BSP-specific CPU counter implementation. Update #4954. --- bsps/sparc/erc32/clock/ckinit.c | 8 +-- .../sparc/include/bsp/sparc-counter.h | 64 +-- bsps/sparc/leon2/clock/ckinit.c |

Re: [PATCH v2 1/9] bsps/leon3: Optional IRQ(A)MP timestamp support

2023-10-19 Thread Martin Åberg
OK On 2023-09-21 17:19, Sebastian Huber wrote: This is necessary to run the tests on SIS with profiling enabled. Update #4954. --- bsps/include/bsp/fatal.h| 1 - bsps/sparc/leon3/clock/ckinit.c | 6 ++ 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/bsps/include/b

Re: [PATCH v2 3/9] bsps/leon3: Make GPTIMER fall back mandatory

2023-10-19 Thread Martin Åberg
Hello Sebastian, Thank you for the clarifications. We have discussed this internally, and there were two main discussion points: 1. Users of custom GRLIB+LEON3 systems (FPGA/ASIC) may be affected by the RTEMS hardware requirement change of needing one more subtimer. 2. The application will hav