Re: [PATCH] bsp/clock_isr: merge the FAST_IDLE clock and normal clock driver

Hello Zhongjie Zhu, could you please explain in the commit message which problem is solved by the patch and why the change is necessary? -- embedded brains GmbH Herr Sebastian HUBER Dornierstr. 4 82178 Puchheim Germany email: sebastian.hu...@embedded-brains.de phone: +49-89-18 94 741 - 16 fax:

[PATCH] bsp/clock_isr: merge the FAST_IDLE clock and normal clock driver

From: Zhongjie Zhu --- bsps/shared/dev/clock/clockimpl.h | 105 +++--- 1 file changed, 51 insertions(+), 54 deletions(-) diff --git a/bsps/shared/dev/clock/clockimpl.h b/bsps/shared/dev/clock/clockimpl.h index ccf6d3ab60..0a7f382070 100644 --- a/bsps/shared/dev/clock/cl

Re: [PATCH] risc-v: Resurrect RISCV_ENABLE_HTIF_SUPPORT

LGTM. We also need to update the docs accordingly. On Wed, 11 Jan 2023 at 07:45, Sebastian Huber wrote: > > Low-end configurations may want to have the HTIF support removed. > Enable the option by default. Fix formatting. Fix node validity > checks. > > Updates #4779. > --- > bsps/riscv/noel/i

[PATCH 18/18] jffs2: Update baseline version to Linux v6.1

--- cpukit/libfs/src/jffs2/VERSION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libfs/src/jffs2/VERSION b/cpukit/libfs/src/jffs2/VERSION index b13bed5750..b2d9e654bf 100644 --- a/cpukit/libfs/src/jffs2/VERSION +++ b/cpukit/libfs/src/jffs2/VERSION @@ -3,7 +3,7 @@ This

[PATCH 17/18] treewide: uapi: Replace zero-length arrays with flexible-array members

From: "Gustavo A. R. Silva" There is a regular need in the kernel to provide a way to declare having a dynamically sized set of trailing elements in a structure. Kernel code should always use “flexible array members”[1] for these cases. The older style of one-element or zero-length arrays should

[PATCH 14/18] jffs2: Pass the file pointer to jffs2_do_readpage_unlock()

From: "Matthew Wilcox (Oracle)" In preparation for unifying the read_cache_page() and read_folio() implementations, make jffs2_do_readpage_unlock() get the inode from the page instead of passing it in from read_cache_page(). Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Christoph Hellwig

[PATCH 13/18] jffs2: fix memory leak in jffs2_scan_medium

From: Baokun Li If an error is returned in jffs2_scan_eraseblock() and some memory has been added to the jffs2_summary *s, we can observe the following kmemleak report: unreferenced object 0x88812b889c40 (size 64): comm "mount", pid 692, jiffies

[PATCH 08/18] jffs2: Fix kasan slab-out-of-bounds problem

From: lizhe KASAN report a slab-out-of-bounds problem. The logs are listed below. It is because in function jffs2_scan_dirent_node, we alloc "checkedlen+1" bytes for fd->name and we check crc with length rd->nsize. If checkedlen is less than rd->nsize, it will cause the slab-out-of-bounds problem

[PATCH 15/18] fs: Change the type of filler_t

From: "Matthew Wilcox (Oracle)" By making filler_t the same as read_folio, we can use the same function for both in gfs2. We can push the use of folios down one more level in jffs2 and nfs. We also increase type safety for future users of the various read_cache_page() family of functions by for

[PATCH 16/18] jffs2: Use kzalloc instead of kmalloc/memset

From: Haowen Bai Use kzalloc rather than duplicating its implementation, which makes code simple and easy to understand. Signed-off-by: Haowen Bai [rw: Fixed printk string] Signed-off-by: Richard Weinberger --- cpukit/libfs/src/jffs2/src/erase.c | 6 ++ 1 file changed, 2 insertions(+), 4

[PATCH 07/18] jffs2: check the validity of dstlen in jffs2_zlib_compress()

From: Yang Yang KASAN reports a BUG when download file in jffs2 filesystem.It is because when dstlen == 1, cpage_out will write array out of bounds. Actually, data will not be compressed in jffs2_zlib_compress() if data's length less than 4. [ 393.799778] BUG: KASAN: slab-out-of-bounds in jffs

[PATCH 06/18] fs: make helpers idmap mount aware

From: Christian Brauner Extend some inode methods with an additional user namespace argument. A filesystem that is aware of idmapped mounts will receive the user namespace the mount has been marked with. This can be used for additional permission checking and also to enable filesystems to transla

[PATCH 09/18] jffs2: avoid Wempty-body warnings

From: Arnd Bergmann Building with W=1 shows a few warnings for empty macros: fs/jffs2/scan.c: In function 'jffs2_scan_xattr_node': fs/jffs2/scan.c:378:66: error: suggest braces around empty body in an 'if' statement [-Werror=empty-body] 378 | jffs2_sum_add_xattr_mem(s, rx, ofs

[PATCH 11/18] fs/jffs2: fix comments mentioning i_mutex

From: hongnanli inode->i_mutex has been replaced with inode->i_rwsem long ago. Fix comments still mentioning i_mutex. Signed-off-by: hongnanli Signed-off-by: Richard Weinberger --- cpukit/libfs/src/jffs2/src/jffs2_fs_i.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH 12/18] jffs2: fix memory leak in jffs2_do_mount_fs

From: Baokun Li If jffs2_build_filesystem() in jffs2_do_mount_fs() returns an error, we can observe the following kmemleak report: unreferenced object 0x88811b25a640 (size 64): comm "mount", pid 691, jiffies 4294957728 (age 71.952s) hex dump (

[PATCH 05/18] jffs2: remove trailing semicolon in macro definition

From: Tom Rix The macro use will already have a semicolon. Signed-off-by: Tom Rix Signed-off-by: Richard Weinberger --- cpukit/libfs/src/jffs2/src/nodelist.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpukit/libfs/src/jffs2/src/nodelist.h b/cpukit/libfs/src/jffs2

[PATCH 10/18] vfs: add rcu argument to ->get_acl() callback

From: Miklos Szeredi Add a rcu argument to the ->get_acl() callback to allow get_cached_acl_rcu() to call the ->get_acl() method in the next patch. Signed-off-by: Miklos Szeredi --- cpukit/libfs/src/jffs2/src/acl.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cpukit/libf

[PATCH 02/18] jffs2: Fix if/else empty body warnings

From: Randy Dunlap When debug (print) macros are not enabled, change them to use the no_printk() macro instead of . This fixes gcc warnings when -Wextra is used: ../cpukit/libfs/src/jffs2/src/nodelist.c:255:37: warning: suggest braces around empty body in an ‘else’ statement [-Wempty-body] ../c

[PATCH 04/18] jffs2: Allow setting rp_size to zero during remounting

From: lizhe Set rp_size to zero will be ignore during remounting. The method to identify whether we input a remounting option of rp_size is to check if the rp_size input is zero. It can not work well if we pass "rp_size=0". This patch add a bool variable "set_rp_size" to fix this problem. Repo

[PATCH 03/18] jffs2: Fix GC exit abnormally

From: Zhe Li The log of this problem is: jffs2: Error garbage collecting node at 0x***! jffs2: No space for garbage collection. Aborting GC thread This is because GC believe that it do nothing, so it abort. After going over the image of jffs2, I find a scene that can trigger this problem stably

[PATCH 00/18] jffs2: Update baseline version to Linux v6.1

Arnd Bergmann (1): jffs2: avoid Wempty-body warnings Baokun Li (2): jffs2: fix memory leak in jffs2_do_mount_fs jffs2: fix memory leak in jffs2_scan_medium Christian Brauner (1): fs: make helpers idmap mount aware Gustavo A. R. Silva (1): treewide: uapi: Replace zero-length arrays with

[PATCH 01/18] jffs2: Add

A follow up patch uses no_printk(). --- cpukit/libfs/src/jffs2/include/linux/printk.h | 6 ++ 1 file changed, 6 insertions(+) create mode 100644 cpukit/libfs/src/jffs2/include/linux/printk.h diff --git a/cpukit/libfs/src/jffs2/include/linux/printk.h b/cpukit/libfs/src/jffs2/include/linux/pr

Re: [PATCH 1/4] cpukit/include/dev/can: Added debug print configuration under RTEMS_CAN_DEBUG macro.

Hi All, This is a reminder for review requests for the patches to CAN Framework changes based on review comments. Regards Prashanth S On Fri, 16 Dec 2022 at 18:58, Prashanth S wrote: > --- > cpukit/include/dev/can/can.h | 27 +-- > 1 file changed, 21 insertions(+), 6 d