From: Haowen Bai <baihao...@meizu.com>

Use kzalloc rather than duplicating its implementation, which
makes code simple and easy to understand.

Signed-off-by: Haowen Bai <baihao...@meizu.com>
[rw: Fixed printk string]
Signed-off-by: Richard Weinberger <rich...@nod.at>
---
 cpukit/libfs/src/jffs2/src/erase.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/cpukit/libfs/src/jffs2/src/erase.c 
b/cpukit/libfs/src/jffs2/src/erase.c
index e8ab569462..6966ed9b0a 100644
--- a/cpukit/libfs/src/jffs2/src/erase.c
+++ b/cpukit/libfs/src/jffs2/src/erase.c
@@ -45,9 +45,9 @@ static void jffs2_erase_block(struct jffs2_sb_info *c,
        jffs2_dbg(1, "%s(): erase block %#08x (range %#08x-%#08x)\n",
                  __func__,
                  jeb->offset, jeb->offset, jeb->offset + c->sector_size);
-       instr = kmalloc(sizeof(struct erase_info), GFP_KERNEL);
+       instr = kzalloc(sizeof(struct erase_info), GFP_KERNEL);
        if (!instr) {
-               pr_warn("kmalloc for struct erase_info in jffs2_erase_block 
failed. Refiling block for later\n");
+               pr_warn("kzalloc for struct erase_info in jffs2_erase_block 
failed. Refiling block for later\n");
                mutex_lock(&c->erase_free_sem);
                spin_lock(&c->erase_completion_lock);
                list_move(&jeb->list, &c->erase_pending_list);
@@ -59,8 +59,6 @@ static void jffs2_erase_block(struct jffs2_sb_info *c,
                return;
        }
 
-       memset(instr, 0, sizeof(*instr));
-
        instr->addr = jeb->offset;
        instr->len = c->sector_size;
 
-- 
2.35.3

_______________________________________________
devel mailing list
devel@rtems.org
http://lists.rtems.org/mailman/listinfo/devel

Reply via email to