Re: [PATCH 1/5] SD Card : Initial Port of DMA Controller

2016-08-21 Thread Sebastian Huber
Please add the import versions of the files to libbsd.txt if they differ from the default FreeBSD version. On 22/08/16 05:57, Mudit Jain wrote: This is the initial port of the DMA controller from the libbsd using freebsd-to-rtems.py This change is dependent on the interrupt handler in the Main

Re: [PATCH 4/5] SD card : Updated the Kernel Space Files

2016-08-21 Thread Sebastian Huber
Why are there so many changes in this file. Including white space changes. What is the origin of these changes? On 22/08/16 05:57, Mudit Jain wrote: The previous files had both the board specific functions as well as the common functions. --- freebsd/sys/dev/sdhci/sdhci.c | 3284 +

Re: [PATCH v2 1/6] Imported files for driver: bcm283x_dwcotg

2016-08-21 Thread Sebastian Huber
Sorry, for being so pedantic, but it will be probably me who updates the libbsd with about 800 files to next FreeBSD versions. Please go through your complete patch series again and fix all places that don't follow the guidelines and my mail comments. It looks better now, but there are still so

Re: [PATCH 1/2] RTEMS Source Builder changes for lpc32xx VFP support

2016-08-21 Thread Sebastian Huber
On 19/08/16 17:18, Kirspel, Kevin wrote: I built GCC with the hard abi. The software ran fine but I see a performance hit with the hard abi. ABI:Test Execution Time (ms) soft1358 softfp 96 hard109 I don't know why the hard is slower than the softfp. Here was my test code. Whic

Re: [PATCH 2/2] RTEMS changes for lpc32xx VFP support

2016-08-21 Thread Sebastian Huber
The mulilib derived defines must correspond to a GCC multilib. The multilibs should target a certain instruction set and not a particular processor. So, if something is very processor specific outside the cpukit, then maybe a bsp.h or bspopts.h provided define is better. On 19/08/16 15:29, Kir

[PATCH v2 6/6] SD card : Added basic test suite

2016-08-21 Thread Mudit Jain
--- libbsd.py| 1 + libbsd_waf.py| 10 +++ testsuite/sdhci01/demo-shell-block-devices.h | 32 + testsuite/sdhci01/demo-shell-minimal.h | 37 ++ testsuite/sdhci01/demo-shell.h | 44

[PATCH v2 5/6] SD card : Changes for SD card driver

2016-08-21 Thread Mudit Jain
--- freebsd/sys/arm/broadcom/bcm2835/bcm2835_sdhci.c | 21 + freebsd/sys/dev/mmc/mmc.c| 2 +- freebsd/sys/dev/sdhci/sdhci.c| 6 ++ freebsd/sys/dev/sdhci/sdhci.h| 2 +- rtemsbsd/include/bsp/nexus-devices.h

[PATCH v2 3/6] SD Card : Initial port of SD driver

2016-08-21 Thread Mudit Jain
This commit adds the files required for porting the SD card driver namely bcm_sdhci.c, sdhci_if.h, sdhci_if.c --- freebsd/sys/arm/broadcom/bcm2835/bcm2835_sdhci.c | 677 +++ libbsd.py| 2 + libbsd_waf.py

[PATCH v2 4/6] SD card : Updated the Kernel Space Files

2016-08-21 Thread Mudit Jain
The previous files had both the board specific functions as well as the common functions. --- freebsd/sys/dev/sdhci/sdhci.c | 3284 +++-- freebsd/sys/dev/sdhci/sdhci.h | 473 -- 2 files changed, 1874 insertions(+), 1883 deletions(-) diff --git a/freebsd/sy

[PATCH v2 1/6] SD Card : Initial Port of DMA Controller

2016-08-21 Thread Mudit Jain
This is the initial port of the DMA controller from the libbsd using freebsd-to-rtems.py This change is dependent on the interrupt handler in the Mainline. --- freebsd/sys/arm/broadcom/bcm2835/bcm2835_dma.c | 768 +++ freebsd/sys/arm/broadcom/bcm2835/bcm2835_dma.h | 60 ++

[PATCH v2 2/6] SD card : DMA Driver : Changes over initial commit

2016-08-21 Thread Mudit Jain
Changes required for using the DMA controller for SD card. --- freebsd/sys/arm/broadcom/bcm2835/bcm2835_dma.c | 13 + rtemsbsd/include/bsp/nexus-devices.h | 20 2 files changed, 33 insertions(+) diff --git a/freebsd/sys/arm/broadcom/bcm2835/bcm2835_dma.c

[PATCH 2/5] SD card : DMA Driver : Changes over initial commit

2016-08-21 Thread Mudit Jain
Changes required for using the DMA controller for SD card. --- freebsd/sys/arm/broadcom/bcm2835/bcm2835_dma.c | 13 + rtemsbsd/include/bsp/nexus-devices.h | 20 2 files changed, 33 insertions(+) diff --git a/freebsd/sys/arm/broadcom/bcm2835/bcm2835_dma.c

[PATCH 1/5] SD Card : Initial Port of DMA Controller

2016-08-21 Thread Mudit Jain
This is the initial port of the DMA controller from the libbsd using freebsd-to-rtems.py This change is dependent on the interrupt handler in the Mainline. --- freebsd/sys/arm/broadcom/bcm2835/bcm2835_dma.c | 768 +++ freebsd/sys/arm/broadcom/bcm2835/bcm2835_dma.h | 60 ++

[PATCH 5/5] SD card : Changes for SD card driver

2016-08-21 Thread Mudit Jain
--- freebsd/sys/arm/broadcom/bcm2835/bcm2835_sdhci.c | 21 + freebsd/sys/dev/mmc/mmc.c| 2 +- freebsd/sys/dev/sdhci/sdhci.c| 6 ++ freebsd/sys/dev/sdhci/sdhci.h| 2 +- rtemsbsd/include/bsp/nexus-devices.h

[PATCH 4/5] SD card : Updated the Kernel Space Files

2016-08-21 Thread Mudit Jain
The previous files had both the board specific functions as well as the common functions. --- freebsd/sys/dev/sdhci/sdhci.c | 3284 +++-- freebsd/sys/dev/sdhci/sdhci.h | 473 -- 2 files changed, 1874 insertions(+), 1883 deletions(-) diff --git a/freebsd/sy

[PATCH 3/5] SD Card : Initial port of SD driver

2016-08-21 Thread Mudit Jain
This commit adds the files required for porting the SD card driver namely bcm_sdhci.c, sdhci_if.h, sdhci_if.c --- freebsd/sys/arm/broadcom/bcm2835/bcm2835_sdhci.c | 677 +++ libbsd.py| 2 + libbsd_waf.py

Re: [PATCH] Added interrupt handler for DMA channel 0, 1 & 2

2016-08-21 Thread Pavel Pisa
Hello Mudit, please, send information what is RTEMS GIT revision are your changes based on. See comment below On Saturday 20 of August 2016 17:04:19 Mudit Jain wrote: > Added macros for DMA channels 0-12 > Added interrupt handlers for DMA 0, 1 & 2 > > The added IRQs are in accordance with the > B

Re: [PATCH 3/3] Mailbox : Adding functionality to get clock rate

2016-08-21 Thread Mudit Jain
Kindly ignore this. I have rebased and pushed all the changes in one patch. Thanks Mudit On Sat, Aug 20, 2016 at 6:55 PM, Mudit Jain wrote: > From: Mudit Jain > > --- > c/src/lib/libbsp/arm/raspberrypi/include/vc.h | 8 +++ > c/src/lib/libbsp/arm/raspberrypi/misc/vc.c | 26

Re: [PATCH 2/3] Mailbox : Added functionality to get power state

2016-08-21 Thread Mudit Jain
Kindly ignore this. I have rebased and pushed all the changes in one patch. Thanks Mudit On Sat, Aug 20, 2016 at 6:55 PM, Mudit Jain wrote: > From: Mudit Jain > > --- > c/src/lib/libbsp/arm/raspberrypi/include/vc.h | 2 ++ > c/src/lib/libbsp/arm/raspberrypi/misc/vc.c | 25 > +++