[dev-servo] Suggested code review workflow

2016-02-03 Thread Josh Matthews
Nikki asked for suggestions for how to review code, so here's my first attempt at writing down a general suggested workflow for reviewing Servo code: https://github.com/servo/servo/wiki/Code-review Please discuss/debate/make changes! I've tried to keep it high-level, rather than focus on spec

Re: [dev-servo] Suggested code review workflow

2016-02-03 Thread Boris Zbarsky
On 2/3/16 1:46 PM, Josh Matthews wrote: Nikki asked for suggestions for how to review code, so here's my first attempt at writing down a general suggested workflow for reviewing Servo code: https://github.com/servo/servo/wiki/Code-review Somewhere in there, one should read the commit messages

Re: [dev-servo] Suggested code review workflow

2016-02-03 Thread David Rajchenbach-Teller
Very good point. In Gecko-land, some teams use multi-line commit messages as documentation and my experience shows that it's very useful. Cheers, David On 03/02/16 20:21, Boris Zbarsky wrote: > On 2/3/16 1:46 PM, Josh Matthews wrote: >> Nikki asked for suggestions for how to review code, so here