Very good point. In Gecko-land, some teams use multi-line commit messages as documentation and my experience shows that it's very useful.
Cheers, David On 03/02/16 20:21, Boris Zbarsky wrote: > On 2/3/16 1:46 PM, Josh Matthews wrote: >> Nikki asked for suggestions for how to review code, so here's my first >> attempt at writing down a general suggested workflow for reviewing Servo >> code: >> >> https://github.com/servo/servo/wiki/Code-review > > Somewhere in there, one should read the commit messages too. Probably > before reading the code. And if it's not clear from the commit messages > what the goal of the code changes is, then they need fixing. > > -Boris > > _______________________________________________ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
