Re: [dev-servo] making features optional

2017-12-23 Thread Fabrice Desre
On 12/21/2017 09:24 PM, Enrico Weigelt, metux IT consult wrote: On 22.12.2017 05:57, Fabrice Desre wrote: I don't know yet how the binding generator is hooked up in the build > system, so I can't answer that. @all: anybody else could give us a hint ? I took a look, and currently the list

Re: [dev-servo] making features optional

2017-12-22 Thread Simon Sapin
On 21/12/17 20:12, google via dev-servo wrote: Does it only compile those modules that are actually imported ? In current Rust, the `mod` keyword is a module *declaration*. When used without a {…} block, it makes the compiler read a corresponding .rs file. `use` imports some names in the cur

Re: [dev-servo] making features optional

2017-12-21 Thread Fabrice Desre
On 12/21/2017 09:24 PM, Enrico Weigelt, metux IT consult via dev-servo wrote: Seems it's pretty unfinished yet. Maybe it effectively disables the feature (which a pref also would do), but IMHO most of the code is still in there. But my goals getting rid of everything I don't need/want. Again

Re: [dev-servo] making features optional

2017-12-21 Thread Enrico Weigelt, metux IT consult via dev-servo
On 22.12.2017 05:57, Fabrice Desre wrote: In components/servo/lib.rs, you didn't disable >> bluetooth_traits::BluetoothRequest. What about the references in the Navigator JSON object ?> > Indeed this is a quick hacked patch to unblock me on something else. > Absolutely not ready to be subm

Re: [dev-servo] making features optional

2017-12-21 Thread Fabrice Desre
On 12/21/2017 11:12 AM, google via dev-servo wrote: On 21.12.2017 06:20, Fabrice Desre wrote: Hi, I feature-gated the bluetooth support in  > https://github.com/fabricedesre/servo/commit/2afbaf365f6379eedf26e36a33e7cb38aba5c00a#diff-8c43e49d8f1af13938ed86125b97244c > > There are more changes

Re: [dev-servo] making features optional

2017-12-21 Thread google via dev-servo
On 21.12.2017 06:20, Fabrice Desre wrote: Hi, I feature-gated the bluetooth support in > https://github.com/fabricedesre/servo/commit/2afbaf365f6379eedf26e36a33e7cb38aba5c00a#diff-8c43e49d8f1af13938ed86125b97244c > > There are more changes that really needed because of rustfmt that ran > whe

Re: [dev-servo] making features optional

2017-12-20 Thread Fabrice Desre
On 12/20/2017 07:33 PM, google via dev-servo wrote: I feature-gated the bluetooth support in https://github.com/fabricedesre/servo/commit/2afbaf365f6379eedf26e36a33e7cb38aba5c00a#diff-8c43e49d8f1af13938ed86125b97244c There are more changes that really needed because of rustfmt that ran when I s