On 22.12.2017 05:57, Fabrice Desre wrote:
In components/servo/lib.rs, you didn't disable >> bluetooth_traits::BluetoothRequest.>>>> What about the references in
the Navigator JSON object ?> > Indeed this is a quick hacked patch to
unblock me on something else. > Absolutely not ready to be submitted in
any way.
Seems it's pretty unfinished yet. Maybe it effectively disables
the feature (which a pref also would do), but IMHO most of the code
is still in there.
But my goals getting rid of everything I don't need/want.
One thing that's bothering me is that these things seem to be a bit
tricky to decouple due to lack of forward declarations - in C/C++ we
could just use forward declarations everywhere we just need a pointer
to some struct/class and include the actual definition only where
we actually access it - in that case the allocator of some compiled-
out class could just be a NULL-returning dummy ...
Any idea how to solve this rust ?
I don't know yet how the binding generator is hooked up in the build > system,
so I can't answer that.
@all: anybody else could give us a hint ?
Does it only compile those modules that are actually imported ?
Yes, if you have:
#[cfg(feature = "some-api")]
mod some_api_impl;
then some_api_impl.rs will only be compiled when the feature is set.
Same with crates.
Okay. Is there any debug flag for listing which files are actually
compiled ? I'd like to verify that ...
Do they register themselves automatically ? Is that what #[dom_struct]
does ? Can we move these imports to a separate module, so we'd need
only #[cfg(...)] for that ?
That's possible, I haven't looked into that.
@all: maybe anybody else could give us more insight ?
bluetooth_traits is still compiled, yes. I think bluetooth is not
anymore since my issue was to not bring in the android impl that doesn't
work on my android-like-but-not-really platform.
Which platform exactly is that ?
well, good luck with that... compiling servo with less than 16G on a
64bits arch is a challenge. I honestly don't see the point of making
compiling on a 32bits host a priority.
I currently only have a 32bit environment, and don't like set up an
64bit container (already a little low of storage space :o)
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
i...@metux.net -- +49-151-27565287
_______________________________________________
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo
