On 02/13/2016 07:26 AM, Josh Matthews wrote:
On 2016-02-12 6:16 PM, Olaf Buddenhagen wrote:
Hi,
On Wed, Feb 03, 2016 at 02:21:46PM -0500, Boris Zbarsky wrote:
On 2/3/16 1:46 PM, Josh Matthews wrote:
https://github.com/servo/servo/wiki/Code-review
Somewhere in there, one should read the co
On 2016-02-12 6:16 PM, Olaf Buddenhagen wrote:
Hi,
On Wed, Feb 03, 2016 at 02:21:46PM -0500, Boris Zbarsky wrote:
On 2/3/16 1:46 PM, Josh Matthews wrote:
https://github.com/servo/servo/wiki/Code-review
Somewhere in there, one should read the commit messages too. Probably
before reading th
Hi,
On Wed, Feb 03, 2016 at 02:21:46PM -0500, Boris Zbarsky wrote:
> On 2/3/16 1:46 PM, Josh Matthews wrote:
> >https://github.com/servo/servo/wiki/Code-review
>
> Somewhere in there, one should read the commit messages too. Probably
> before reading the code. And if it's not clear from the co
Very good point. In Gecko-land, some teams use multi-line commit
messages as documentation and my experience shows that it's very useful.
Cheers,
David
On 03/02/16 20:21, Boris Zbarsky wrote:
> On 2/3/16 1:46 PM, Josh Matthews wrote:
>> Nikki asked for suggestions for how to review code, so here
On 2/3/16 1:46 PM, Josh Matthews wrote:
Nikki asked for suggestions for how to review code, so here's my first
attempt at writing down a general suggested workflow for reviewing Servo
code:
https://github.com/servo/servo/wiki/Code-review
Somewhere in there, one should read the commit messages
Nikki asked for suggestions for how to review code, so here's my first
attempt at writing down a general suggested workflow for reviewing Servo
code:
https://github.com/servo/servo/wiki/Code-review
Please discuss/debate/make changes! I've tried to keep it high-level,
rather than focus on spec
6 matches
Mail list logo
