Intent to Ship: and Link: rel=preload support on Nightly and Early Beta

2020-05-26 Thread Honza Bambas
** Summary ** "" HTML tag and "Link: rel=preload" HTTP response header are a web technology allowing web developers to tell the browser to early load and pre-cache resources that will be used by the currently loading web page, specifically scripts, stylesheets, images, fonts and fetch (for `fe

Re: Cookies are no longer stored by nsIHttpChannel?

2019-09-16 Thread Honza Bambas
This might be a cookie isolation, or something missing to recognize if the cookie storage is allowed for the channel.  Is the `userContextId` the same all the time? If yes, can you capture a log with nsHttp:5,cookie:5?  Checking browser console for errors may tell you something too. CC'ing Eh

Re: Authentication strategy for servers, which do not return a 401 on unauthenticated requests

2019-09-10 Thread Honza Bambas
There is no official or standardized way to "force" authentication, because this is really a non-standard thing you do. I would more suggest a login request path like "https://foo.com/login.php"; or whatever scripting is used, that would return 401 with the challenge response header. Authentic

Re: Authentication strategy for servers, which do not return a 401 on unauthenticated requests

2019-09-10 Thread Honza Bambas
On 2019-09-10 15:45, john.bieling--- via dev-platform wrote: Thanks for your reply. I do not want to manually add a `Authentication` request header, as I also do not know what methods are allowed without having seen the WWW-Authentication header (and just trying basic auth is not an option for

Re: Authentication strategy for servers, which do not return a 401 on unauthenticated requests

2019-09-10 Thread Honza Bambas
Hi, adding a custom `Authentication` request header is the right way to do this.  Not sure what you mean by "I want nsIHttpChannel to do all the auth stuff" when it doesn't know it has to authenticate to the site.  We need a 401 response to produce and cache `Authentication` request headers b

Re: Coding style: Naming parameters in lambda expressions

2019-09-06 Thread Honza Bambas
On 2019-09-05 23:14, Emilio Cobos Álvarez wrote: Yeah, let's not add a new prefix please. I don't like aFoo either, though it's everywhere so consistency is better than nothing :/. That being said, it shouldn't be hard to write some clang plugin or such that automatically renames function ar

Re: Shipped - MOZ_LOG_FILE filenames automatically appended `.moz_log` extension

2019-08-26 Thread Honza Bambas
Bug 1574882 has landed and will ship in Firefox 70.  Our XPCOM (MOZ_LOG driven) log files now all have .moz_log extension.  The extension cannot be changed. -hb- On 2019-08-19 18:59, Honza Bambas wrote: I'm about to land a patch that will automatically add `mozlog` extension to al

MOZ_LOG_FILE filename intended to be automatically and irrevocably appended `.mozlog` extension

2019-08-19 Thread Honza Bambas
I'm about to land a patch that will automatically add `mozlog` extension to all log files from all processes produced with MOZ_LOG/_FILE env vars, command line args or via about:networking#logging.  It **will not** be possible to remove that extension by setting custom extensions, like `MOZ_LOG

Re: [SOLVED] Please advise how run testing\xpcshell\selftest.py locally (on Windows)

2019-04-12 Thread Honza Bambas
./mach python-test testing/xpcshell/selftest.py -hb- On 2019-04-12 20:48, Honza Bambas wrote: After I installed all the necessary packages (mozinfo, mozunit, pytest, mozbuild, which, mach, mozversioncontrol) I'm getting: `mozbuild.base.BuildEnvironmentNotFoundException: Could not find Mo

Please advise how run testing\xpcshell\selftest.py locally (on Windows)

2019-04-12 Thread Honza Bambas
After I installed all the necessary packages (mozinfo, mozunit, pytest, mozbuild, which, mach, mozversioncontrol) I'm getting: `mozbuild.base.BuildEnvironmentNotFoundException: Could not find Mozilla source tree or build environment.` mozinfo.json is missing in my tree, here I got stuck. Thanks

Re: Creating a new mach command for adding tests

2019-04-02 Thread Honza Bambas
This sounds great!  One nit - could this be done also for unit (xpcshell) tests?  good examples are in netwerk/test/unit/ and unit_ipc/. Thanks! -hb- On 2019-04-01 20:54, Jared Hirsch wrote: This sounds great! I land features in the tree periodically, but infrequently enough to forget lots of l

Re: Improving our usage of Bugzilla

2019-03-12 Thread Honza Bambas
Damn you, reply-to field :)  Sorry for spam everyone!  Intended to Sylvestre only. -hb- On 2019-03-12 12:50, Honza Bambas wrote: Hi, replying privately, because I want to expose some crazy idea I had a long time and this seems like a good opportunity. I miss two things in bugzilla from the

Re: Improving our usage of Bugzilla

2019-03-12 Thread Honza Bambas
Hi, replying privately, because I want to expose some crazy idea I had a long time and this seems like a good opportunity. I miss two things in bugzilla from the developer point of view: - when I use it as a tool to look into the code's history (understand changes made in the past) - and be ab

Re: Dropping support for compiling with MSVC in the near future

2018-12-07 Thread Honza Bambas
On 2018-12-07 04:23, Nathan Froyd wrote: On Thu, Dec 6, 2018 at 6:10 PM Gijs Kruitbosch wrote: Can someone elaborate on what this means for debugging on Windows, and for our onboarding story on Windows? At least in terms of stepping through, examining variables, etc., clang-cl is on par with M

Re: The upcoming C/C++ coding style change

2018-11-29 Thread Honza Bambas
On 2018-11-29 17:49, Ehsan Akhgari wrote: > No, I didn't.  :-)  That's exactly what the hg-formatsource extension does for you, it reformats your local changes on the fly as the rebase is in progress, so you will get no collisions. \o/ No, those are old days and long gone, my friend.  We are

Re: The upcoming C/C++ coding style change

2018-11-29 Thread Honza Bambas
On 2018-11-29 17:12, Ehsan Akhgari wrote: On Thu, Nov 29, 2018 at 8:00 AM Boris Zbarsky wrote: On 11/29/18 7:38 AM, Sylvestre Ledru wrote: This extension will automatically rebase the local changes to avoid conflicts. Sylvestre, Will it also update mq patches, or just in-repo commits? I d

Re: nsIHttpChannel not trying to authenticate if presented BASIC and an unknown auth method

2018-11-20 Thread Honza Bambas
On 2018-11-20 15:38, john.bieling--- via dev-platform wrote: For me it would be interesting to understand, if you consider the header send by contacts.icloud.com to by invalid, even though it fully complies with the spec Our implementation reflects the reality we can see in the wild.  I beli

Re: nsIHttpChannel not trying to authenticate if presented BASIC and an unknown auth method

2018-11-20 Thread Honza Bambas
On 2018-11-20 10:31, john.bieling--- via dev-platform wrote: @Anne van Kesteren Solved that by checking getRequestHeader("Authorization") in case of 401 and if that is missing, I know nsIHttpChannel did not try to authenticate. First, I can confirm that we expect multiple authentication chall

Re: Windows launcher process enabled by default on Nightly

2018-09-27 Thread Honza Bambas
On 2018-09-27 17:19, Aaron Klotz wrote: * If you use Visual Studio, you may install the Child Process Debugging Power Tool [3] which, once configured, will make the VS debugger automagically attach to the launcher's child processes. I'm using "Spawned Process Catcher X" that works better, but

Re: Intent to implement: Early, experimental support for application/javascript+binast

2018-04-19 Thread Honza Bambas
On 2018-04-18 19:13, David Teller wrote: No plans yet, but it's a good idea. The only reason not to do this (that I can think of) is that we might prefer switching to the Bytecode Cache, which would probably give us even better speed ups. I understand that we can't use the Bytecode Cache for our

Re: Stylesheet wait timeout?

2017-08-31 Thread Honza Bambas
On 8/31/17 8:00 PM, Chris Peterson wrote: Maybe this is stylesheet delay is related to Context Driven Priority (CDP) project that changes how network requests are prioritized? https://bugzilla.mozilla.org/show_bug.cgi?id=CDP CSS preload requests (made by html parser when is hit) are left as

Mozilla Log Analyzer

2017-08-29 Thread Honza Bambas
tl;dr: if you need to analyze a log file (MOZ_LOG), you may want to make it easy with https://janbambas.cz/moz/logan/ Long version: have a 1TB log to dive into? Yeah.. been there :) So, couple months back I started to work on a log analyzer that would make filtering and reading large, specif

Re: Retaining Nightly users after disabling of legacy extensions

2017-08-14 Thread Honza Bambas
On 8/13/17 6:42 PM, Ed Morley wrote: For the short term, Nightly users therefore have the following options: a) Use latest nightly with legacy extensions disabled, and make do without their extensions. There is also a2): find webext based alternatives "by hand" (what I have done and intend to

Re: Figuring out and controlling what tasks run before first paint

2017-08-09 Thread Honza Bambas
What you are looking for sounds pretty much like my Backtrack project [1]. It's still under development, tho, but I have strong motivations to move it forward in Q4/17. The goal of Backtrack is exactly what you are looking for - find the right scheduling prioritization. It's said we don't hav

Re: Correct format specifier for size_t

2017-07-25 Thread Honza Bambas
is purpose. Cheers, Botond On Tue, Jul 25, 2017 at 12:43 PM, Honza Bambas wrote: In light of using PRxx formatting macros from inttypes.h, what is the right approach to printf size_t types (like our nsTArray::Length()) ? Not sure if to use "%zu" di

Correct format specifier for size_t

2017-07-25 Thread Honza Bambas
In light of using PRxx formatting macros from inttypes.h, what is the right approach to printf size_t types (like our nsTArray::Length()) ? Not sure if to use "%zu" directly. Thanks. -hb- ___ dev-platform mailing list dev-platform@lists.mozilla.org h

Changes to how protocol handlers work with the LOAD_REPLACE flag

2017-07-05 Thread Honza Bambas
tl;dr: protocol handlers no longer set the LOAD_REPLACE flag, instead set loadInfo.resultPrincipalURI to channel.URI to change the address bar displayed URL. More details in bug 1319111 [1]. In a bit more details - state BEFORE: - The URL used for the result principal of the document (and sh

Re: Converting const char (&name)[N] to nsACString

2017-07-04 Thread Honza Bambas
Use NS_NAMED_LITERAL_CSTRING, see [1] for plenty of examples. -hb- [1] https://dxr.mozilla.org/mozilla-central/search?q=NS_NAMED_LITERAL_CSTRING&case=false On 7/4/17 3:47 PM, Dexter wrote: Hi everyone! Could you tell me please, how I can clearly convert char (&name)[N] to nsACString? I t

Re: windows build anti-virus exclusion list?

2017-03-17 Thread Honza Bambas
I have a very similar setup, with even way more exceptions added, but none of them has the desired effect. Unfortunately, the only way to make MsMpEng shut up is to disable run-time protection completely for the time of the build. I think it's a bug in Defender. On a 20 core system it saves ~3

Re: Please write good commit messages before asking for code review

2017-03-10 Thread Honza Bambas
Thanks for bringing this up here, Ehsan. I have to concur. For more then just trivial patches I usually ask for a description of the patch in bugzilla - the commit message is usually not enough. Anything that can help the review by understanding the intention and structure of the patch helps

Re: Project Stockwell (reducing intermittents) - March 2017 update

2017-03-07 Thread Honza Bambas
I presume that when a test is disabled a bug is filed and triaged within the responsible team as any regular bug. Only that way we don't forget and push on fixing it and returning back to the wheel. Are there also some data or stats how often tests having a strong orange factor catch actual r

Re: ANN: Default bug view for BMO changed today!

2017-03-03 Thread Honza Bambas
Few questions: - Are there any plans on a higher contrast version of the new UI? Honestly, having titles overs comments light gray on a light gray background is at least pretty sad. Also citations are again gray making navigation among comments pretty hard just making my eyes more tired. -

Re: Why I don't like DXR

2016-09-28 Thread Honza Bambas
Thanks everyone for answers. This is helpful, but why don't I see any help like this right on DXR? Why do I have to ask on dev-platform? According identifiers not found on DXR I presume MXR might suffered the same issue, so no blame for DXR here. I was just confused by not being able to eas

Why I don't like DXR

2016-09-26 Thread Honza Bambas
Today I tried to search for an identifier on DXR. Something that was so easy with MXR... I wanted to find usage of a member called "io_pending". Typing that string to the DXR search field gives me a number of results that are definitely not what I'm looking for, like lines containing ERROR_

Re: DXR: How to encourage people to link to perma-links instead of plain ones?

2016-08-08 Thread Honza Bambas
On 8/8/2016 15:35, Boris Zbarsky wrote: On 8/8/16 9:02 AM, Xidorn Quan wrote: Would that make it harder for people to jump into some file directly via history (or awesome bar)? I _think_ the suggestion is as follows: When you click a link to a particular line in dxr, that would normally navi

DXR: How to encourage people to link to perma-links instead of plain ones?

2016-08-08 Thread Honza Bambas
tl;dr: plain DXR links quickly become outdated -> push people to use perma-links instead by adjusting the DXR UI. Long version: When a link like [1] - let's call it a plain link, the link copied from the URL bar - is added to e.g. bugzilla or an email, it will soon point to a wrong line when

Re: IPCStream landed in mozilla-central

2016-05-21 Thread Honza Bambas
On 5/21/2016 15:10, Ben Kelly wrote: On May 21, 2016 7:45 AM, "Honza Bambas" wrote: But that doesn't mean "a fixed length input stream" - actually I may not even follow how you have translated this to you. Sorry, I was thinking a single OnDataAvailable call for the

Re: IPCStream landed in mozilla-central

2016-05-21 Thread Honza Bambas
On 5/21/2016 2:36, Ben Kelly wrote: On Fri, May 20, 2016 at 8:10 PM, Ben Kelly wrote: On Fri, May 20, 2016 at 11:09 AM, Ben Kelly wrote: On Fri, May 20, 2016 at 7:37 AM, Honza Bambas wrote: And I do! :) Actually any parent necko channel, mainly HTTP, which sends data to the child

Re: IPCStream landed in mozilla-central

2016-05-20 Thread Honza Bambas
On 5/19/2016 17:04, Ben Kelly wrote: Hi all, FYI, I've landed a new IPDL type in bug 1093357 called IPCStream. This is intended to make it easier to serialize nsIInputStreams across IPC. In short, IPCStream: 1) Supports our existing serializable nsInputStreams. 2) Also automatically handles s

Re: Removing the Chromium event loop

2016-03-31 Thread Honza Bambas
On 3/30/2016 20:21, Kyle Huey wrote: In the department-of-paying-down-technical-debt, I'm planning to remove much of the Chromium event loop over the next few months. You can follow along in bug 1260828. The rough outline: Step 1: Replace Task with nsIRunnable, without changing any other semant

Re: MOZ_LOG_FILE and MOZ_LOG_MODULES are now the environment variables for logging

2016-03-24 Thread Honza Bambas
On 3/21/2016 18:17, Nicholas Alexander wrote: On Mon, Mar 21, 2016 at 9:13 AM, Honza Bambas wrote: tl;dr: Start migrating to use of MOZ_LOG_* instead of NSPR_LOG_*. Don't worry about backward compatibility tho, when MOZ_LOG_* is not set, we fallback to NSPR_LOG_* values. Hi Honza, T

MOZ_LOG_FILE and MOZ_LOG_MODULES are now the environment variables for logging

2016-03-21 Thread Honza Bambas
tl;dr: Start migrating to use of MOZ_LOG_* instead of NSPR_LOG_*. Don't worry about backward compatibility tho, when MOZ_LOG_* is not set, we fallback to NSPR_LOG_* values. The longer version: Since the new logging code sits in XPCOM and has no longer anything to do with NSPR and NSPR loggi

Re: Unsafe CPOWs are about to be outlawed in browser code

2016-01-28 Thread Honza Bambas
Do we have any agenda for extensions? I'm using FireGestures and it's broken since this has landed, just shouting out a lot of "unsafe CPOW usage" (missing the "forbidden" tho). Is the action here limited to just file a bug on the add-on side to fix this or can we do anything on our side? (I

Re: Just Autoland It

2016-01-28 Thread Honza Bambas
On 1/28/2016 6:30, Karl Tomlinson wrote: Honza Bambas writes: On 1/25/2016 20:23, Steve Fink wrote: For navigation, there's a list of changed files at the top (below the fixed summary pane) that jumps to per-file anchors. Not good enough for review process. Are you saying you want ta

Re: Just Autoland It

2016-01-27 Thread Honza Bambas
On 1/25/2016 20:23, Steve Fink wrote: Thanks a lot for this exhausting description. It's huge and that way shows how complicated the rev board is. These instructions kinda help, however I still perceive the review board as pain to work with. - how can I see only a single file diff and easil

Re: Just Autoland It

2016-01-26 Thread Honza Bambas
On 1/26/2016 16:46, Benjamin Smedberg wrote: On 1/26/2016 10:26 AM, Boris Zbarsky wrote: On 1/26/16 7:38 AM, Axel Hecht wrote: Which is basically what I do whenever I want to do something. I have a clear idea and intention on what I want to show up on bugzilla, but not on what to do on review

Re: Dynamic Logging

2016-01-25 Thread Honza Bambas
Nice idea although unfortunately incomplete. On Windows this has no effect at all. We cannot use it for common users. When you set the pref, it logs only to the debug output that can be captured only with visual studio or similar software being attached. Not something to ask for a common us

Re: Just Autoland It

2016-01-25 Thread Honza Bambas
Writing both as a patch author and a reviewer as well. - as a patch author I want a full control on when the patch actually lands (dependencies, any other timing reasons, that only the author knows the best), "Don't land yet" comment somewhere will easily be overlooked - as a reviewer I don't

Re: Proposal to stop revving UUIDs when changing XPIDL interfaces

2016-01-18 Thread Honza Bambas
On 1/15/2016 21:02, Ehsan Akhgari wrote: On 2016-01-15 2:21 PM, Bobby Holley wrote: Has anyone measured recently whether there's still a significant perf win to making IIDs 32-bit? If we stop using them as a versioning tool, we could potentially relax our uniqueness requirements, and save a lot

Re: Finding out if the main thread is currently animating

2015-10-30 Thread Honza Bambas
On 10/30/2015 2:35, Ehsan Akhgari wrote: On 2015-10-29 9:47 AM, David Rajchenbach-Teller wrote: The main thread of the current chrome/content process. Indeed, animations are one of my two use cases, the other one being user-input latency, but I'm almost sure I know how to deal with the latter.

Re: Stop using PL_strchr/strstr et al for parsing - use mozilla::Tokenizer

2015-08-14 Thread Honza Bambas
On 7/29/2015 22:51, Daniel Stenberg wrote: On Wed, 29 Jul 2015, Honza Bambas wrote: I've recently introduced a class making parsing string inputs much safer and simpler. http://www.janbambas.cz/string-parsing-made-simple-with-mozillatokenizer/ Nice! How does it act when hitting

Re: Stop using PL_strchr/strstr et al for parsing - use mozilla::Tokenizer

2015-07-29 Thread Honza Bambas
On 7/29/2015 19:40, Kyle Huey wrote: On Wed, Jul 29, 2015 at 7:15 AM, Honza Bambas wrote: I've recently introduced a class making parsing string inputs much safer and simpler. Please see xpcom/ds/Tokenizer.h. It's simplification of a lexical analyzer and it successfully hides bound

Stop using PL_strchr/strstr et al for parsing - use mozilla::Tokenizer

2015-07-29 Thread Honza Bambas
I've recently introduced a class making parsing string inputs much safer and simpler. Please see xpcom/ds/Tokenizer.h. It's simplification of a lexical analyzer and it successfully hides boundary checks on the input buffer from consumers. From now on this simple parser class should be used i

Re: Implement Fetch?

2015-07-21 Thread Honza Bambas
On 7/18/2015 1:42, Kyle Huey wrote: To be abundantly clear, no I/O should be happening (or is, to my knowledge) on the main thread when you use XHR. The limitation today is that various Necko state operations (e.g. opening a channel) can only happen on the main thread. The main offenders here a

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-08 Thread Honza Bambas
On 7/8/2015 3:08, Gregory Szorc wrote: On Tue, Jul 7, 2015 at 5:13 PM, Jeff Gilbert wrote: On Tue, Jul 7, 2015 at 3:59 PM, Eric Rahm wrote: I'm not a huge fan of the 'aFoo' style, but I am a huge fan of consistency. So if we want to change the style guide we should update our codebase, and

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-07 Thread Honza Bambas
On 7/7/2015 21:27, Jeff Gilbert wrote: On Tue, Jul 7, 2015 at 4:54 AM, Honza Bambas wrote: I'm strongly against removing the prefix. I got used to this and it has its meaning all the time I inspect code (even my own) and doing reviews. Recognizing a variable is an argument is very

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-07 Thread Honza Bambas
On 7/7/2015 19:38, Boris Zbarsky wrote: On 7/7/15 11:49 AM, Mike Conley wrote: I suspect that knowing what things were passed into a method or function is something that can be divined via static analysis. Aren't there tools for our (admittedly varied) editors / IDEs And debuggers. And dxr a

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-07 Thread Honza Bambas
as I'm tracing a variable with the prefix, whereas otherwise I would have to step backwards through each frame to see where the variable is coming from. I'll probably find some way to adapt if we remove the prefix though. kats On Tue, Jul 7, 2015 at 7:54 AM, Honza Bambas wrote: I&#

Re: Proposal to remove `aFoo` prescription from the Mozilla style guide for C and C++

2015-07-07 Thread Honza Bambas
I'm strongly against removing the prefix. I got used to this and it has its meaning all the time I inspect code (even my own) and doing reviews. Recognizing a variable is an argument is very very useful. It's important to have it and it's good we enforce it! -hb- On 7/7/2015 5:12, Jeff Gil

New performance tool: Backtrack

2015-06-02 Thread Honza Bambas
I'm announcing a new tool that can be used for performance analyzes at runtime. It's called Backtrack and is built on top of Gecko Profiler and Task Tracer. The goal is to capture full code path flows from any point of the code back to its source, crossing asynchronous callbacks, threads, pro

Re: How to inspect Js callstack from C++ callstack, I am using visual studio to debugging

2015-06-02 Thread Honza Bambas
invoke DumpJSStack() from the debugger. It will output to console or to the VC++ output window. -hb- On 6/1/2015 11:26, 罗勇刚(Yonggang Luo) wrote: mozjs.dll!js::jit::BaselineScript::icEntryFromPCOffset(unsigned int pcOffset) Line 553 C++ mozjs.dll!js::jit::DebugModeOSRVolatileStub::invali

Re: Announcing Operation Instrument

2015-04-30 Thread Honza Bambas
On 4/30/2015 2:08, Robert O'Callahan wrote: On Thu, Apr 30, 2015 at 2:52 AM, Honza Bambas wrote: Just let you know about my intensive work on "Backtrack" or "Caller Chain" which is about connecting Gecko Profiler and Task Tracer together to catch all (instrumente

Re: Announcing Operation Instrument

2015-04-29 Thread Honza Bambas
Just let you know about my intensive work on "Backtrack" or "Caller Chain" which is about connecting Gecko Profiler and Task Tracer together to catch all (instrumented) inter-object and inter-thread calls + IO blocking, lock waits, queuing, event (nsIRunnable) dispatches, network query/response

Re: PSA: Network 'jank' - get your blocking IO off of STS thread!

2015-03-26 Thread Honza Bambas
One more place: https://bugzilla.mozilla.org/show_bug.cgi?id=1147921 -hb- On 3/26/2015 16:14, Patrick McManus wrote: good catch.. looking at https://mxr.mozilla.org/mozilla-central/ident?i=NS_SOCKETTRANSPORTSERVICE_CONTRACTID the only uses I see other than the one Ehsan unearthed are expected.

Re: Rethinking the crash experience

2014-07-08 Thread Honza Bambas
On 7/8/2014 21:23, Robert Kaiser wrote: David Rajchenbach-Teller schrieb: 5. Upon the next restart, display a bottom doorhanger on all windows "Firefox or an add-on encountered a problem [a few seconds ago / on July 4rd, 2014] and recovered. If you wish, Firefox can report it automatically so th

HTTP cache v2 now enabled "for real" on mozilla-inbound

2014-05-16 Thread Honza Bambas
Hi all, yesterday we have landed a patch that switches the pref to use the new HTTP cache (bug 913806). It is enabled for all infra tests, talos and Nightly users. In case of any catastrophic problems it's easy to switch back (nothing more then flipping the pref back). So far we know about

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Honza Bambas
On 4/2/2014 5:24 PM, Trevor Saunders wrote: On Wed, Apr 02, 2014 at 05:03:53PM +0200, Honza Bambas wrote: On 4/2/2014 11:33 AM, Nicolas B. Pierron wrote: --lock(mRefCnt); if (lock(mRefCnt) == 0) { delete this; } This way, this is more obvious that we might not be doing the right things, as

Re: mozilla::Atomic considered harmful

2014-04-02 Thread Honza Bambas
On 4/2/2014 11:33 AM, Nicolas B. Pierron wrote: --lock(mRefCnt); if (lock(mRefCnt) == 0) { delete this; } This way, this is more obvious that we might not be doing the right things, as long as we are careful to refuse AtomicHandler references in reviews. I personally don't think this w

Re: Visual Studio Project Generation

2014-02-24 Thread Honza Bambas
On 2/21/2014 7:31 AM, "Yuan Xulei(袁徐磊)" wrote: That's really good! I'm looking forward to eclipse project generation feature. +1 -hb- PS: Gregory, thanks for your work on VS project generation! It's a pretty good stuff. ___ dev-platform mailing l

Re: New necko cache?

2014-02-20 Thread Honza Bambas
On 2/20/2014 10:25 PM, Neil wrote: Well, that was confusing. The old contract ID was @mozilla.org/network/cache-service;1 The new contract ID is @mozilla.org/netwerk/cache-storage-service;1 Turns out that there are two differences, not one. Yes, forgot to mention, sorry. Hoped it's obvious from

Re: New necko cache?

2014-02-20 Thread Honza Bambas
On 2/20/2014 7:01 PM, Neil wrote: Honza Bambas wrote: On 2/19/2014 11:25 PM, Neil wrote: In particular, the API calls I'm interested in: 1. Given an HTTP or FTP URI, return the size of the cached data How do you do that now? Only way known to me (with the old cache is visit of a

Re: New necko cache?

2014-02-20 Thread Honza Bambas
On 2/19/2014 11:25 PM, Neil wrote: Is the conversion straightforward? The API is mostly similar, we've took it more as a chance for a cleanup since some modification were necessary anyway. In particular, the API calls I'm interested in: 1. Given an HTTP or FTP URI, return the size of the

Re: New necko cache?

2014-02-19 Thread Honza Bambas
On 2/19/2014 11:09 PM, Neil wrote: Honza Bambas wrote: On 2/19/2014 1:56 AM, Neil wrote: Where can I find documentation for the new necko cache? So far I've only turned up some draft planning documents. In particular, I understand that there is a preference to toggle the cache. What

Re: New necko cache?

2014-02-19 Thread Honza Bambas
On 2/19/2014 1:56 AM, Neil wrote: Where can I find documentation for the new necko cache? So far I've only turned up some draft planning documents. In particular, I understand that there is a preference to toggle the cache. What does application code have to do in order to work with whichever c

Individual files should have a reviewer reference

2014-02-13 Thread Honza Bambas
An optional /* @reviewer: m...@foo.com */ comment under the license would do. If not present, find reviewer the usual way (not always hitting the right person). Reason is that despite we have peer lists, sometimes files are written/maintained by non-peers of the module a file is in or should

You can now get NSPR logs from tryserver mochitest runs

2014-01-22 Thread Honza Bambas
Hi all, I've just landed a simple patch that allows you to setup NSPR log modules to get an NSPR log from a try push. Instructions: * Open the script file testing/mochitest/runtests.py * Search for NSPR_LOG_MODULES = "", should look as: # Set the desired log modules you want an N

Re: NSPR logging dropping log messages

2013-12-06 Thread Honza Bambas
On 12/6/2013 7:24 PM, Ehsan Akhgari wrote: On 12/6/2013, 1:19 PM, Honza Bambas wrote: On 12/6/2013 6:44 PM, Ehsan Akhgari wrote: I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think any of those bugs that you referenced i

Re: NSPR logging dropping log messages

2013-12-06 Thread Honza Bambas
On 12/6/2013 6:44 PM, Ehsan Akhgari wrote: I was talking about filing a bug where we would take the patch that you attached to the previous email. I don't think any of those bugs that you referenced is the right place to do that. Cheers, Ehsan My patch is probably not something that should

Re: NSPR logging dropping log messages

2013-12-06 Thread Honza Bambas
On 12/6/2013 5:31 PM, Ehsan Akhgari wrote: Can you please file a bug about this so that we can try to get this patch landed? WTC recently indicated to me (in ) that we should probably start adding support for having our own NSPR patche

Re: NSPR logging dropping log messages

2013-12-06 Thread Honza Bambas
On 12/6/2013 6:48 AM, Brian Smith wrote: On Thu, Dec 5, 2013 at 9:46 PM, Robert O'Callahan wrote: bug 924253 I think we should also be careful that, when we have multiple processes (which is always, because of e10s-based about:newtab fetching), that those multiple processes are not clobbering

Re: [RFC] Cleaning up sessionstore.js

2013-11-28 Thread Honza Bambas
On 11/28/2013 12:56 PM, David Rajchenbach-Teller wrote: As many of you know, Session Restore is something of a performance hog, for many reasons – we have reports of. One of the reasons is that we store so very many things in sessionstore.js and sometimes keep stuff for a very long time. As part

Re: Faster builds, now.

2013-10-07 Thread Honza Bambas
Is this supposed to work on Windows too? a clobbered build of up to date m-c with export MOZ_PSEUDO_DERECURSE=1 gives me an error during configure phase (./mach build): 1:36.03 Traceback (most recent call last): 1:36.03 File "c:/Mozilla/src/mozilla-central/build/pymake/make.py", line 30,

Re: review stop-energy (was 24hour review)

2013-07-15 Thread Honza Bambas
On 7/15/2013 8:36 PM, Chris Peterson wrote: On 7/15/13 7:10 AM, Honza Bambas wrote: - providing patch split to logically separated parts with numbers like "part 1 of 6" - and also a complete (folded) patch for reference - strictly versioning the patch among review rounds - when submit

Re: review stop-energy (was 24hour review)

2013-07-15 Thread Honza Bambas
On 7/10/2013 3:09 PM, smaug wrote: Splitting patches is usually useful, but having a patch containing all the changes can be also good. If you have a set of 20-30 patches, but not a patch which contains all the changes, it is often hard to see the big picture. Again, perhaps some tool could help

Re: Ordering shutdown observers?

2013-05-16 Thread Honza Bambas
On 5/16/2013 8:12 PM, Ehsan Akhgari wrote: A dependency system for startup/shutdown isn't free. It's going to have runtime cost, and it's going to make the code more complicated. Given the fact that we've managed to get by just fine without one for years, I think we should continue to do that

Re: Storage in Gecko

2013-05-03 Thread Honza Bambas
If you guys don't need transactions and only a simple key+value storage, the new localstorage code be used. Only thing needed to make it work in a completely non-blocking way is to expose API telling the consumer that localstorage has loaded from disk and is fully cached in memory and thus acc

Re: Clearing appcache entries

2013-04-15 Thread Honza Bambas
Thanks for bringing this up Mike. True is that our appcache implementation and APIs a bit suck. But good news is that it is going to be much better with APIs being currently newly proposed and discussed for Necko's disk cache (so far, privately, soon it will open). To answer your issue: var

TimeStamp::NowLoRes()

2013-02-12 Thread Honza Bambas
This new method provides much lower performance hit time interval where high precision timing is not needed. Implemented in bug 827287, landed on m-c today. On the Windows platform it gives resolution of aprox 16ms, using GetTickCount() which is by a magnitude cheaper to call then QueryPerfor

Re: TimeStamp too expensive?

2013-01-07 Thread Honza Bambas
On 1/7/2013 1:40 PM, Jeff Muizelaar wrote: Probably. I'd suggest adding a TimeStamp::LowResNow() as an alias for Now() and filing a bug about getting a cheaper implementation of that function on Windows. FWIW, Chrome has something similar to this as well. -Jeff I was recently talking about t

Re: BFCache & Application Cache

2012-12-04 Thread Honza Bambas
On 11/30/2012 8:25 AM, Jan Honza Odvarko wrote: On Nov 29, 11:15 pm, Honza Bambas wrote: You may QI the channel to nsIApplicationCacheChannel and check for loadedFromApplicationCache attribute. ok, works for me, thanks. I'm just interested in how you recognize a bfcache

Re: BFCache & Application Cache

2012-11-29 Thread Honza Bambas
On 11/29/2012 12:41 PM, Jan Honza Odvarko wrote: Firebug's Net panel is already showing responses coming from BFCache (http://www.softwareishard.com/blog/firebug/firebug-tip-what-the-heck- is-bfcache/) and now we'd like to support also Application Cache: https://developer.mozilla.org/en-US/docs/H

Re: When nsGlobalWindow gets its principal?

2012-11-21 Thread Honza Bambas
On 11/21/2012 4:06 PM, Boris Zbarsky wrote: On 11/21/12 9:50 AM, Honza Bambas wrote: The question is: where is a good place where nsGlobalWindow already knows its associated principal to trigger the preload? Outer window, or inner window? The same window localStorage getter is called on, so

When nsGlobalWindow gets its principal?

2012-11-21 Thread Honza Bambas
Hi all, I'm completely re-implementing localStorage (and sessionStorage) implementation to be simpler and faster. One of features of the new code is a way to start async background cache preload as soon as we know global window is going to load a content page. The question is: where is a go

Re: Proposal: move content JS interpretation to a background thread

2012-11-08 Thread Honza Bambas
On 11/8/2012 10:19 PM, Kyle Huey wrote: On Thu, Nov 8, 2012 at 12:52 PM, Honza Bambas wrote: Few reasons: - I really don't believe we will soon/ever have a good OOP Firefox implementation - content JS execution very often kills my Firefox UI (and it is not I/O that blocks) - sync APIs

Proposal: move content JS interpretation to a background thread

2012-11-08 Thread Honza Bambas
Few reasons: - I really don't believe we will soon/ever have a good OOP Firefox implementation - content JS execution very often kills my Firefox UI (and it is not I/O that blocks) - sync APIs like localStorage would not block the UI - content JS GC would stop blocking UI as well - generally wo

Re: Shipping a component as part of the test package

2012-11-08 Thread Honza Bambas
On 11/8/2012 8:10 PM, Gregory Szorc wrote: On 11/8/12 11:04 AM, Honza Bambas wrote: On 11/8/2012 12:26 AM, Benjamin Smedberg wrote: On 11/7/12 12:00 PM, Honza Bambas wrote: Hi all. I'd like to ask for help. tl;dr: a new JS component needs to be accessible by xpcshell and mochitest, h

Re: Shipping a component as part of the test package

2012-11-08 Thread Honza Bambas
On 11/8/2012 12:26 AM, Benjamin Smedberg wrote: On 11/7/12 12:00 PM, Honza Bambas wrote: Hi all. I'd like to ask for help. tl;dr: a new JS component needs to be accessible by xpcshell and mochitest, how to do that? It's not clear to me why this needs to be a component. Since we al

Re: Shipping a component as part of the test package

2012-11-07 Thread Honza Bambas
On 11/7/2012 9:03 PM, Bobby Holley wrote: We have some XPConnect test components in js/xpconnect/tests/components that might be instructive. Cheers, bholley Those are modules, also as Joshua pointed out. I want a component that *not* tests will use, but test-*harness* will use. We already h

Shipping a component as part of the test package

2012-11-07 Thread Honza Bambas
Hi all. I'd like to ask for help. tl;dr: a new JS component needs to be accessible by xpcshell and mochitest, how to do that? Details: I'm introducing a new JS implemented component that is used to control ssltunnel (a part of our testing infrastructure). I want test harnesses use it. H

Re: mach has landed

2012-10-04 Thread Honza Bambas
So, another subject: when I do a full build in parallel (win/pymake or using mach) and there is some build error, it is always very hard to track the error down in the log, it is almost always hidden among many other lines. I just hit some compilation error caused by some recent patch in conj

  1   2   >