On 1/26/2016 16:46, Benjamin Smedberg wrote:
On 1/26/2016 10:26 AM, Boris Zbarsky wrote:
On 1/26/16 7:38 AM, Axel Hecht wrote:
Which is basically what I do whenever I want to do something. I have a
clear idea and intention on what I want to show up on bugzilla, but not
on what to do on reviewboard to get there. Which might just be a
category of documentation that's not written yet.
Not just. For example, there is no way to "r-" in mozreview. You can
only "r+" or remove the review request, in Bugzilla terms.
There is a pattern that some teams have been using where they never
mark "r-" on a change. I think the rationale for this is that it feels
negative and discouraging to receive the "review not granted" email,
especially for new contributors. Instead, they will either clear the
review or mark an f+ and ask for a new patch.
I don't like this practice: I encourage people to use the r- flag.
It's important to make clear in bugzilla that something has already
been reviewed and that the result is that something is not ready.
Without r- or something very similar, it's difficult to distinguish
between various important cases:
* I'm too busy/not the right person to review this (clear the review
or redirect it)
* I started the review and have a question (leave the r? flag, add a
NEEDINFO)
* This isn't good enough (r-)
* I've looked this over and it's ok in general, but it still needs a
detailed code review: mark f+, redirect the r? flag as appropriate
In addition, I've seen several contributors become confused receiving
an f+ and not realizing that what it really meant is "not good enough,
please make changes".
Our reviewboard tooling should support explicit r- and not just
clearing review flags.
+1 and I also like the feature of bugzilla UI to allow clicking the r-
flag by the patch to jump to the actual feedback comment (that e.g. I
gave two weeks ago and don't remember). It's good to set at least some
flag on a patch when review/feedback is done with whatever result.
-hb-
--BDS
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
