On 7/15/2013 8:36 PM, Chris Peterson wrote:
On 7/15/13 7:10 AM, Honza Bambas wrote:
- providing patch split to logically separated parts with numbers like
"part 1 of 6"
- and also a complete (folded) patch for reference
- strictly versioning the patch among review rounds
- when submitting a new version of a patch after r- always explain what
has changed and provide an interdiff
If reviewee submits a new version of (say) patch 1 of 6, should they:
* attach patch 1 version 2
yes, with title "Patch 1 of 6, whatever description, v2"
* an interdiff between patch 1 version 1 and 2
depends on complexity (I always ask), but idiff of a new full patch
might be enough
* and a new complete/folded patch (of patches 1-6)?
for sure, but also depends on if you ask more then one reviewer. I
consider it a bit impolite to obsolete a patch that somebody is just
reviewing. communication!
Which file would be r+'d for review?
all parts all the complete one, depends also on how many reviewers you ask
-hb-
chris
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
_______________________________________________
dev-platform mailing list
dev-platform@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-platform
