Re: Pymake/py3k: lazy vs eager

2014-07-02 Thread Mike Hommey
On Wed, Jul 02, 2014 at 03:06:46PM -0700, Gregory Szorc wrote: > On 7/2/14, 3:00 PM, Mike Hommey wrote: > >On Wed, Jul 02, 2014 at 01:34:19PM -0700, Gregory Szorc wrote: > >>On 7/2/14, 1:20 PM, Benjamin Smedberg wrote: > - mozilla-central's make.py has a hack in place to redirect bot builds > >

Re: Pymake/py3k: lazy vs eager

2014-07-02 Thread Gregory Szorc
On 7/2/14, 3:00 PM, Mike Hommey wrote: On Wed, Jul 02, 2014 at 01:34:19PM -0700, Gregory Szorc wrote: On 7/2/14, 1:20 PM, Benjamin Smedberg wrote: - mozilla-central's make.py has a hack in place to redirect bot builds to mozmake.exe. That's fine, I guess (in its genre), but shouldn't be necessa

Re: Pymake/py3k: lazy vs eager

2014-07-02 Thread Mike Hommey
On Wed, Jul 02, 2014 at 01:34:19PM -0700, Gregory Szorc wrote: > On 7/2/14, 1:20 PM, Benjamin Smedberg wrote: > >>- mozilla-central's make.py has a hack in place to redirect bot builds > >>to mozmake.exe. That's fine, I guess (in its genre), but shouldn't be > >>necessary now that mozmake is the de

Re: Pymake/py3k: lazy vs eager

2014-07-02 Thread Gregory Szorc
On 7/2/14, 2:52 PM, Kim Gräsman wrote: On Wed, Jul 2, 2014 at 9:45 PM, Kim Gräsman wrote: Ah, I thought it was just made non-default. Thanks, waiting for that full build to complete! OK, so I now have preliminary perf data. - Before is ``mach build -p content`` with the plain pymake in mozi

Re: Pymake/py3k: lazy vs eager

2014-07-02 Thread Kim Gräsman
On Wed, Jul 2, 2014 at 9:45 PM, Kim Gräsman wrote: > > Ah, I thought it was just made non-default. Thanks, waiting for that > full build to complete! OK, so I now have preliminary perf data. - Before is ``mach build -p content`` with the plain pymake in mozilla-central - After is ``mach build -p

Re: Pymake/py3k: lazy vs eager

2014-07-02 Thread Kim Gräsman
On Wed, Jul 2, 2014 at 10:34 PM, Gregory Szorc wrote: > > We still have code in m-c using the pymake apis for make file analysis. I > suppose we could remove it from tree once pymake is installable via pypi. At > that time, we'll make the mach commands install the remote package into the > virtual

Re: Pymake/py3k: lazy vs eager

2014-07-02 Thread Gregory Szorc
On 7/2/14, 1:20 PM, Benjamin Smedberg wrote: - mozilla-central's make.py has a hack in place to redirect bot builds to mozmake.exe. That's fine, I guess (in its genre), but shouldn't be necessary now that mozmake is the default. Right. We should consider removing build/pymake from mozilla-centra

Re: Pymake/py3k: lazy vs eager

2014-07-02 Thread Kim Gräsman
On Wed, Jul 2, 2014 at 10:20 PM, Benjamin Smedberg wrote: > >> >> This raises some questions: >> - Is build/ in the main pymake repo unused? If so, can I kill it? > > It looks like the tests that are currently in builds/pymake/tests ought to > just be in tests/ and got mis-committed. Sounds like w

Re: Pymake/py3k: lazy vs eager

2014-07-02 Thread Benjamin Smedberg
On 7/2/2014 3:45 PM, Kim Gräsman wrote: Related question: there are differences between the pymake in mozilla-central and the master at http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/ on which you based the GitHub repo. That's unfortunate. the mozilla-central version was supposed to

Re: Pymake/py3k: lazy vs eager

2014-07-02 Thread Kim Gräsman
On Wed, Jul 2, 2014 at 6:08 PM, Gregory Szorc wrote: >> >> Is there a recipe to force pymake in there somehow? >> > > We recently removed support for building Firefox with pymake. > > You'll have to `hg up` to a commit that supports building with pymake. May I > recommend ec839f8c7a38, the first c

Re: Pymake/py3k: lazy vs eager

2014-07-02 Thread Gregory Szorc
On 7/1/14, 10:07 PM, Kim Gräsman wrote: On Tue, Jul 1, 2014 at 6:33 AM, Kim Gräsman wrote: I'll make an effort to get the Firefox build going, but I usually can't get representative results in my build environment. So I managed to build Firefox with mach and its defaults, but I can't figure