On Wed, Jul 2, 2014 at 6:08 PM, Gregory Szorc <g...@mozilla.com> wrote: >> >> Is there a recipe to force pymake in there somehow? >> > > We recently removed support for building Firefox with pymake. > > You'll have to `hg up` to a commit that supports building with pymake. May I > recommend ec839f8c7a38, the first commit for Firefox 33. > > Benchmarking |mach build -p content| after a full build should be a good > enough indicator of performance.
Ah, I thought it was just made non-default. Thanks, waiting for that full build to complete! Related question: there are differences between the pymake in mozilla-central and the master at http://hg.mozilla.org/users/bsmedberg_mozilla.com/pymake/ on which you based the GitHub repo. Diff report from Beyond Compare below, I haven't managed to get a unified diff: Left base folder: D:\dev\mozilla\pymake Right base folder: D:\dev\mozilla\mozilla-central\build\pymake Name Size Modified Name Size Modified ---------------------------------------------------------------------------------------------------------------- .hg 2014-07-02 17:31:20 build 2014-07-02 17:31:20 pymake 193 451 2014-07-02 17:31:20 pymake 406 240 2014-07-02 21:05:20 \data.py 62 528 2014-07-02 17:31:20 <> \data.py 62 126 2014-07-01 20:23:48 tests 133 513 2014-07-02 17:31:20 tests 133 274 2014-07-02 20:53:25 +empty-rule.mk 188 2014-07-02 17:31:20 >> | | << \foreach-local-variable.mk 230 2014-07-01 20:23:48 +glob1.inc 5 2014-07-02 17:31:20 >> +glob2.inc 4 2014-07-02 17:31:20 >> +include-glob.mk 105 2014-07-02 17:31:20 >> \include-required-fails.mk 167 2014-07-02 17:31:20 >> make.py 456 2014-07-02 17:31:20 <> make.py 1 023 2014-07-02 20:11:48 ---------------------------------------------------------------------------------------------------------------- This raises some questions: - Is build/ in the main pymake repo unused? If so, can I kill it? - foreach-local-variable.mk is among the tests in mozilla-central, but in build/pymake/tests in master pymake. It should be among the tests, right? - empty-rule.mk is consistently failing here, and is gone in mozilla-central. Remove it? - include-glob.mk and friends seem to be testing new include/globbing functionality in data.py, so I'm guessing this should stay - mozilla-central's make.py has a hack in place to redirect bot builds to mozmake.exe. That's fine, I guess (in its genre), but shouldn't be necessary now that mozmake is the default. All this said, I think I'll just copy my py3k-modded pymake into mozilla-central's tree and run the build; as far as I can see they are compatible. Cheers, - Kim _______________________________________________ dev-builds mailing list dev-builds@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-builds
