On Wed, Jul 2, 2014 at 10:20 PM, Benjamin Smedberg <benja...@smedbergs.us> wrote: > >> >> This raises some questions: >> - Is build/ in the main pymake repo unused? If so, can I kill it? > > It looks like the tests that are currently in builds/pymake/tests ought to > just be in tests/ and got mis-committed. Sounds like we should just move > them to the right spot.
OK, cool. default-goal-set-first.mk already exists in tests/ at 108 bytes (it's zero-sized in build/pymake/tests) foreach-local-variable.mk matches exactly what's in mozilla-central's tests/ I'll post a PR to clean that up. >> - empty-rule.mk is consistently failing here, and is gone in >> mozilla-central. Remove it? > > Is it testing something important? It dates back to > https://bugzilla.mozilla.org/show_bug.cgi?id=755828 and it looks like the > new test just never got added to mozilla-central. > > Before removing it we should understand if the test is broken or pymake > itself is broken. Thanks for digging up the history, I never got around to cross-referencing the two repo histories. It's hard for me to say what's broken, it appears to test that a target without a recipe evaluates correctly, but it looks weird overall, see my other thread on it: https://groups.google.com/forum/#!topic/mozilla.dev.builds/Fon-rGlLWhs >> - mozilla-central's make.py has a hack in place to redirect bot builds >> to mozmake.exe. That's fine, I guess (in its genre), but shouldn't be >> necessary now that mozmake is the default. > > Right. We should consider removing build/pymake from mozilla-central > entirely. OK, makes sense. I'll leave that to you grown-ups :-) Thanks, - Kim _______________________________________________ dev-builds mailing list dev-builds@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-builds
