Re: What is the correct way of reflecting make variables in moz.build?

On 2/17/2014, 3:18 PM, Ms2ger wrote: On 02/17/2014 08:09 PM, Ehsan Akhgari wrote: CFLAGS += $(TK_CFLAGS) I never quite figured out why we didn't just set those flags globally. That seems like a much easier solution. Can you please give an example of what you mean? I don't really understand

Re: CFLAGS in moz.build

On Mon, Feb 17, 2014 at 11:46 AM, Joshua Cranmer 🐧 wrote: > On 2/16/2014 8:07 PM, Ehsan Akhgari wrote: > >> What is the plan for porting CFLAGS and friends to moz.build? Is there >> any work in progress for that? How can one help? >> > > The plan, as I understand it, is to look at the uses of CF

Re: What is the correct way of reflecting make variables in moz.build?

On 02/17/2014 08:09 PM, Ehsan Akhgari wrote: CFLAGS += $(TK_CFLAGS) I never quite figured out why we didn't just set those flags globally. That seems like a much easier solution. Ms2ger ___ dev-builds mailing list dev-builds@lists.mozilla.org https

What is the correct way of reflecting make variables in moz.build?

We have a lot of places where we do things such as: CFLAGS += $(TK_CFLAGS) LOCAL_INCLUDES += $(DIST)/include/foo etc. What is the correct way of porting such variables to moz.build? Thanks! -- Ehsan ___ dev-builds mailing lis

Re: CFLAGS in moz.build

On 2/16/2014 8:07 PM, Ehsan Akhgari wrote: What is the plan for porting CFLAGS and friends to moz.build? Is there any work in progress for that? How can one help? The plan, as I understand it, is to look at the uses of CFLAGS et al and figure out what users are really trying to do with them

Fwd: CFLAGS in moz.build

I just realized that we fell off dev-builds last night. I posted a patch to bug 973649 to make it possible to use CFLAGS, CXXFLAGS and LDFLAGS in moz.build. Cheers, -- Ehsan -- Forwarded message -- From: Ehsan Akhgari Date: Sun, Feb 16, 2014 at 11:02