I just realized that we fell off dev-builds last night. I posted a patch to bug 973649 to make it possible to use CFLAGS, CXXFLAGS and LDFLAGS in moz.build.
Cheers, -- Ehsan <http://ehsanakhgari.org/> ---------- Forwarded message ---------- From: Ehsan Akhgari <ehsan.akhg...@gmail.com> Date: Sun, Feb 16, 2014 at 11:02 PM Subject: Re: CFLAGS in moz.build To: Gregory Szorc <g...@mozilla.com> OK great, I'll write the patches to implement the moz.build logic tomorrow and will start porting them. Presumably the same idea can be used for LDFLAGS as well, right? -- Ehsan <http://ehsanakhgari.org/> On Sun, Feb 16, 2014 at 10:34 PM, Gregory Szorc <g...@mozilla.com> wrote: > We probably want to use a set, list, dict, or some other data structure > that facilitates simple member testing and updating. > > On 2/16/2014 7:28 PM, Ehsan Akhgari wrote: > > Thanks! Does this mean that the conversion work can begin now? Do we > > plan to have CFLAGS as a string variable or do we want to do something > > fancier? (I would be fine with a string.) > > > > -- > > Ehsan > > <http://ehsanakhgari.org/> > > > > > > On Sun, Feb 16, 2014 at 10:08 PM, Gregory Szorc <g...@mozilla.com > > <mailto:g...@mozilla.com>> wrote: > > > > On 2/16/2014 6:07 PM, Ehsan Akhgari wrote: > > > What is the plan for porting CFLAGS and friends to moz.build? Is > > there > > > any work in progress for that? How can one help? > > > > There is the potential for weird interactions between config.mk > > <http://config.mk> and > > CFLAGS and friends, which is the primary reason we held off porting > it. > > I /think/ most of those concerns went away when we included > > backend.mk <http://backend.mk> > > in config.mk <http://config.mk> rather than in rules.mk > > <http://rules.mk>. But keep in mind there's still the > > potential for reordering issues: because of how variable assignment > > works in make and how variable evaluation is performed in rules.mk > > <http://rules.mk>, if a > > variable change *after* "include rules.mk <http://rules.mk>" in a > > Makefile.mk is moved to > > a moz.build, that may change behavior. CFLAGS manipulation before > > "include config.mk <http://config.mk>" or "include rules.mk > > <http://rules.mk>" should be safe to move to > > moz.build. Exercise extreme discretion if CFLAGS and friends are > > manipulated after including config.mk <http://config.mk> or rules.mk > > <http://rules.mk>. > > > > > >
_______________________________________________ dev-builds mailing list dev-builds@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-builds
